herdr-eternal-clippy-0.1.0
checks.x86_64-linux.clippy
· build #3
· raw
unpackPhase
1unpacking source archive /nix/store/0s5rnd7phya3a5wwqcz8p746i38z1xbg-source2source root is sourcepatchPhase
3Executing configureCargoCommonVars4decompressing cargo artifacts from /nix/store/xhkmxzdx1jgcp1f26xck267jvqpw0r5m-herdr-eternal-deps-0.1.0/target.tar.zst to targetconfigurePhase
5will append /build/source/.cargo-home/config.toml with contents of /nix/store/i53mafqa8lsdqmkbza3wbqawayy4d89d-vendor-cargo-deps/config.toml6default configurePhase, nothing to dobuildPhase
7+++ command cargo --version8cargo 1.97.0 (c980f4866 2026-06-30)9+++ command cargo clippy --release --locked --all-targets -- -D warnings10 Checking herdr-eternal-proto v0.1.0 (/build/source/proto)11 Checking herdr-eternal-server v0.1.0 (/build/source/server)12 Checking herdr-eternal-ssh v0.1.0 (/build/source/client)13error: this `if` statement can be collapsed14 --> client/src/lib.rs:250:1715 |16250 | / if agent_channel.is_none() {17251 | | if let (Some(socket), Some(token)) = (&target.agent_socket, &resume_token) {18252 | | agent_channel = Some(AbortOnDrop(tokio::spawn(agent::forward_agent(19253 | | target.clone(),20... |21258 | | }22 | |_________________^23 |24 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if25 = note: `-D clippy::collapsible-if` implied by `-D warnings`26 = help: to override `-D warnings` add `#[allow(clippy::collapsible_if)]`27help: collapse nested if block28 |29250 ~ if agent_channel.is_none()30251 ~ && let (Some(socket), Some(token)) = (&target.agent_socket, &resume_token) {31252 | agent_channel = Some(AbortOnDrop(tokio::spawn(agent::forward_agent(32...33256 | ))));34257 ~ }35 |3637error: could not compile `herdr-eternal-ssh` (lib) due to 1 previous error38warning: build failed, waiting for other jobs to finish...39error: this `if` statement can be collapsed40 --> server/src/auth.rs:69:941 |4269 | / if let Some(static_token) = &self.static_token {4370 | | if constant_time_eq(static_token.as_bytes(), presented.as_bytes()) {4471 | | return Ok(());4572 | | }4673 | | }47 | |_________^48 |49 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if50 = note: `-D clippy::collapsible-if` implied by `-D warnings`51 = help: to override `-D warnings` add `#[allow(clippy::collapsible_if)]`52help: collapse nested if block53 |5469 ~ if let Some(static_token) = &self.static_token5570 ~ && constant_time_eq(static_token.as_bytes(), presented.as_bytes()) {5671 | return Ok(());5772 ~ }58 |5960error: this `if` statement can be collapsed61 --> server/src/auth.rs:157:962 |63157 | / if let Some(client_id) = &claims.client_id {64158 | | if client_id != &self.config.client_id {65159 | | return Err(AuthError::WrongClient(client_id.clone()));66160 | | }67161 | | }68 | |_________^69 |70 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if71help: collapse nested if block72 |73157 ~ if let Some(client_id) = &claims.client_id74158 ~ && client_id != &self.config.client_id {75159 | return Err(AuthError::WrongClient(client_id.clone()));76160 ~ }77 |7879error: this `if` statement can be collapsed80 --> server/src/lib.rs:854:1781 |82854 | / if exit_code.is_some() {83855 | | if let Some(child) = child.as_mut() {84856 | | child.wait().await.ok();85857 | | }86858 | | }87 | |_________________^88 |89 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if90help: collapse nested if block91 |92854 ~ if exit_code.is_some()93855 ~ && let Some(child) = child.as_mut() {94856 | child.wait().await.ok();95857 ~ }96 |9798error: this `if` statement can be collapsed99 --> server/src/lib.rs:865:29100 |101865 | / ... if let Some(pipe) = stdin.as_mut() {102866 | | ... if pipe.write_all(&data).await.is_err() || pipe.flush().await.is_err() {103867 | | ... stdin = None;104868 | | ... }105869 | | ... }106 | |_______________________^107 |108 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if109help: collapse nested if block110 |111865 ~ if let Some(pipe) = stdin.as_mut()112866 ~ && (pipe.write_all(&data).await.is_err() || pipe.flush().await.is_err()) {113867 | stdin = None;114868 ~ }115 |116117error: this `if` statement can be collapsed118 --> server/src/lib.rs:888:25119 |120888 | / if let Some(pipe) = stdin.take() {121889 | | if let Ok(fd) = pipe.into_nonblocking_fd() {122890 | | fds.push(("stdin", fd));123891 | | }124892 | | }125 | |_________________________^126 |127 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if128help: collapse nested if block129 |130888 ~ if let Some(pipe) = stdin.take()131889 ~ && let Ok(fd) = pipe.into_nonblocking_fd() {132890 | fds.push(("stdin", fd));133891 ~ }134 |135136error: this `if` statement can be collapsed137 --> server/src/lib.rs:934:9138 |139934 | / if let Some(code) = exit_code {140935 | | if !stdout_open && !stderr_open {141936 | | seq += 1;142937 | | log.push(proto::ChannelMessage::Exit { seq, code });143... |144940 | | }145 | |_________^146 |147 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if148help: collapse nested if block149 |150934 ~ if let Some(code) = exit_code151935 ~ && !stdout_open && !stderr_open {152936 | seq += 1;153937 | log.push(proto::ChannelMessage::Exit { seq, code });154938 | return;155939 ~ }156 |157158error: could not compile `herdr-eternal-server` (lib) due to 6 previous errors