herdr-eternal-clippy-0.1.0
checks.aarch64-linux.clippy
· build #6
· raw
1tribuchet: building on eliza
unpackPhase
2unpacking source archive /nix/store/hm5wp2v5k2i3z650xkxjf7sa2m5h7zqq-source3source root is sourcepatchPhase
4Executing configureCargoCommonVars5decompressing cargo artifacts from /nix/store/p144mrm8r80lbby3rlilrlnrjbas8lwl-herdr-eternal-deps-0.1.0/target.tar.zst to targetconfigurePhase
6will append /build/source/.cargo-home/config.toml with contents of /nix/store/18035ywd6gsxfhdy681zgyxbxknbr7kl-vendor-cargo-deps/config.toml7default configurePhase, nothing to dobuildPhase
8+++ command cargo --version9cargo 1.97.0 (c980f4866 2026-06-30)10+++ command cargo clippy --release --locked --all-targets -- -D warnings11 Checking herdr-eternal-proto v0.1.0 (/build/source/proto)12 Checking herdr-eternal-server v0.1.0 (/build/source/server)13 Checking herdr-eternal-ssh v0.1.0 (/build/source/client)14error: this `if` statement can be collapsed15 --> client/src/lib.rs:250:1716 |17250 | / if agent_channel.is_none() {18251 | | if let (Some(socket), Some(token)) = (&target.agent_socket, &resume_token) {19252 | | agent_channel = Some(AbortOnDrop(tokio::spawn(agent::forward_agent(20253 | | target.clone(),21... |22258 | | }23 | |_________________^24 |25 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if26 = note: `-D clippy::collapsible-if` implied by `-D warnings`27 = help: to override `-D warnings` add `#[allow(clippy::collapsible_if)]`28help: collapse nested if block29 |30250 ~ if agent_channel.is_none()31251 ~ && let (Some(socket), Some(token)) = (&target.agent_socket, &resume_token) {32252 | agent_channel = Some(AbortOnDrop(tokio::spawn(agent::forward_agent(33...34256 | ))));35257 ~ }36 |3738error: could not compile `herdr-eternal-ssh` (lib) due to 1 previous error39warning: build failed, waiting for other jobs to finish...40error: this `if` statement can be collapsed41 --> server/src/auth.rs:69:942 |4369 | / if let Some(static_token) = &self.static_token {4470 | | if constant_time_eq(static_token.as_bytes(), presented.as_bytes()) {4571 | | return Ok(());4672 | | }4773 | | }48 | |_________^49 |50 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if51 = note: `-D clippy::collapsible-if` implied by `-D warnings`52 = help: to override `-D warnings` add `#[allow(clippy::collapsible_if)]`53help: collapse nested if block54 |5569 ~ if let Some(static_token) = &self.static_token5670 ~ && constant_time_eq(static_token.as_bytes(), presented.as_bytes()) {5771 | return Ok(());5872 ~ }59 |6061error: this `if` statement can be collapsed62 --> server/src/auth.rs:157:963 |64157 | / if let Some(client_id) = &claims.client_id {65158 | | if client_id != &self.config.client_id {66159 | | return Err(AuthError::WrongClient(client_id.clone()));67160 | | }68161 | | }69 | |_________^70 |71 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if72help: collapse nested if block73 |74157 ~ if let Some(client_id) = &claims.client_id75158 ~ && client_id != &self.config.client_id {76159 | return Err(AuthError::WrongClient(client_id.clone()));77160 ~ }78 |7980error: this `if` statement can be collapsed81 --> server/src/lib.rs:854:1782 |83854 | / if exit_code.is_some() {84855 | | if let Some(child) = child.as_mut() {85856 | | child.wait().await.ok();86857 | | }87858 | | }88 | |_________________^89 |90 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if91help: collapse nested if block92 |93854 ~ if exit_code.is_some()94855 ~ && let Some(child) = child.as_mut() {95856 | child.wait().await.ok();96857 ~ }97 |9899error: this `if` statement can be collapsed100 --> server/src/lib.rs:865:29101 |102865 | / ... if let Some(pipe) = stdin.as_mut() {103866 | | ... if pipe.write_all(&data).await.is_err() || pipe.flush().await.is_err() {104867 | | ... stdin = None;105868 | | ... }106869 | | ... }107 | |_______________________^108 |109 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if110help: collapse nested if block111 |112865 ~ if let Some(pipe) = stdin.as_mut()113866 ~ && (pipe.write_all(&data).await.is_err() || pipe.flush().await.is_err()) {114867 | stdin = None;115868 ~ }116 |117118error: this `if` statement can be collapsed119 --> server/src/lib.rs:888:25120 |121888 | / if let Some(pipe) = stdin.take() {122889 | | if let Ok(fd) = pipe.into_nonblocking_fd() {123890 | | fds.push(("stdin", fd));124891 | | }125892 | | }126 | |_________________________^127 |128 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if129help: collapse nested if block130 |131888 ~ if let Some(pipe) = stdin.take()132889 ~ && let Ok(fd) = pipe.into_nonblocking_fd() {133890 | fds.push(("stdin", fd));134891 ~ }135 |136137error: this `if` statement can be collapsed138 --> server/src/lib.rs:934:9139 |140934 | / if let Some(code) = exit_code {141935 | | if !stdout_open && !stderr_open {142936 | | seq += 1;143937 | | log.push(proto::ChannelMessage::Exit { seq, code });144... |145940 | | }146 | |_________^147 |148 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if149help: collapse nested if block150 |151934 ~ if let Some(code) = exit_code152935 ~ && !stdout_open && !stderr_open {153936 | seq += 1;154937 | log.push(proto::ChannelMessage::Exit { seq, code });155938 | return;156939 ~ }157 |158159error: could not compile `herdr-eternal-server` (lib) due to 6 previous errors