herdr-eternal-clippy-0.1.0
checks.aarch64-darwin.clippy
· build #8
· raw
1tribuchet: building on mac02
unpackPhase
2unpacking source archive /nix/store/2fsy4dsayp8khhhdxl0k6g4s5fqjmyx2-source3source root is sourcepatchPhase
4Executing configureCargoCommonVars5decompressing cargo artifacts from /nix/store/ir4yxqxli2zsds8vrkbbv5088wr12xlj-herdr-eternal-deps-0.1.0/target.tar.zst to target6patchPhase completed in 36 secondsconfigurePhase
7will append /private/var/tb/7/scratch/f263a0e1ff1b0f40/build/source/.cargo-home/config.toml with contents of /nix/store/cp7iinbb7hkmyng9f7mq9gfwwrklivq2-vendor-cargo-deps/config.toml8default configurePhase, nothing to dobuildPhase
9+++ command cargo --version10cargo 1.99.0 (5f94df478 2026-08-27)11+++ command cargo clippy --release --locked --all-targets -- -D warnings12 Checking herdr-eternal-proto v0.1.0 (/private/var/tb/7/scratch/f263a0e1ff1b0f40/build/source/proto)13 Checking herdr-eternal-server v0.1.0 (/private/var/tb/7/scratch/f263a0e1ff1b0f40/build/source/server)14 Checking herdr-eternal-ssh v0.1.0 (/private/var/tb/7/scratch/f263a0e1ff1b0f40/build/source/client)15error: this `if` statement can be collapsed16 --> client/src/lib.rs:250:1717 |18250 | / if agent_channel.is_none() {19251 | | if let (Some(socket), Some(token)) = (&target.agent_socket, &resume_token) {20252 | | agent_channel = Some(AbortOnDrop(tokio::spawn(agent::forward_agent(21253 | | target.clone(),22... |23258 | | }24 | |_________________^25 |26 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if27 = note: `-D clippy::collapsible-if` implied by `-D warnings`28 = help: to override `-D warnings` add `#[allow(clippy::collapsible_if)]`29help: collapse nested if block30 |31250 ~ if agent_channel.is_none()32251 ~ && let (Some(socket), Some(token)) = (&target.agent_socket, &resume_token) {33252 | agent_channel = Some(AbortOnDrop(tokio::spawn(agent::forward_agent(34...35256 | ))));36257 ~ }37 |3839error: could not compile `herdr-eternal-ssh` (lib) due to 1 previous error40warning: build failed, waiting for other jobs to finish...41error: this `if` statement can be collapsed42 --> server/src/auth.rs:69:943 |4469 | / if let Some(static_token) = &self.static_token {4570 | | if constant_time_eq(static_token.as_bytes(), presented.as_bytes()) {4671 | | return Ok(());4772 | | }4873 | | }49 | |_________^50 |51 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if52 = note: `-D clippy::collapsible-if` implied by `-D warnings`53 = help: to override `-D warnings` add `#[allow(clippy::collapsible_if)]`54help: collapse nested if block55 |5669 ~ if let Some(static_token) = &self.static_token5770 ~ && constant_time_eq(static_token.as_bytes(), presented.as_bytes()) {5871 | return Ok(());5972 ~ }60 |6162error: this `if` statement can be collapsed63 --> server/src/auth.rs:157:964 |65157 | / if let Some(client_id) = &claims.client_id {66158 | | if client_id != &self.config.client_id {67159 | | return Err(AuthError::WrongClient(client_id.clone()));68160 | | }69161 | | }70 | |_________^71 |72 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if73help: collapse nested if block74 |75157 ~ if let Some(client_id) = &claims.client_id76158 ~ && client_id != &self.config.client_id {77159 | return Err(AuthError::WrongClient(client_id.clone()));78160 ~ }79 |8081error: this `if` statement can be collapsed82 --> server/src/lib.rs:854:1783 |84854 | / if exit_code.is_some() {85855 | | if let Some(child) = child.as_mut() {86856 | | child.wait().await.ok();87857 | | }88858 | | }89 | |_________________^90 |91 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if92help: collapse nested if block93 |94854 ~ if exit_code.is_some()95855 ~ && let Some(child) = child.as_mut() {96856 | child.wait().await.ok();97857 ~ }98 |99100error: this `if` statement can be collapsed101 --> server/src/lib.rs:865:29102 |103865 | / ... if let Some(pipe) = stdin.as_mut() {104866 | | ... if pipe.write_all(&data).await.is_err() || pipe.flush().await.is_err() {105867 | | ... stdin = None;106868 | | ... }107869 | | ... }108 | |_______________________^109 |110 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if111help: collapse nested if block112 |113865 ~ if let Some(pipe) = stdin.as_mut()114866 ~ && (pipe.write_all(&data).await.is_err() || pipe.flush().await.is_err()) {115867 | stdin = None;116868 ~ }117 |118119error: this `if` statement can be collapsed120 --> server/src/lib.rs:888:25121 |122888 | / if let Some(pipe) = stdin.take() {123889 | | if let Ok(fd) = pipe.into_nonblocking_fd() {124890 | | fds.push(("stdin", fd));125891 | | }126892 | | }127 | |_________________________^128 |129 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if130help: collapse nested if block131 |132888 ~ if let Some(pipe) = stdin.take()133889 ~ && let Ok(fd) = pipe.into_nonblocking_fd() {134890 | fds.push(("stdin", fd));135891 ~ }136 |137138error: this `if` statement can be collapsed139 --> server/src/lib.rs:934:9140 |141934 | / if let Some(code) = exit_code {142935 | | if !stdout_open && !stderr_open {143936 | | seq += 1;144937 | | log.push(proto::ChannelMessage::Exit { seq, code });145... |146940 | | }147 | |_________^148 |149 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if150help: collapse nested if block151 |152934 ~ if let Some(code) = exit_code153935 ~ && !stdout_open && !stderr_open {154936 | seq += 1;155937 | log.push(proto::ChannelMessage::Exit { seq, code });156938 | return;157939 ~ }158 |159160error: could not compile `herdr-eternal-server` (lib) due to 6 previous errors