herdr-eternal-clippy-0.1.0
checks.x86_64-linux.clippy
· build #9
· raw
unpackPhase
1unpacking source archive /nix/store/2fsy4dsayp8khhhdxl0k6g4s5fqjmyx2-source2source root is sourcepatchPhase
3Executing configureCargoCommonVars4decompressing cargo artifacts from /nix/store/h8pqar04hf8zz3b4ga6iphbrfx8hvdma-herdr-eternal-deps-0.1.0/target.tar.zst to targetconfigurePhase
5will append /build/source/.cargo-home/config.toml with contents of /nix/store/jjpdza1hl297c6fd50grypkh1nbl575j-vendor-cargo-deps/config.toml6default configurePhase, nothing to dobuildPhase
7+++ command cargo --version8cargo 1.97.0 (c980f4866 2026-06-30)9+++ command cargo clippy --release --locked --all-targets -- -D warnings10 Checking herdr-eternal-proto v0.1.0 (/build/source/proto)11 Checking herdr-eternal-server v0.1.0 (/build/source/server)12 Checking herdr-eternal-ssh v0.1.0 (/build/source/client)13error: this `if` statement can be collapsed14 --> server/src/auth.rs:69:915 |1669 | / if let Some(static_token) = &self.static_token {1770 | | if constant_time_eq(static_token.as_bytes(), presented.as_bytes()) {1871 | | return Ok(());1972 | | }2073 | | }21 | |_________^22 |23 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if24 = note: `-D clippy::collapsible-if` implied by `-D warnings`25 = help: to override `-D warnings` add `#[allow(clippy::collapsible_if)]`26help: collapse nested if block27 |2869 ~ if let Some(static_token) = &self.static_token2970 ~ && constant_time_eq(static_token.as_bytes(), presented.as_bytes()) {3071 | return Ok(());3172 ~ }32 |3334error: this `if` statement can be collapsed35 --> server/src/auth.rs:157:936 |37157 | / if let Some(client_id) = &claims.client_id {38158 | | if client_id != &self.config.client_id {39159 | | return Err(AuthError::WrongClient(client_id.clone()));40160 | | }41161 | | }42 | |_________^43 |44 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if45help: collapse nested if block46 |47157 ~ if let Some(client_id) = &claims.client_id48158 ~ && client_id != &self.config.client_id {49159 | return Err(AuthError::WrongClient(client_id.clone()));50160 ~ }51 |5253error: this `if` statement can be collapsed54 --> server/src/lib.rs:854:1755 |56854 | / if exit_code.is_some() {57855 | | if let Some(child) = child.as_mut() {58856 | | child.wait().await.ok();59857 | | }60858 | | }61 | |_________________^62 |63 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if64help: collapse nested if block65 |66854 ~ if exit_code.is_some()67855 ~ && let Some(child) = child.as_mut() {68856 | child.wait().await.ok();69857 ~ }70 |7172error: this `if` statement can be collapsed73 --> server/src/lib.rs:865:2974 |75865 | / ... if let Some(pipe) = stdin.as_mut() {76866 | | ... if pipe.write_all(&data).await.is_err() || pipe.flush().await.is_err() {77867 | | ... stdin = None;78868 | | ... }79869 | | ... }80 | |_______________________^81 |82 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if83help: collapse nested if block84 |85865 ~ if let Some(pipe) = stdin.as_mut()86866 ~ && (pipe.write_all(&data).await.is_err() || pipe.flush().await.is_err()) {87867 | stdin = None;88868 ~ }89 |9091error: this `if` statement can be collapsed92 --> server/src/lib.rs:888:2593 |94888 | / if let Some(pipe) = stdin.take() {95889 | | if let Ok(fd) = pipe.into_nonblocking_fd() {96890 | | fds.push(("stdin", fd));97891 | | }98892 | | }99 | |_________________________^100 |101 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if102help: collapse nested if block103 |104888 ~ if let Some(pipe) = stdin.take()105889 ~ && let Ok(fd) = pipe.into_nonblocking_fd() {106890 | fds.push(("stdin", fd));107891 ~ }108 |109110error: this `if` statement can be collapsed111 --> server/src/lib.rs:934:9112 |113934 | / if let Some(code) = exit_code {114935 | | if !stdout_open && !stderr_open {115936 | | seq += 1;116937 | | log.push(proto::ChannelMessage::Exit { seq, code });117... |118940 | | }119 | |_________^120 |121 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if122help: collapse nested if block123 |124934 ~ if let Some(code) = exit_code125935 ~ && !stdout_open && !stderr_open {126936 | seq += 1;127937 | log.push(proto::ChannelMessage::Exit { seq, code });128938 | return;129939 ~ }130 |131132error: could not compile `herdr-eternal-server` (lib) due to 6 previous errors133warning: build failed, waiting for other jobs to finish...134error: this `if` statement can be collapsed135 --> client/src/lib.rs:250:17136 |137250 | / if agent_channel.is_none() {138251 | | if let (Some(socket), Some(token)) = (&target.agent_socket, &resume_token) {139252 | | agent_channel = Some(AbortOnDrop(tokio::spawn(agent::forward_agent(140253 | | target.clone(),141... |142258 | | }143 | |_________________^144 |145 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if146 = note: `-D clippy::collapsible-if` implied by `-D warnings`147 = help: to override `-D warnings` add `#[allow(clippy::collapsible_if)]`148help: collapse nested if block149 |150250 ~ if agent_channel.is_none()151251 ~ && let (Some(socket), Some(token)) = (&target.agent_socket, &resume_token) {152252 | agent_channel = Some(AbortOnDrop(tokio::spawn(agent::forward_agent(153...154256 | ))));155257 ~ }156 |157158error: could not compile `herdr-eternal-ssh` (lib) due to 1 previous error