this derivation will be built: /nix/store/4fmaf8xkwbmazm7lh4w6yg4952xjw91i-nix-grpc-store-clang-tidy-0.1.0-beta.3.drv building '/nix/store/4fmaf8xkwbmazm7lh4w6yg4952xjw91i-nix-grpc-store-clang-tidy-0.1.0-beta.3.drv' on 'ssh-ng://customer@mac02' building '/nix/store/4fmaf8xkwbmazm7lh4w6yg4952xjw91i-nix-grpc-store-clang-tidy-0.1.0-beta.3.drv' nix-grpc-store-clang-tidy-0.1.0-beta.3> Running phase: unpackPhase nix-grpc-store-clang-tidy-0.1.0-beta.3> unpacking source archive /nix/store/2iw3srf3py4530w1hp78kvln0h6ja33p-source nix-grpc-store-clang-tidy-0.1.0-beta.3> source root is source nix-grpc-store-clang-tidy-0.1.0-beta.3> Running phase: patchPhase nix-grpc-store-clang-tidy-0.1.0-beta.3> Running phase: updateAutotoolsGnuConfigScriptsPhase nix-grpc-store-clang-tidy-0.1.0-beta.3> Running phase: configurePhase nix-grpc-store-clang-tidy-0.1.0-beta.3> mesonConfigurePhase flags: --prefix=/nix/store/21w0qcdb0j3gpn4yrh8k518nz7xmwj2k-nix-grpc-store-clang-tidy-0.1.0-beta.3 --libdir=/nix/store/21w0qcdb0j3gpn4yrh8k518nz7xmwj2k-nix-grpc-store-clang-tidy-0.1.0-beta.3/lib --libexecdir=/nix/store/21w0qcdb0j3gpn4yrh8k518nz7xmwj2k-nix-grpc-store-clang-tidy-0.1.0-beta.3/libexec --bindir=/nix/store/21w0qcdb0j3gpn4yrh8k518nz7xmwj2k-nix-grpc-store-clang-tidy-0.1.0-beta.3/bin --sbindir=/nix/store/21w0qcdb0j3gpn4yrh8k518nz7xmwj2k-nix-grpc-store-clang-tidy-0.1.0-beta.3/sbin --includedir=/nix/store/21w0qcdb0j3gpn4yrh8k518nz7xmwj2k-nix-grpc-store-clang-tidy-0.1.0-beta.3/include --mandir=/nix/store/21w0qcdb0j3gpn4yrh8k518nz7xmwj2k-nix-grpc-store-clang-tidy-0.1.0-beta.3/share/man --infodir=/nix/store/21w0qcdb0j3gpn4yrh8k518nz7xmwj2k-nix-grpc-store-clang-tidy-0.1.0-beta.3/share/info --localedir=/nix/store/21w0qcdb0j3gpn4yrh8k518nz7xmwj2k-nix-grpc-store-clang-tidy-0.1.0-beta.3/share/locale -Dauto_features=enabled -Dwrap_mode=nodownload --buildtype=plain -Db_pch=false nix-grpc-store-clang-tidy-0.1.0-beta.3> The Meson build system nix-grpc-store-clang-tidy-0.1.0-beta.3> Version: 1.10.2 nix-grpc-store-clang-tidy-0.1.0-beta.3> Source dir: /nix/var/nix/builds/nix-12824-4142853305/source nix-grpc-store-clang-tidy-0.1.0-beta.3> Build dir: /nix/var/nix/builds/nix-12824-4142853305/source/build nix-grpc-store-clang-tidy-0.1.0-beta.3> Build type: native build nix-grpc-store-clang-tidy-0.1.0-beta.3> WARNING: Project does not target a minimum version but uses feature introduced in '1.1': meson.options file. Use meson_options.txt instead nix-grpc-store-clang-tidy-0.1.0-beta.3> Project name: nix-grpc-store nix-grpc-store-clang-tidy-0.1.0-beta.3> Project version: 0.1.0-beta.3 nix-grpc-store-clang-tidy-0.1.0-beta.3> C++ compiler for the host machine: clang++ (clang 22.1.8 "clang version 22.1.8") nix-grpc-store-clang-tidy-0.1.0-beta.3> C++ linker for the host machine: clang++ ld64 956.6 nix-grpc-store-clang-tidy-0.1.0-beta.3> Host machine cpu family: aarch64 nix-grpc-store-clang-tidy-0.1.0-beta.3> Host machine cpu: aarch64 nix-grpc-store-clang-tidy-0.1.0-beta.3> Found pkg-config: YES (/nix/store/kd2x1bj3gwfh2hb69fk5ym043h2qavxc-pkg-config-wrapper-0.29.2/bin/pkg-config) 0.29.2 nix-grpc-store-clang-tidy-0.1.0-beta.3> Run-time dependency grpc++ found: YES 1.83.0 nix-grpc-store-clang-tidy-0.1.0-beta.3> Run-time dependency protobuf found: YES 36.1.0 nix-grpc-store-clang-tidy-0.1.0-beta.3> Run-time dependency libzstd found: YES 1.5.7 nix-grpc-store-clang-tidy-0.1.0-beta.3> Run-time dependency threads found: YES nix-grpc-store-clang-tidy-0.1.0-beta.3> Run-time dependency libcrypto found: YES 3.6.4 nix-grpc-store-clang-tidy-0.1.0-beta.3> Run-time dependency prometheus-cpp-core found: YES 1.3.0 nix-grpc-store-clang-tidy-0.1.0-beta.3> Run-time dependency prometheus-cpp-pull found: YES 1.3.0 nix-grpc-store-clang-tidy-0.1.0-beta.3> Run-time dependency absl_flat_hash_map found: YES 20260107 nix-grpc-store-clang-tidy-0.1.0-beta.3> Run-time dependency absl_hash found: YES 20260107 nix-grpc-store-clang-tidy-0.1.0-beta.3> Run-time dependency absl_synchronization found: YES 20260107 nix-grpc-store-clang-tidy-0.1.0-beta.3> Compiler for C++ supports arguments -Werror=thread-safety: YES nix-grpc-store-clang-tidy-0.1.0-beta.3> Run-time dependency jemalloc found: YES 5.3.1_0 nix-grpc-store-clang-tidy-0.1.0-beta.3> Run-time dependency nix-store found: YES 2.36.0pre20260920_5711f8fe nix-grpc-store-clang-tidy-0.1.0-beta.3> Run-time dependency nix-util found: YES 2.36.0pre20260920_5711f8fe nix-grpc-store-clang-tidy-0.1.0-beta.3> Run-time dependency libcurl found: YES 8.22.0 nix-grpc-store-clang-tidy-0.1.0-beta.3> Run-time dependency nlohmann_json found: YES 3.12.0 nix-grpc-store-clang-tidy-0.1.0-beta.3> Check usable header "jwt-cpp/traits/nlohmann-json/defaults.h" : YES nix-grpc-store-clang-tidy-0.1.0-beta.3> Program protoc found: YES (/nix/store/r1npr0vx8d17c0fhh9gvg9mpaiphn62a-protobuf-36.1/bin/protoc) nix-grpc-store-clang-tidy-0.1.0-beta.3> Program grpc_cpp_plugin found: YES (/nix/store/0mm81ldgq4ssz7gnh8589gx9zfcxpdhq-grpc-1.83.0/bin/grpc_cpp_plugin) nix-grpc-store-clang-tidy-0.1.0-beta.3> Run-time dependency dl found: YES nix-grpc-store-clang-tidy-0.1.0-beta.3> Program tests/farm-client-test.sh found: YES (/nix/var/nix/builds/nix-12824-4142853305/source/tests/farm-client-test.sh) nix-grpc-store-clang-tidy-0.1.0-beta.3> Program tests/oidc-test.sh found: YES (/nix/var/nix/builds/nix-12824-4142853305/source/tests/oidc-test.sh) nix-grpc-store-clang-tidy-0.1.0-beta.3> Build targets in project: 12 nix-grpc-store-clang-tidy-0.1.0-beta.3> WARNING: Project specifies no minimum version but uses features which were added in versions: nix-grpc-store-clang-tidy-0.1.0-beta.3> * 1.1: {'meson.options file'} nix-grpc-store-clang-tidy-0.1.0-beta.3> nix-grpc-store-clang-tidy-0.1.0-beta.3> nix-grpc-store 0.1.0-beta.3 nix-grpc-store-clang-tidy-0.1.0-beta.3> nix-grpc-store-clang-tidy-0.1.0-beta.3> User defined options nix-grpc-store-clang-tidy-0.1.0-beta.3> auto_features: enabled nix-grpc-store-clang-tidy-0.1.0-beta.3> b_pch : false nix-grpc-store-clang-tidy-0.1.0-beta.3> bindir : /nix/store/21w0qcdb0j3gpn4yrh8k518nz7xmwj2k-nix-grpc-store-clang-tidy-0.1.0-beta.3/bin nix-grpc-store-clang-tidy-0.1.0-beta.3> buildtype : plain nix-grpc-store-clang-tidy-0.1.0-beta.3> includedir : /nix/store/21w0qcdb0j3gpn4yrh8k518nz7xmwj2k-nix-grpc-store-clang-tidy-0.1.0-beta.3/include nix-grpc-store-clang-tidy-0.1.0-beta.3> infodir : /nix/store/21w0qcdb0j3gpn4yrh8k518nz7xmwj2k-nix-grpc-store-clang-tidy-0.1.0-beta.3/share/info nix-grpc-store-clang-tidy-0.1.0-beta.3> libdir : /nix/store/21w0qcdb0j3gpn4yrh8k518nz7xmwj2k-nix-grpc-store-clang-tidy-0.1.0-beta.3/lib nix-grpc-store-clang-tidy-0.1.0-beta.3> libexecdir : /nix/store/21w0qcdb0j3gpn4yrh8k518nz7xmwj2k-nix-grpc-store-clang-tidy-0.1.0-beta.3/libexec nix-grpc-store-clang-tidy-0.1.0-beta.3> localedir : /nix/store/21w0qcdb0j3gpn4yrh8k518nz7xmwj2k-nix-grpc-store-clang-tidy-0.1.0-beta.3/share/locale nix-grpc-store-clang-tidy-0.1.0-beta.3> mandir : /nix/store/21w0qcdb0j3gpn4yrh8k518nz7xmwj2k-nix-grpc-store-clang-tidy-0.1.0-beta.3/share/man nix-grpc-store-clang-tidy-0.1.0-beta.3> prefix : /nix/store/21w0qcdb0j3gpn4yrh8k518nz7xmwj2k-nix-grpc-store-clang-tidy-0.1.0-beta.3 nix-grpc-store-clang-tidy-0.1.0-beta.3> sbindir : /nix/store/21w0qcdb0j3gpn4yrh8k518nz7xmwj2k-nix-grpc-store-clang-tidy-0.1.0-beta.3/sbin nix-grpc-store-clang-tidy-0.1.0-beta.3> wrap_mode : nodownload nix-grpc-store-clang-tidy-0.1.0-beta.3> nix-grpc-store-clang-tidy-0.1.0-beta.3> Found ninja-1.13.2 at /nix/store/kalf64hrn0zrxlacfvgymwbck77qvsr9-ninja-1.13.2/bin/ninja nix-grpc-store-clang-tidy-0.1.0-beta.3> mesonConfigurePhase: enabled\ parallel\ building nix-grpc-store-clang-tidy-0.1.0-beta.3> Running phase: buildPhase nix-grpc-store-clang-tidy-0.1.0-beta.3> [1/1] Generating nix_remote_proto with a custom command nix-grpc-store-clang-tidy-0.1.0-beta.3> [0/1] /nix/store/j2s018h6gc2q0z3sw002br2zas3m1l9d-meson-1.10.2/bin/meson --internal clangtidy /nix/var/nix/builds/nix-12824-4142853305/source /nix/var/nix/builds/nix-12824-4142853305/source/build --color always nix-grpc-store-clang-tidy-0.1.0-beta.3> >>> /nix/store/l8sbl3yky84xqxj3a5hazrjdx52avnf2-clang-tools-22.1.8/bin/clang-tidy --use-color -quiet -p /nix/var/nix/builds/nix-12824-4142853305/source/build /nix/var/nix/builds/nix-12824-4142853305/source/src/daemon/eds.cc nix-grpc-store-clang-tidy-0.1.0-beta.3> Error while processing /nix/var/nix/builds/nix-12824-4142853305/source/src/daemon/eds.cc. nix-grpc-store-clang-tidy-0.1.0-beta.3> ../src/daemon/eds.cc:13:1: error: included header set is not used directly [misc-include-cleaner,-warnings-as-errors] nix-grpc-store-clang-tidy-0.1.0-beta.3> 13 | #include nix-grpc-store-clang-tidy-0.1.0-beta.3> | ^~~~~~~~~~~~~~ nix-grpc-store-clang-tidy-0.1.0-beta.3> 14 | #include nix-grpc-store-clang-tidy-0.1.0-beta.3> ../src/daemon/eds.cc:17:1: error: included header vector is not used directly [misc-include-cleaner,-warnings-as-errors] nix-grpc-store-clang-tidy-0.1.0-beta.3> 17 | #include nix-grpc-store-clang-tidy-0.1.0-beta.3> | ^~~~~~~~~~~~~~~~~ nix-grpc-store-clang-tidy-0.1.0-beta.3> 18 | nix-grpc-store-clang-tidy-0.1.0-beta.3> ../src/daemon/eds.cc:24:1: error: included header server_callback.h is not used directly [misc-include-cleaner,-warnings-as-errors] nix-grpc-store-clang-tidy-0.1.0-beta.3> 24 | #include nix-grpc-store-clang-tidy-0.1.0-beta.3> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ nix-grpc-store-clang-tidy-0.1.0-beta.3> 25 | #include nix-grpc-store-clang-tidy-0.1.0-beta.3> ../src/daemon/eds.cc:32:1: error: included header sched-reactor.hh is not used directly [misc-include-cleaner,-warnings-as-errors] nix-grpc-store-clang-tidy-0.1.0-beta.3> 32 | #include "sched-reactor.hh" nix-grpc-store-clang-tidy-0.1.0-beta.3> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ nix-grpc-store-clang-tidy-0.1.0-beta.3> 33 | nix-grpc-store-clang-tidy-0.1.0-beta.3> ../src/daemon/eds.cc:129:16: error: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr,-warnings-as-errors] nix-grpc-store-clang-tidy-0.1.0-beta.3> 128 | if (std::cmp_greater(req.resource_names_size(), maxNames)) { nix-grpc-store-clang-tidy-0.1.0-beta.3> | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ nix-grpc-store-clang-tidy-0.1.0-beta.3> | return !static_cast(std::cmp_greater(req.resource_names_size(), maxNames)) nix-grpc-store-clang-tidy-0.1.0-beta.3> 129 | return false; nix-grpc-store-clang-tidy-0.1.0-beta.3> | ~~~~~~~^~~~~~ nix-grpc-store-clang-tidy-0.1.0-beta.3> 130 | } nix-grpc-store-clang-tidy-0.1.0-beta.3> | ~ nix-grpc-store-clang-tidy-0.1.0-beta.3> 131 | for (const auto & name : req.resource_names()) { nix-grpc-store-clang-tidy-0.1.0-beta.3> | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ nix-grpc-store-clang-tidy-0.1.0-beta.3> 132 | if (name.empty() || name.size() > maxNameLen) { nix-grpc-store-clang-tidy-0.1.0-beta.3> | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ nix-grpc-store-clang-tidy-0.1.0-beta.3> 133 | return false; nix-grpc-store-clang-tidy-0.1.0-beta.3> | ~~~~~~~~~~~~~ nix-grpc-store-clang-tidy-0.1.0-beta.3> 134 | } nix-grpc-store-clang-tidy-0.1.0-beta.3> | ~ nix-grpc-store-clang-tidy-0.1.0-beta.3> 135 | names.insert(name); nix-grpc-store-clang-tidy-0.1.0-beta.3> | ~~~~~~~~~~~~~~~~~~~ nix-grpc-store-clang-tidy-0.1.0-beta.3> 136 | } nix-grpc-store-clang-tidy-0.1.0-beta.3> | ~ nix-grpc-store-clang-tidy-0.1.0-beta.3> 137 | return true; nix-grpc-store-clang-tidy-0.1.0-beta.3> | ~~~~~~~~~~~ nix-grpc-store-clang-tidy-0.1.0-beta.3> ../src/daemon/eds.cc:156:5: error: constructor does not initialize these fields: in, out, names [cppcoreguidelines-pro-type-member-init,-warnings-as-errors] nix-grpc-store-clang-tidy-0.1.0-beta.3> 156 | EdsReactor(grpc::CallbackServerContext * ctx, Dispatcher & disp, EdsService & svc) nix-grpc-store-clang-tidy-0.1.0-beta.3> | ^ nix-grpc-store-clang-tidy-0.1.0-beta.3> ../src/daemon/eds.cc:166:9: error: 'watch' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer,-warnings-as-errors] nix-grpc-store-clang-tidy-0.1.0-beta.3> 159 | , svc(svc) nix-grpc-store-clang-tidy-0.1.0-beta.3> | nix-grpc-store-clang-tidy-0.1.0-beta.3> 160 | , stream(std::make_shared()) nix-grpc-store-clang-tidy-0.1.0-beta.3> 161 | { nix-grpc-store-clang-tidy-0.1.0-beta.3> 162 | { nix-grpc-store-clang-tidy-0.1.0-beta.3> 163 | const absl::MutexLock lock(stream->mutex); nix-grpc-store-clang-tidy-0.1.0-beta.3> 164 | stream->reactor = this; nix-grpc-store-clang-tidy-0.1.0-beta.3> 165 | } nix-grpc-store-clang-tidy-0.1.0-beta.3> 166 | watch = disp.watchMembership([stream = stream] -> void { nix-grpc-store-clang-tidy-0.1.0-beta.3> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ nix-grpc-store-clang-tidy-0.1.0-beta.3> 167 | EdsReactor * run = nullptr; nix-grpc-store-clang-tidy-0.1.0-beta.3> | ~~~~~~~~~~~~~~~~~~~~~~~~~~~ nix-grpc-store-clang-tidy-0.1.0-beta.3> 168 | { nix-grpc-store-clang-tidy-0.1.0-beta.3> | ~ nix-grpc-store-clang-tidy-0.1.0-beta.3> 169 | const absl::MutexLock lock(stream->mutex); nix-grpc-store-clang-tidy-0.1.0-beta.3> | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ nix-grpc-store-clang-tidy-0.1.0-beta.3> 170 | if (stream->reactor != nullptr && stream->reactor->beginWake()) { nix-grpc-store-clang-tidy-0.1.0-beta.3> | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ nix-grpc-store-clang-tidy-0.1.0-beta.3> 171 | run = stream->reactor; nix-grpc-store-clang-tidy-0.1.0-beta.3> | ~~~~~~~~~~~~~~~~~~~~~~ nix-grpc-store-clang-tidy-0.1.0-beta.3> 172 | } nix-grpc-store-clang-tidy-0.1.0-beta.3> | ~ nix-grpc-store-clang-tidy-0.1.0-beta.3> 173 | } nix-grpc-store-clang-tidy-0.1.0-beta.3> | ~ nix-grpc-store-clang-tidy-0.1.0-beta.3> 174 | if (run != nullptr) { nix-grpc-store-clang-tidy-0.1.0-beta.3> | ~~~~~~~~~~~~~~~~~~~~~ nix-grpc-store-clang-tidy-0.1.0-beta.3> ../src/daemon/eds.cc:293:13: error: variable 'failure' of type 'std::string_view' (aka 'basic_string_view') can be declared 'const' [misc-const-correctness,-warnings-as-errors] nix-grpc-store-clang-tidy-0.1.0-beta.3> 293 | std::string_view failure; nix-grpc-store-clang-tidy-0.1.0-beta.3> | ^ nix-grpc-store-clang-tidy-0.1.0-beta.3> | const nix-grpc-store-clang-tidy-0.1.0-beta.3> ../src/daemon/eds.cc:326:30: error: the parameter 'fin' of type 'grpc::Status' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors] nix-grpc-store-clang-tidy-0.1.0-beta.3> 326 | void finish(grpc::Status fin) nix-grpc-store-clang-tidy-0.1.0-beta.3> | ^ nix-grpc-store-clang-tidy-0.1.0-beta.3> | const & nix-grpc-store-clang-tidy-0.1.0-beta.3> ../src/daemon/eds.cc:354:18: error: member 'disp' of type 'Dispatcher &' is a reference [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors] nix-grpc-store-clang-tidy-0.1.0-beta.3> 354 | Dispatcher & disp; nix-grpc-store-clang-tidy-0.1.0-beta.3> | ^ nix-grpc-store-clang-tidy-0.1.0-beta.3> ../src/daemon/eds.cc:355:18: error: member 'svc' of type 'EdsService &' is a reference [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors] nix-grpc-store-clang-tidy-0.1.0-beta.3> 355 | EdsService & svc; nix-grpc-store-clang-tidy-0.1.0-beta.3> | ^ nix-grpc-store-clang-tidy-0.1.0-beta.3> ../src/daemon/eds.cc:370:1: error: constructor does not initialize these fields: rendered [cppcoreguidelines-pro-type-member-init,-warnings-as-errors] nix-grpc-store-clang-tidy-0.1.0-beta.3> 370 | EdsService::EdsService(Dispatcher & dispatcher, Auth & auth) nix-grpc-store-clang-tidy-0.1.0-beta.3> | ^ nix-grpc-store-clang-tidy-0.1.0-beta.3> /nix/var/nix/builds/nix-12824-4142853305/source/build/../src/daemon/eds.hh:17:10: error: 'eds.grpc.pb.h' file not found [clang-diagnostic-error] nix-grpc-store-clang-tidy-0.1.0-beta.3> 17 | #include "eds.grpc.pb.h" nix-grpc-store-clang-tidy-0.1.0-beta.3> | ^~~~~~~~~~~~~~~ nix-grpc-store-clang-tidy-0.1.0-beta.3> ../src/daemon/sched-reactor.hh:28:8: error: constructor does not initialize these fields: queue [cppcoreguidelines-pro-type-member-init,-warnings-as-errors] nix-grpc-store-clang-tidy-0.1.0-beta.3> 28 | struct SendQueue nix-grpc-store-clang-tidy-0.1.0-beta.3> | ^ nix-grpc-store-clang-tidy-0.1.0-beta.3> 29 | { nix-grpc-store-clang-tidy-0.1.0-beta.3> 30 | // About a minute of Expects at full rate. Beyond it the peer is stuck. nix-grpc-store-clang-tidy-0.1.0-beta.3> 31 | static constexpr size_t limit = 1U << 16U; nix-grpc-store-clang-tidy-0.1.0-beta.3> 32 | // Messages per Write. nix-grpc-store-clang-tidy-0.1.0-beta.3> 33 | static constexpr int maxBatch = 1024; nix-grpc-store-clang-tidy-0.1.0-beta.3> 34 | nix-grpc-store-clang-tidy-0.1.0-beta.3> 35 | // Leaf lock, may be taken inside Dispatcher::mutex. nix-grpc-store-clang-tidy-0.1.0-beta.3> 36 | absl::Mutex mutex; nix-grpc-store-clang-tidy-0.1.0-beta.3> 37 | std::deque queue ABSL_GUARDED_BY(mutex); nix-grpc-store-clang-tidy-0.1.0-beta.3> | {} nix-grpc-store-clang-tidy-0.1.0-beta.3> ../src/daemon/sched-reactor.hh:169:30: error: the parameter 'fin' of type 'grpc::Status' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors] nix-grpc-store-clang-tidy-0.1.0-beta.3> 169 | void finish(grpc::Status fin) nix-grpc-store-clang-tidy-0.1.0-beta.3> | ^ nix-grpc-store-clang-tidy-0.1.0-beta.3> | const & nix-grpc-store-clang-tidy-0.1.0-beta.3> ../src/daemon/sched-reactor.hh:226:18: error: member 'disp' of type 'Dispatcher &' is a reference [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors] nix-grpc-store-clang-tidy-0.1.0-beta.3> 226 | Dispatcher & disp; nix-grpc-store-clang-tidy-0.1.0-beta.3> | ^ nix-grpc-store-clang-tidy-0.1.0-beta.3> ../src/daemon/sched-reactor.hh:255:18: error: member 'disp' of type 'Dispatcher &' is a reference [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors] nix-grpc-store-clang-tidy-0.1.0-beta.3> 255 | Dispatcher & disp; nix-grpc-store-clang-tidy-0.1.0-beta.3> | ^ nix-grpc-store-clang-tidy-0.1.0-beta.3> >>> /nix/store/l8sbl3yky84xqxj3a5hazrjdx52avnf2-clang-tools-22.1.8/bin/clang-tidy --use-color -quiet -p /nix/var/nix/builds/nix-12824-4142853305/source/build /nix/var/nix/builds/nix-12824-4142853305/source/src/daemon/coordinator.cc nix-grpc-store-clang-tidy-0.1.0-beta.3> Error while processing /nix/var/nix/builds/nix-12824-4142853305/source/src/daemon/coordinator.cc. nix-grpc-store-clang-tidy-0.1.0-beta.3> ../src/client/channel.hh:46:3: error: constructor does not initialize these fields: headers [cppcoreguidelines-pro-type-member-init,-warnings-as-errors] nix-grpc-store-clang-tidy-0.1.0-beta.3> 46 | explicit StaticHeaders(std::shared_ptr headers) : headers(std::move(headers)) {} nix-grpc-store-clang-tidy-0.1.0-beta.3> | ^ nix-grpc-store-clang-tidy-0.1.0-beta.3> ../src/client/channel.hh:62:5: error: constructor does not initialize these fields: headers [cppcoreguidelines-pro-type-member-init,-warnings-as-errors] nix-grpc-store-clang-tidy-0.1.0-beta.3> 62 | explicit Factory(Headers hdrs) : headers(std::make_shared(std::move(hdrs))) {} nix-grpc-store-clang-tidy-0.1.0-beta.3> | ^ nix-grpc-store-clang-tidy-0.1.0-beta.3> 63 | auto CreateClientInterceptor(grpc::experimental::ClientRpcInfo * /*info*/) nix-grpc-store-clang-tidy-0.1.0-beta.3> 64 | -> grpc::experimental::Interceptor * override { nix-grpc-store-clang-tidy-0.1.0-beta.3> 65 | return new StaticHeaders(headers); // NOLINT(cppcoreguidelines-owning-memory): gRPC deletes it nix-grpc-store-clang-tidy-0.1.0-beta.3> 66 | } nix-grpc-store-clang-tidy-0.1.0-beta.3> 67 | private: nix-grpc-store-clang-tidy-0.1.0-beta.3> 68 | std::shared_ptr headers; nix-grpc-store-clang-tidy-0.1.0-beta.3> | nix-grpc-store-clang-tidy-0.1.0-beta.3> | {} nix-grpc-store-clang-tidy-0.1.0-beta.3> ../src/client/channel.hh:87:64: error: pointer parameter 'metadata' can be pointer to const [readability-non-const-parameter,-warnings-as-errors] nix-grpc-store-clang-tidy-0.1.0-beta.3> 87 | std::multimap * metadata) -> grpc::Status override { nix-grpc-store-clang-tidy-0.1.0-beta.3> | ^ nix-grpc-store-clang-tidy-0.1.0-beta.3> | const nix-grpc-store-clang-tidy-0.1.0-beta.3> ../src/daemon/backend.hh:79:25: error: the parameter 'event' of type 'BuildEvent' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors] nix-grpc-store-clang-tidy-0.1.0-beta.3> 79 | auto toChunk(BuildEvent event) -> Chunk nix-grpc-store-clang-tidy-0.1.0-beta.3> | ^ nix-grpc-store-clang-tidy-0.1.0-beta.3> | const & nix-grpc-store-clang-tidy-0.1.0-beta.3> ../src/daemon/coordinator.cc:8:1: error: included header functional is not used directly [misc-include-cleaner,-warnings-as-errors] nix-grpc-store-clang-tidy-0.1.0-beta.3> 8 | #include nix-grpc-store-clang-tidy-0.1.0-beta.3> | ^~~~~~~~~~~~~~~~~~~~~ nix-grpc-store-clang-tidy-0.1.0-beta.3> 9 | #include nix-grpc-store-clang-tidy-0.1.0-beta.3> ../src/daemon/coordinator.cc:9:1: error: included header initializer_list is not used directly [misc-include-cleaner,-warnings-as-errors] nix-grpc-store-clang-tidy-0.1.0-beta.3> 9 | #include nix-grpc-store-clang-tidy-0.1.0-beta.3> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ nix-grpc-store-clang-tidy-0.1.0-beta.3> 10 | #include nix-grpc-store-clang-tidy-0.1.0-beta.3> ../src/daemon/coordinator.cc:17:1: error: included header unordered_set is not used directly [misc-include-cleaner,-warnings-as-errors] nix-grpc-store-clang-tidy-0.1.0-beta.3> 17 | #include nix-grpc-store-clang-tidy-0.1.0-beta.3> | ^~~~~~~~~~~~~~~~~~~~~~~~ nix-grpc-store-clang-tidy-0.1.0-beta.3> 18 | #include nix-grpc-store-clang-tidy-0.1.0-beta.3> ../src/daemon/coordinator.cc:19:1: error: included header vector is not used directly [misc-include-cleaner,-warnings-as-errors] nix-grpc-store-clang-tidy-0.1.0-beta.3> 19 | #include nix-grpc-store-clang-tidy-0.1.0-beta.3> | ^~~~~~~~~~~~~~~~~ nix-grpc-store-clang-tidy-0.1.0-beta.3> 20 | nix-grpc-store-clang-tidy-0.1.0-beta.3> ../src/daemon/coordinator.cc:35:1: error: included header sync_stream.h is not used directly [misc-include-cleaner,-warnings-as-errors] nix-grpc-store-clang-tidy-0.1.0-beta.3> 35 | #include nix-grpc-store-clang-tidy-0.1.0-beta.3> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ nix-grpc-store-clang-tidy-0.1.0-beta.3> 36 | nix-grpc-store-clang-tidy-0.1.0-beta.3> ../src/daemon/coordinator.cc:47:1: error: included header nix_remote.grpc.pb.h is not used directly [misc-include-cleaner,-warnings-as-errors] nix-grpc-store-clang-tidy-0.1.0-beta.3> 47 | #include "nix_remote.grpc.pb.h" nix-grpc-store-clang-tidy-0.1.0-beta.3> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ nix-grpc-store-clang-tidy-0.1.0-beta.3> 48 | #include "nix_remote.pb.h" nix-grpc-store-clang-tidy-0.1.0-beta.3> ../src/daemon/coordinator.cc:70:1: error: constructor does not initialize these fields: state, sendFn [cppcoreguidelines-pro-type-member-init,-warnings-as-errors] nix-grpc-store-clang-tidy-0.1.0-beta.3> 70 | Builder::Builder(const Options & options, Metrics & metrics) nix-grpc-store-clang-tidy-0.1.0-beta.3> | ^ nix-grpc-store-clang-tidy-0.1.0-beta.3> ../src/daemon/coordinator.cc:91:15: error: method 'onRevoke' can be made static [readability-convert-member-functions-to-static,-warnings-as-errors] nix-grpc-store-clang-tidy-0.1.0-beta.3> 91 | void Builder::onRevoke(const nix::remote::Revoke & rev) nix-grpc-store-clang-tidy-0.1.0-beta.3> | ^ nix-grpc-store-clang-tidy-0.1.0-beta.3> ../src/daemon/coordinator.cc:112:15: error: method 'admit' can be made static [readability-convert-member-functions-to-static,-warnings-as-errors] nix-grpc-store-clang-tidy-0.1.0-beta.3> 112 | auto Builder::admit(const std::string & drvPath) -> std::optional nix-grpc-store-clang-tidy-0.1.0-beta.3> | ^ nix-grpc-store-clang-tidy-0.1.0-beta.3> ../src/daemon/coordinator.cc:125:15: error: method 'finished' can be made static [readability-convert-member-functions-to-static,-warnings-as-errors] nix-grpc-store-clang-tidy-0.1.0-beta.3> 125 | void Builder::finished( nix-grpc-store-clang-tidy-0.1.0-beta.3> | ^ nix-grpc-store-clang-tidy-0.1.0-beta.3> | static nix-grpc-store-clang-tidy-0.1.0-beta.3> ../src/daemon/coordinator.cc:129:17: error: the parameter 'resultWire' of type 'std::string' (aka 'basic_string') is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors] nix-grpc-store-clang-tidy-0.1.0-beta.3> 129 | std::string resultWire) nix-grpc-store-clang-tidy-0.1.0-beta.3> | ^ nix-grpc-store-clang-tidy-0.1.0-beta.3> | const & nix-grpc-store-clang-tidy-0.1.0-beta.3> ../src/daemon/coordinator.cc:210:15: error: method 'send' can be made static [readability-convert-member-functions-to-static,-warnings-as-errors] nix-grpc-store-clang-tidy-0.1.0-beta.3> 210 | auto Builder::send(const WorkerMsg & msg) const -> bool nix-grpc-store-clang-tidy-0.1.0-beta.3> | ^ ~~~~~ nix-grpc-store-clang-tidy-0.1.0-beta.3> ../src/daemon/coordinator.cc:216:15: error: method 'tick' can be made static [readability-convert-member-functions-to-static,-warnings-as-errors] nix-grpc-store-clang-tidy-0.1.0-beta.3> 216 | void Builder::tick() nix-grpc-store-clang-tidy-0.1.0-beta.3> | ^ nix-grpc-store-clang-tidy-0.1.0-beta.3> ../src/daemon/coordinator.cc:296:24: error: no header providing "nix::Error" is directly included [misc-include-cleaner,-warnings-as-errors] nix-grpc-store-clang-tidy-0.1.0-beta.3> 12 | throw nix::Error("loading CA certificates: %s", status.ToString()); nix-grpc-store-clang-tidy-0.1.0-beta.3> | ^ nix-grpc-store-clang-tidy-0.1.0-beta.3> ../src/daemon/coordinator.cc:322:5: error: if with identical then and else branches [bugprone-branch-clone,-warnings-as-errors] nix-grpc-store-clang-tidy-0.1.0-beta.3> 322 | if (active) { nix-grpc-store-clang-tidy-0.1.0-beta.3> | ^ nix-grpc-store-clang-tidy-0.1.0-beta.3> ../src/daemon/coordinator.cc:324:7: note: else branch starts here nix-grpc-store-clang-tidy-0.1.0-beta.3> 324 | } else { nix-grpc-store-clang-tidy-0.1.0-beta.3> | ^ nix-grpc-store-clang-tidy-0.1.0-beta.3> ../src/daemon/coordinator.cc:341:1: error: constructor does not initialize these fields: scheduler, eds [cppcoreguidelines-pro-type-member-init,-warnings-as-errors] nix-grpc-store-clang-tidy-0.1.0-beta.3> 341 | Coordinator::Coordinator(const Options & options, Auth & auth, Metrics & metrics) nix-grpc-store-clang-tidy-0.1.0-beta.3> | ^ nix-grpc-store-clang-tidy-0.1.0-beta.3> ../src/daemon/coordinator.cc:350:9: error: variable 'present' of type 'Dispatcher::PresentFn' (aka 'std::function> (const std::vector> &)>') can be declared 'const' [misc-const-correctness,-warnings-as-errors] nix-grpc-store-clang-tidy-0.1.0-beta.3> 350 | Dispatcher::PresentFn present; nix-grpc-store-clang-tidy-0.1.0-beta.3> | ^ nix-grpc-store-clang-tidy-0.1.0-beta.3> | const nix-grpc-store-clang-tidy-0.1.0-beta.3> ../src/daemon/coordinator.cc:409:20: error: variable 'elect' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors] nix-grpc-store-clang-tidy-0.1.0-beta.3> 409 | const bool elect = options.niks3.enabled() && (!builder || !options.schedulerAddr.empty()); nix-grpc-store-clang-tidy-0.1.0-beta.3> | ^ nix-grpc-store-clang-tidy-0.1.0-beta.3> | = false nix-grpc-store-clang-tidy-0.1.0-beta.3> ../src/daemon/coordinator.cc:458:9: error: variable 'restarting' of type 'bool' can be declared 'const' [misc-const-correctness,-warnings-as-errors] nix-grpc-store-clang-tidy-0.1.0-beta.3> 458 | bool restarting = false; nix-grpc-store-clang-tidy-0.1.0-beta.3> | ^ nix-grpc-store-clang-tidy-0.1.0-beta.3> | const nix-grpc-store-clang-tidy-0.1.0-beta.3> /nix/var/nix/builds/nix-12824-4142853305/source/build/../src/daemon/coordinator.hh:112:21: error: member 'options' of type 'const Options &' is a reference [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors] nix-grpc-store-clang-tidy-0.1.0-beta.3> 112 | const Options & options; nix-grpc-store-clang-tidy-0.1.0-beta.3> | ^ nix-grpc-store-clang-tidy-0.1.0-beta.3> /nix/var/nix/builds/nix-12824-4142853305/source/build/../src/daemon/coordinator.hh:113:15: error: member 'metrics' of type 'Metrics &' is a reference [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors] nix-grpc-store-clang-tidy-0.1.0-beta.3> 113 | Metrics & metrics; nix-grpc-store-clang-tidy-0.1.0-beta.3> | ^ nix-grpc-store-clang-tidy-0.1.0-beta.3> /nix/var/nix/builds/nix-12824-4142853305/source/build/../src/daemon/coordinator.hh:115:12: error: constructor does not initialize these fields: expected [cppcoreguidelines-pro-type-member-init,-warnings-as-errors] nix-grpc-store-clang-tidy-0.1.0-beta.3> 115 | struct State nix-grpc-store-clang-tidy-0.1.0-beta.3> | ^ nix-grpc-store-clang-tidy-0.1.0-beta.3> 116 | { nix-grpc-store-clang-tidy-0.1.0-beta.3> 117 | std::unordered_map expected; nix-grpc-store-clang-tidy-0.1.0-beta.3> | nix-grpc-store-clang-tidy-0.1.0-beta.3> | {} nix-grpc-store-clang-tidy-0.1.0-beta.3> ../src/daemon/eds.hh:17:10: error: 'eds.grpc.pb.h' file not found [clang-diagnostic-error] nix-grpc-store-clang-tidy-0.1.0-beta.3> 17 | #include "eds.grpc.pb.h" nix-grpc-store-clang-tidy-0.1.0-beta.3> | ^~~~~~~~~~~~~~~ nix-grpc-store-clang-tidy-0.1.0-beta.3> ../src/daemon/sched-reactor.hh:28:8: error: constructor does not initialize these fields: queue [cppcoreguidelines-pro-type-member-init,-warnings-as-errors] nix-grpc-store-clang-tidy-0.1.0-beta.3> 28 | struct SendQueue nix-grpc-store-clang-tidy-0.1.0-beta.3> | ^ nix-grpc-store-clang-tidy-0.1.0-beta.3> 29 | { nix-grpc-store-clang-tidy-0.1.0-beta.3> 30 | // About a minute of Expects at full rate. Beyond it the peer is stuck. nix-grpc-store-clang-tidy-0.1.0-beta.3> 31 | static constexpr size_t limit = 1U << 16U; nix-grpc-store-clang-tidy-0.1.0-beta.3> 32 | // Messages per Write. nix-grpc-store-clang-tidy-0.1.0-beta.3> 33 | static constexpr int maxBatch = 1024; nix-grpc-store-clang-tidy-0.1.0-beta.3> 34 | nix-grpc-store-clang-tidy-0.1.0-beta.3> 35 | // Leaf lock, may be taken inside Dispatcher::mutex. nix-grpc-store-clang-tidy-0.1.0-beta.3> 36 | absl::Mutex mutex; nix-grpc-store-clang-tidy-0.1.0-beta.3> 37 | std::deque queue ABSL_GUARDED_BY(mutex); nix-grpc-store-clang-tidy-0.1.0-beta.3> | {} nix-grpc-store-clang-tidy-0.1.0-beta.3> ../src/daemon/sched-reactor.hh:169:30: error: the parameter 'fin' of type 'grpc::Status' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors] nix-grpc-store-clang-tidy-0.1.0-beta.3> 169 | void finish(grpc::Status fin) nix-grpc-store-clang-tidy-0.1.0-beta.3> | ^ nix-grpc-store-clang-tidy-0.1.0-beta.3> | const & nix-grpc-store-clang-tidy-0.1.0-beta.3> ../src/daemon/sched-reactor.hh:226:18: error: member 'disp' of type 'Dispatcher &' is a reference [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors] nix-grpc-store-clang-tidy-0.1.0-beta.3> 226 | Dispatcher & disp; nix-grpc-store-clang-tidy-0.1.0-beta.3> | ^ nix-grpc-store-clang-tidy-0.1.0-beta.3> ../src/daemon/sched-reactor.hh:255:18: error: member 'disp' of type 'Dispatcher &' is a reference [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors] nix-grpc-store-clang-tidy-0.1.0-beta.3> 255 | Dispatcher & disp; nix-grpc-store-clang-tidy-0.1.0-beta.3> | ^ nix-grpc-store-clang-tidy-0.1.0-beta.3> >>> /nix/store/l8sbl3yky84xqxj3a5hazrjdx52avnf2-clang-tools-22.1.8/bin/clang-tidy --use-color -quiet -p /nix/var/nix/builds/nix-12824-4142853305/source/build /nix/var/nix/builds/nix-12824-4142853305/source/src/client/channel.cc nix-grpc-store-clang-tidy-0.1.0-beta.3> [1/1] (1/2) Processing file /nix/var/nix/builds/nix-12824-4142853305/source/src/client/channel.cc. nix-grpc-store-clang-tidy-0.1.0-beta.3> [1/1] (2/2) Processing file /nix/var/nix/builds/nix-12824-4142853305/source/src/client/channel.cc. nix-grpc-store-clang-tidy-0.1.0-beta.3> >>> /nix/store/l8sbl3yky84xqxj3a5hazrjdx52avnf2-clang-tools-22.1.8/bin/clang-tidy --use-color -quiet -p /nix/var/nix/builds/nix-12824-4142853305/source/build /nix/var/nix/builds/nix-12824-4142853305/source/src/daemon/main.cc nix-grpc-store-clang-tidy-0.1.0-beta.3> Errors encountered while running clang-tidy nix-grpc-store-clang-tidy-0.1.0-beta.3> Error while processing /nix/var/nix/builds/nix-12824-4142853305/source/src/daemon/main.cc. nix-grpc-store-clang-tidy-0.1.0-beta.3> ../src/daemon/coordinator.hh:112:21: error: member 'options' of type 'const Options &' is a reference [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors] nix-grpc-store-clang-tidy-0.1.0-beta.3> 112 | const Options & options; nix-grpc-store-clang-tidy-0.1.0-beta.3> | ^ nix-grpc-store-clang-tidy-0.1.0-beta.3> ../src/daemon/coordinator.hh:113:15: error: member 'metrics' of type 'Metrics &' is a reference [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors] nix-grpc-store-clang-tidy-0.1.0-beta.3> 113 | Metrics & metrics; nix-grpc-store-clang-tidy-0.1.0-beta.3> | ^ nix-grpc-store-clang-tidy-0.1.0-beta.3> ../src/daemon/coordinator.hh:115:12: error: constructor does not initialize these fields: expected [cppcoreguidelines-pro-type-member-init,-warnings-as-errors] nix-grpc-store-clang-tidy-0.1.0-beta.3> 115 | struct State nix-grpc-store-clang-tidy-0.1.0-beta.3> | ^ nix-grpc-store-clang-tidy-0.1.0-beta.3> 116 | { nix-grpc-store-clang-tidy-0.1.0-beta.3> 117 | std::unordered_map expected; nix-grpc-store-clang-tidy-0.1.0-beta.3> | nix-grpc-store-clang-tidy-0.1.0-beta.3> | {} nix-grpc-store-clang-tidy-0.1.0-beta.3> ../src/daemon/eds.hh:17:10: error: 'eds.grpc.pb.h' file not found [clang-diagnostic-error] nix-grpc-store-clang-tidy-0.1.0-beta.3> 17 | #include "eds.grpc.pb.h" nix-grpc-store-clang-tidy-0.1.0-beta.3> | ^~~~~~~~~~~~~~~ nix-grpc-store-clang-tidy-0.1.0-beta.3> ../src/daemon/main.cc:21:1: error: included header filesystem is not used directly [misc-include-cleaner,-warnings-as-errors] nix-grpc-store-clang-tidy-0.1.0-beta.3> 21 | #include nix-grpc-store-clang-tidy-0.1.0-beta.3> | ^~~~~~~~~~~~~~~~~~~~~ nix-grpc-store-clang-tidy-0.1.0-beta.3> 22 | #include nix-grpc-store-clang-tidy-0.1.0-beta.3> ../src/daemon/main.cc:22:1: error: included header map is not used directly [misc-include-cleaner,-warnings-as-errors] nix-grpc-store-clang-tidy-0.1.0-beta.3> 22 | #include nix-grpc-store-clang-tidy-0.1.0-beta.3> | ^~~~~~~~~~~~~~ nix-grpc-store-clang-tidy-0.1.0-beta.3> 23 | #include nix-grpc-store-clang-tidy-0.1.0-beta.3> ../src/daemon/main.cc:26:1: error: included header ranges is not used directly [misc-include-cleaner,-warnings-as-errors] nix-grpc-store-clang-tidy-0.1.0-beta.3> 26 | #include nix-grpc-store-clang-tidy-0.1.0-beta.3> | ^~~~~~~~~~~~~~~~~ nix-grpc-store-clang-tidy-0.1.0-beta.3> 27 | #include nix-grpc-store-clang-tidy-0.1.0-beta.3> ../src/daemon/main.cc:32:1: error: included header vector is not used directly [misc-include-cleaner,-warnings-as-errors] nix-grpc-store-clang-tidy-0.1.0-beta.3> 32 | #include nix-grpc-store-clang-tidy-0.1.0-beta.3> | ^~~~~~~~~~~~~~~~~ nix-grpc-store-clang-tidy-0.1.0-beta.3> 33 | nix-grpc-store-clang-tidy-0.1.0-beta.3> ../src/daemon/main.cc:77:1: error: included header path-info-wire.hh is not used directly [misc-include-cleaner,-warnings-as-errors] nix-grpc-store-clang-tidy-0.1.0-beta.3> 77 | #include "path-info-wire.hh" nix-grpc-store-clang-tidy-0.1.0-beta.3> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ nix-grpc-store-clang-tidy-0.1.0-beta.3> 78 | #include "metrics.hh" nix-grpc-store-clang-tidy-0.1.0-beta.3> ../src/daemon/main.cc:231:9: error: 3 adjacent parameters of 'NixRemoteService' of similar type ('std::string') are easily swapped by mistake [bugprone-easily-swappable-parameters,-warnings-as-errors] nix-grpc-store-clang-tidy-0.1.0-beta.3> 231 | std::string socketPath, nix-grpc-store-clang-tidy-0.1.0-beta.3> | ^~~~~~~~~~~~~~~~~~~~~~~ nix-grpc-store-clang-tidy-0.1.0-beta.3> 232 | std::string storeUri, nix-grpc-store-clang-tidy-0.1.0-beta.3> | ~~~~~~~~~~~~~~~~~~~~~ nix-grpc-store-clang-tidy-0.1.0-beta.3> 233 | std::string workerName, nix-grpc-store-clang-tidy-0.1.0-beta.3> | ~~~~~~~~~~~~~~~~~~~~~~ nix-grpc-store-clang-tidy-0.1.0-beta.3> ../src/daemon/main.cc:231:21: note: the first parameter in the range is 'socketPath' nix-grpc-store-clang-tidy-0.1.0-beta.3> 231 | std::string socketPath, nix-grpc-store-clang-tidy-0.1.0-beta.3> | ^~~~~~~~~~ nix-grpc-store-clang-tidy-0.1.0-beta.3> ../src/daemon/main.cc:233:21: note: the last parameter in the range is 'workerName' nix-grpc-store-clang-tidy-0.1.0-beta.3> 233 | std::string workerName, nix-grpc-store-clang-tidy-0.1.0-beta.3> | ^~~~~~~~~~ nix-grpc-store-clang-tidy-0.1.0-beta.3> ../src/daemon/main.cc:231:21: error: the parameter 'socketPath' of type 'std::string' (aka 'basic_string') is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors] nix-grpc-store-clang-tidy-0.1.0-beta.3> 231 | std::string socketPath, nix-grpc-store-clang-tidy-0.1.0-beta.3> | ^ nix-grpc-store-clang-tidy-0.1.0-beta.3> | const & nix-grpc-store-clang-tidy-0.1.0-beta.3> ../src/daemon/main.cc:260:15: error: empty catch statements hide issues; to handle exceptions appropriately, consider re-throwing, handling, or avoiding catch altogether [bugprone-empty-catch,-warnings-as-errors] nix-grpc-store-clang-tidy-0.1.0-beta.3> 260 | } catch (nix::Error & err) { nix-grpc-store-clang-tidy-0.1.0-beta.3> | ^ nix-grpc-store-clang-tidy-0.1.0-beta.3> ../src/daemon/main.cc:297:13: error: variable 'paths' of type 'nix::StorePathSet' (aka 'std::set') can be declared 'const' [misc-const-correctness,-warnings-as-errors] nix-grpc-store-clang-tidy-0.1.0-beta.3> 297 | nix::StorePathSet paths; nix-grpc-store-clang-tidy-0.1.0-beta.3> | ^ nix-grpc-store-clang-tidy-0.1.0-beta.3> | const nix-grpc-store-clang-tidy-0.1.0-beta.3> ../src/daemon/main.cc:669:62: error: the parameter 'event' of type 'nixgrpc::BuildEvent' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors] nix-grpc-store-clang-tidy-0.1.0-beta.3> 669 | auto const sendLogLine = [&](nixgrpc::BuildEvent event) -> void { nix-grpc-store-clang-tidy-0.1.0-beta.3> | ^ nix-grpc-store-clang-tidy-0.1.0-beta.3> | const & nix-grpc-store-clang-tidy-0.1.0-beta.3> ../src/path-info-wire.hh:35:5: error: variable 'path' of type 'nix::StorePath' can be declared 'const' [misc-const-correctness,-warnings-as-errors] nix-grpc-store-clang-tidy-0.1.0-beta.3> 35 | nix::StorePath path(entry.path()); nix-grpc-store-clang-tidy-0.1.0-beta.3> | ^ nix-grpc-store-clang-tidy-0.1.0-beta.3> | const nix-grpc-store-clang-tidy-0.1.0-beta.3> ../src/pump.hh:65:27: error: 2 adjacent parameters of 'readCoalesced' of similar type ('int') are easily swapped by mistake [bugprone-easily-swappable-parameters,-warnings-as-errors] nix-grpc-store-clang-tidy-0.1.0-beta.3> 65 | inline auto readCoalesced(int sourceFd, std::span buf) -> ssize_t nix-grpc-store-clang-tidy-0.1.0-beta.3> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ nix-grpc-store-clang-tidy-0.1.0-beta.3> ../src/pump.hh:65:31: note: the first parameter in the range is 'sourceFd' nix-grpc-store-clang-tidy-0.1.0-beta.3> 65 | inline auto readCoalesced(int sourceFd, std::span buf) -> ssize_t nix-grpc-store-clang-tidy-0.1.0-beta.3> | ^~~~~~~~ nix-grpc-store-clang-tidy-0.1.0-beta.3> ../src/pump.hh:65:57: note: the last parameter in the range is 'buf' nix-grpc-store-clang-tidy-0.1.0-beta.3> 65 | inline auto readCoalesced(int sourceFd, std::span buf) -> ssize_t nix-grpc-store-clang-tidy-0.1.0-beta.3> | ^~~ nix-grpc-store-clang-tidy-0.1.0-beta.3> ../src/pump.hh:159:23: error: variable 'count' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors] nix-grpc-store-clang-tidy-0.1.0-beta.3> 159 | ssize_t const count = readCoalesced(sourceFd, input); nix-grpc-store-clang-tidy-0.1.0-beta.3> | ^ nix-grpc-store-clang-tidy-0.1.0-beta.3> | = 0 nix-grpc-store-clang-tidy-0.1.0-beta.3> ../src/pump.hh:276:44: error: the parameter 'initial' of type 'std::string' (aka 'basic_string') is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors] nix-grpc-store-clang-tidy-0.1.0-beta.3> 276 | static auto makeInitialMsg(std::string initial) -> Msg nix-grpc-store-clang-tidy-0.1.0-beta.3> | ^ nix-grpc-store-clang-tidy-0.1.0-beta.3> | const & nix-grpc-store-clang-tidy-0.1.0-beta.3> FAILED: [code=1] meson-internal__clang-tidy nix-grpc-store-clang-tidy-0.1.0-beta.3> /nix/store/j2s018h6gc2q0z3sw002br2zas3m1l9d-meson-1.10.2/bin/meson --internal clangtidy /nix/var/nix/builds/nix-12824-4142853305/source /nix/var/nix/builds/nix-12824-4142853305/source/build --color always nix-grpc-store-clang-tidy-0.1.0-beta.3> ninja: build stopped: subcommand failed. error: build of '/nix/store/4fmaf8xkwbmazm7lh4w6yg4952xjw91i-nix-grpc-store-clang-tidy-0.1.0-beta.3.drv' on 'ssh-ng://customer@mac02' failed: Cannot build '/nix/store/4fmaf8xkwbmazm7lh4w6yg4952xjw91i-nix-grpc-store-clang-tidy-0.1.0-beta.3.drv'. Reason: builder failed with exit code 1. Output paths: /nix/store/21w0qcdb0j3gpn4yrh8k518nz7xmwj2k-nix-grpc-store-clang-tidy-0.1.0-beta.3 Last 25 log lines: > | const & > ../src/path-info-wire.hh:35:5: error: variable 'path' of type 'nix::StorePath' can be declared 'const' [misc-const-correctness,-warnings-as-errors] > 35 | nix::StorePath path(entry.path()); > | ^ > | const > ../src/pump.hh:65:27: error: 2 adjacent parameters of 'readCoalesced' of similar type ('int') are easily swapped by mistake [bugprone-easily-swappable-parameters,-warnings-as-errors] > 65 | inline auto readCoalesced(int sourceFd, std::span buf) -> ssize_t > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > ../src/pump.hh:65:31: note: the first parameter in the range is 'sourceFd' > 65 | inline auto readCoalesced(int sourceFd, std::span buf) -> ssize_t > | ^~~~~~~~ > ../src/pump.hh:65:57: note: the last parameter in the range is 'buf' > 65 | inline auto readCoalesced(int sourceFd, std::span buf) -> ssize_t > | ^~~ > ../src/pump.hh:159:23: error: variable 'count' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors] > 159 | ssize_t const count = readCoalesced(sourceFd, input); > | ^ > | = 0 > ../src/pump.hh:276:44: error: the parameter 'initial' of type 'std::string' (aka 'basic_string') is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors] > 276 | static auto makeInitialMsg(std::string initial) -> Msg > | ^ > | const & > FAILED: [code=1] meson-internal__clang-tidy > /nix/store/j2s018h6gc2q0z3sw002br2zas3m1l9d-meson-1.10.2/bin/meson --internal clangtidy /nix/var/nix/builds/nix-12824-4142853305/source /nix/var/nix/builds/nix-12824-4142853305/source/build --color always > ninja: build stopped: subcommand failed. For full logs, run: nix log /nix/store/4fmaf8xkwbmazm7lh4w6yg4952xjw91i-nix-grpc-store-clang-tidy-0.1.0-beta.3.drv error: Cannot build '/nix/store/4fmaf8xkwbmazm7lh4w6yg4952xjw91i-nix-grpc-store-clang-tidy-0.1.0-beta.3.drv'. Reason: builder failed with exit code 1. Output paths: /nix/store/21w0qcdb0j3gpn4yrh8k518nz7xmwj2k-nix-grpc-store-clang-tidy-0.1.0-beta.3