nixbot

builds
sign in

nix-grpc-store-clang-tidy-0.1.0-beta.3 checks.aarch64-linux.clang-tidy · build #520 · raw

1tribuchet: building on eliza
unpackPhase
2unpacking source archive /nix/store/2iw3srf3py4530w1hp78kvln0h6ja33p-source3source root is source
configurePhase
4mesonConfigurePhase flags: --prefix=/nix/store/q5z86fdpx4pcrc56v2fdn3kf48caldbh-nix-grpc-store-clang-tidy-0.1.0-beta.3 --libdir=/nix/store/q5z86fdpx4pcrc56v2fdn3kf48caldbh-nix-grpc-store-clang-tidy-0.1.0-beta.3/lib --libexecdir=/nix/store/q5z86fdpx4pcrc56v2fdn3kf48caldbh-nix-grpc-store-clang-tidy-0.1.0-beta.3/libexec --bindir=/nix/store/q5z86fdpx4pcrc56v2fdn3kf48caldbh-nix-grpc-store-clang-tidy-0.1.0-beta.3/bin --sbindir=/nix/store/q5z86fdpx4pcrc56v2fdn3kf48caldbh-nix-grpc-store-clang-tidy-0.1.0-beta.3/sbin --includedir=/nix/store/q5z86fdpx4pcrc56v2fdn3kf48caldbh-nix-grpc-store-clang-tidy-0.1.0-beta.3/include --mandir=/nix/store/q5z86fdpx4pcrc56v2fdn3kf48caldbh-nix-grpc-store-clang-tidy-0.1.0-beta.3/share/man --infodir=/nix/store/q5z86fdpx4pcrc56v2fdn3kf48caldbh-nix-grpc-store-clang-tidy-0.1.0-beta.3/share/info --localedir=/nix/store/q5z86fdpx4pcrc56v2fdn3kf48caldbh-nix-grpc-store-clang-tidy-0.1.0-beta.3/share/locale -Dauto_features=enabled -Dwrap_mode=nodownload --buildtype=plain -Db_pch=false5The Meson build system6Version: 1.10.27Source dir: /build/source8Build dir: /build/source/build9Build type: native build10WARNING: Project does not target a minimum version but uses feature introduced in '1.1': meson.options file. Use meson_options.txt instead11Project name: nix-grpc-store12Project version: 0.1.0-beta.313C++ compiler for the host machine: clang++ (clang 22.1.8 "clang version 22.1.8")14C++ linker for the host machine: clang++ ld.bfd 2.4615Host machine cpu family: aarch6416Host machine cpu: aarch6417Found pkg-config: YES (/nix/store/96rqsbg8z242724qy85sbld7dbf4hipr-pkg-config-wrapper-0.29.2/bin/pkg-config) 0.29.218Run-time dependency grpc++ found: YES 1.83.019Run-time dependency protobuf found: YES 36.1.020Run-time dependency libzstd found: YES 1.5.721Run-time dependency threads found: YES22Run-time dependency libcrypto found: YES 3.6.423Run-time dependency prometheus-cpp-core found: YES 1.3.024Run-time dependency prometheus-cpp-pull found: YES 1.3.025Run-time dependency absl_flat_hash_map found: YES 2026010726Run-time dependency absl_hash found: YES 2026010727Run-time dependency absl_synchronization found: YES 2026010728Compiler for C++ supports arguments -Werror=thread-safety: YES 29Run-time dependency jemalloc found: YES 5.3.1_030Run-time dependency nix-store found: YES 2.36.0pre20260920_5711f8fe31Run-time dependency nix-util found: YES 2.36.0pre20260920_5711f8fe32Run-time dependency libcurl found: YES 8.22.033Run-time dependency nlohmann_json found: YES 3.12.034Check usable header "jwt-cpp/traits/nlohmann-json/defaults.h" : YES 35Program protoc found: YES (/nix/store/nxlmb8lkbnzwcj46mmsvn1gjrgzap7sw-protobuf-36.1/bin/protoc)36Program grpc_cpp_plugin found: YES (/nix/store/zsbcm1brz7v8ilrz6w8ij11yhbf8fyiv-grpc-1.83.0/bin/grpc_cpp_plugin)37Program mold found: YES (/nix/store/463q48w7fn9s93amh1y7jsyrws5sh8rm-mold-unwrapped-wrapper-2.42.1/bin/mold)38Run-time dependency dl found: YES39Program tests/farm-client-test.sh found: YES (/build/source/tests/farm-client-test.sh)40Program tests/oidc-test.sh found: YES (/build/source/tests/oidc-test.sh)41Build targets in project: 1242WARNING: Project specifies no minimum version but uses features which were added in versions:43 * 1.1: {'meson.options file'}4445nix-grpc-store 0.1.0-beta.34647 User defined options48 auto_features: enabled49 b_pch : false50 bindir : /nix/store/q5z86fdpx4pcrc56v2fdn3kf48caldbh-nix-grpc-store-clang-tidy-0.1.0-beta.3/bin51 buildtype : plain52 includedir : /nix/store/q5z86fdpx4pcrc56v2fdn3kf48caldbh-nix-grpc-store-clang-tidy-0.1.0-beta.3/include53 infodir : /nix/store/q5z86fdpx4pcrc56v2fdn3kf48caldbh-nix-grpc-store-clang-tidy-0.1.0-beta.3/share/info54 libdir : /nix/store/q5z86fdpx4pcrc56v2fdn3kf48caldbh-nix-grpc-store-clang-tidy-0.1.0-beta.3/lib55 libexecdir : /nix/store/q5z86fdpx4pcrc56v2fdn3kf48caldbh-nix-grpc-store-clang-tidy-0.1.0-beta.3/libexec56 localedir : /nix/store/q5z86fdpx4pcrc56v2fdn3kf48caldbh-nix-grpc-store-clang-tidy-0.1.0-beta.3/share/locale57 mandir : /nix/store/q5z86fdpx4pcrc56v2fdn3kf48caldbh-nix-grpc-store-clang-tidy-0.1.0-beta.3/share/man58 prefix : /nix/store/q5z86fdpx4pcrc56v2fdn3kf48caldbh-nix-grpc-store-clang-tidy-0.1.0-beta.359 sbindir : /nix/store/q5z86fdpx4pcrc56v2fdn3kf48caldbh-nix-grpc-store-clang-tidy-0.1.0-beta.3/sbin60 wrap_mode : nodownload6162Found ninja-1.13.2 at /nix/store/ijbipgac9wyp1n5smvkd8fczs9jyr26g-ninja-1.13.2/bin/ninja63mesonConfigurePhase: enabled\ parallel\ building
buildPhase
64[1/1] Generating nix_remote_proto with a custom command65[0/1] /nix/store/sc7hggvmvma7m8bbgmp8gsa1q1x37aq8-meson-1.10.2/bin/meson --internal clangtidy /build/source /build/source/build --color always66>>> /nix/store/7wgbxsfygsdmgsai483p205pkcpy6ls8-clang-tools-22.1.8/bin/clang-tidy --use-color -quiet -p /build/source/build /build/source/src/daemon/eds.cc67Error while processing /build/source/src/daemon/eds.cc.68../src/daemon/eds.cc:13:1: error: included header set is not used directly [misc-include-cleaner,-warnings-as-errors]69 13 | #include <set>70 | ^~~~~~~~~~~~~~71 14 | #include <string>72../src/daemon/eds.cc:17:1: error: included header vector is not used directly [misc-include-cleaner,-warnings-as-errors]73 17 | #include <vector>74 | ^~~~~~~~~~~~~~~~~75 18 | 76../src/daemon/eds.cc:24:1: error: included header server_callback.h is not used directly [misc-include-cleaner,-warnings-as-errors]77 24 | #include <grpcpp/support/server_callback.h>78 | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~79 25 | #include <grpcpp/support/status.h>80../src/daemon/eds.cc:32:1: error: included header sched-reactor.hh is not used directly [misc-include-cleaner,-warnings-as-errors]81 32 | #include "sched-reactor.hh"82 | ^~~~~~~~~~~~~~~~~~~~~~~~~~~83 33 | 84../src/daemon/eds.cc:129:16: error: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr,-warnings-as-errors]85 128 | if (std::cmp_greater(req.resource_names_size(), maxNames)) {86 | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~87 | return !static_cast<bool>(std::cmp_greater(req.resource_names_size(), maxNames))88 129 | return false;89 | ~~~~~~~^~~~~~90 130 | }91 | ~92 131 | for (const auto & name : req.resource_names()) {93 | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~94 132 | if (name.empty() || name.size() > maxNameLen) {95 | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~96 133 | return false;97 | ~~~~~~~~~~~~~98 134 | }99 | ~100 135 | names.insert(name);101 | ~~~~~~~~~~~~~~~~~~~102 136 | }103 | ~104 137 | return true;105 | ~~~~~~~~~~~106../src/daemon/eds.cc:156:5: error: constructor does not initialize these fields: in, out, names [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]107 156 | EdsReactor(grpc::CallbackServerContext * ctx, Dispatcher & disp, EdsService & svc)108 | ^109../src/daemon/eds.cc:166:9: error: 'watch' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer,-warnings-as-errors]110 159 | , svc(svc)111 | 112 160 | , stream(std::make_shared<Stream>())113 161 | {114 162 | {115 163 | const absl::MutexLock lock(stream->mutex);116 164 | stream->reactor = this;117 165 | }118 166 | watch = disp.watchMembership([stream = stream] -> void {119 | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~120 167 | EdsReactor * run = nullptr;121 | ~~~~~~~~~~~~~~~~~~~~~~~~~~~122 168 | {123 | ~124 169 | const absl::MutexLock lock(stream->mutex);125 | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~126 170 | if (stream->reactor != nullptr && stream->reactor->beginWake()) {127 | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~128 171 | run = stream->reactor;129 | ~~~~~~~~~~~~~~~~~~~~~~130 172 | }131 | ~132 173 | }133 | ~134 174 | if (run != nullptr) {135 | ~~~~~~~~~~~~~~~~~~~~~136../src/daemon/eds.cc:293:13: error: variable 'failure' of type 'std::string_view' (aka 'basic_string_view<char>') can be declared 'const' [misc-const-correctness,-warnings-as-errors]137 293 | std::string_view failure;138 | ^139 | const 140../src/daemon/eds.cc:326:30: error: the parameter 'fin' of type 'grpc::Status' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]141 326 | void finish(grpc::Status fin)142 | ^143 | const &144../src/daemon/eds.cc:354:18: error: member 'disp' of type 'Dispatcher &' is a reference [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]145 354 | Dispatcher & disp;146 | ^147../src/daemon/eds.cc:355:18: error: member 'svc' of type 'EdsService &' is a reference [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]148 355 | EdsService & svc;149 | ^150../src/daemon/eds.cc:370:1: error: constructor does not initialize these fields: rendered [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]151 370 | EdsService::EdsService(Dispatcher & dispatcher, Auth & auth)152 | ^153/build/source/build/../src/daemon/eds.hh:17:10: error: 'eds.grpc.pb.h' file not found [clang-diagnostic-error]154 17 | #include "eds.grpc.pb.h"155 | ^~~~~~~~~~~~~~~156../src/daemon/sched-reactor.hh:28:8: error: constructor does not initialize these fields: queue [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]157 28 | struct SendQueue158 | ^159 29 | {160 30 | // About a minute of Expects at full rate. Beyond it the peer is stuck.161 31 | static constexpr size_t limit = 1U << 16U;162 32 | // Messages per Write.163 33 | static constexpr int maxBatch = 1024;164 34 | 165 35 | // Leaf lock, may be taken inside Dispatcher::mutex.166 36 | absl::Mutex mutex;167 37 | std::deque<Msg> queue ABSL_GUARDED_BY(mutex);168 | {}169../src/daemon/sched-reactor.hh:169:30: error: the parameter 'fin' of type 'grpc::Status' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]170 169 | void finish(grpc::Status fin)171 | ^172 | const &173../src/daemon/sched-reactor.hh:226:18: error: member 'disp' of type 'Dispatcher &' is a reference [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]174 226 | Dispatcher & disp;175 | ^176../src/daemon/sched-reactor.hh:255:18: error: member 'disp' of type 'Dispatcher &' is a reference [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]177 255 | Dispatcher & disp;178 | ^179>>> /nix/store/7wgbxsfygsdmgsai483p205pkcpy6ls8-clang-tools-22.1.8/bin/clang-tidy --use-color -quiet -p /build/source/build /build/source/src/daemon/main.cc180Error while processing /build/source/src/daemon/main.cc.181../src/daemon/coordinator.hh:96:5: error: function 'hello' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]182 96 | auto hello() const -> nix::remote::WorkerMsg;183 | ^184 | [[nodiscard]] 185../src/daemon/coordinator.hh:109:5: error: function 'send' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]186 109 | auto send(const nix::remote::WorkerMsg & msg) const -> bool;187 | ^188 | [[nodiscard]] 189../src/daemon/coordinator.hh:112:21: error: member 'options' of type 'const Options &' is a reference [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]190 112 | const Options & options;191 | ^192../src/daemon/coordinator.hh:113:15: error: member 'metrics' of type 'Metrics &' is a reference [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]193 113 | Metrics & metrics;194 | ^195../src/daemon/coordinator.hh:115:12: error: constructor does not initialize these fields: expected [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]196 115 | struct State197 | ^198 116 | {199 117 | std::unordered_map<std::string, Expected> expected;200 | 201 | {}202../src/daemon/eds.hh:17:10: error: 'eds.grpc.pb.h' file not found [clang-diagnostic-error]203 17 | #include "eds.grpc.pb.h"204 | ^~~~~~~~~~~~~~~205../src/daemon/main.cc:21:1: error: included header filesystem is not used directly [misc-include-cleaner,-warnings-as-errors]206 21 | #include <filesystem>207 | ^~~~~~~~~~~~~~~~~~~~~208 22 | #include <map>209../src/daemon/main.cc:22:1: error: included header map is not used directly [misc-include-cleaner,-warnings-as-errors]210 22 | #include <map>211 | ^~~~~~~~~~~~~~212 23 | #include <memory>213../src/daemon/main.cc:26:1: error: included header ranges is not used directly [misc-include-cleaner,-warnings-as-errors]214 26 | #include <ranges>215 | ^~~~~~~~~~~~~~~~~216 27 | #include <span>217../src/daemon/main.cc:32:1: error: included header vector is not used directly [misc-include-cleaner,-warnings-as-errors]218 32 | #include <vector>219 | ^~~~~~~~~~~~~~~~~220 33 | 221../src/daemon/main.cc:77:1: error: included header path-info-wire.hh is not used directly [misc-include-cleaner,-warnings-as-errors]222 77 | #include "path-info-wire.hh"223 | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~224 78 | #include "metrics.hh"225../src/daemon/main.cc:231:9: error: 3 adjacent parameters of 'NixRemoteService' of similar type ('std::string') are easily swapped by mistake [bugprone-easily-swappable-parameters,-warnings-as-errors]226 231 | std::string socketPath,227 | ^~~~~~~~~~~~~~~~~~~~~~~228 232 | std::string storeUri,229 | ~~~~~~~~~~~~~~~~~~~~~230 233 | std::string workerName,231 | ~~~~~~~~~~~~~~~~~~~~~~232../src/daemon/main.cc:231:21: note: the first parameter in the range is 'socketPath'233 231 | std::string socketPath,234 | ^~~~~~~~~~235../src/daemon/main.cc:233:21: note: the last parameter in the range is 'workerName'236 233 | std::string workerName,237 | ^~~~~~~~~~238../src/daemon/main.cc:231:21: error: the parameter 'socketPath' of type 'std::string' (aka 'basic_string<char>') is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]239 231 | std::string socketPath,240 | ^241 | const &242../src/daemon/main.cc:260:15: error: empty catch statements hide issues; to handle exceptions appropriately, consider re-throwing, handling, or avoiding catch altogether [bugprone-empty-catch,-warnings-as-errors]243 260 | } catch (nix::Error & err) {244 | ^245../src/daemon/main.cc:297:13: error: variable 'paths' of type 'nix::StorePathSet' (aka 'std::set<StorePath>') can be declared 'const' [misc-const-correctness,-warnings-as-errors]246 297 | nix::StorePathSet paths;247 | ^248 | const 249../src/daemon/main.cc:669:62: error: the parameter 'event' of type 'nixgrpc::BuildEvent' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]250 669 | auto const sendLogLine = [&](nixgrpc::BuildEvent event) -> void {251 | ^252 | const &253../src/path-info-wire.hh:35:5: error: variable 'path' of type 'nix::StorePath' can be declared 'const' [misc-const-correctness,-warnings-as-errors]254 35 | nix::StorePath path(entry.path());255 | ^256 | const 257../src/pump.hh:65:27: error: 2 adjacent parameters of 'readCoalesced' of similar type ('int') are easily swapped by mistake [bugprone-easily-swappable-parameters,-warnings-as-errors]258 65 | inline auto readCoalesced(int sourceFd, std::span<char> buf) -> ssize_t259 | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~260../src/pump.hh:65:31: note: the first parameter in the range is 'sourceFd'261 65 | inline auto readCoalesced(int sourceFd, std::span<char> buf) -> ssize_t262 | ^~~~~~~~263../src/pump.hh:65:57: note: the last parameter in the range is 'buf'264 65 | inline auto readCoalesced(int sourceFd, std::span<char> buf) -> ssize_t265 | ^~~266../src/pump.hh:159:23: error: variable 'count' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]267 159 | ssize_t const count = readCoalesced(sourceFd, input);268 | ^ 269 | = 0270../src/pump.hh:276:44: error: the parameter 'initial' of type 'std::string' (aka 'basic_string<char>') is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]271 276 | static auto makeInitialMsg(std::string initial) -> Msg272 | ^273 | const &274>>> /nix/store/7wgbxsfygsdmgsai483p205pkcpy6ls8-clang-tools-22.1.8/bin/clang-tidy --use-color -quiet -p /build/source/build /build/source/src/daemon/coordinator.cc275Error while processing /build/source/src/daemon/coordinator.cc.276../src/client/channel.hh:46:3: error: constructor does not initialize these fields: headers [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]277 46 | explicit StaticHeaders(std::shared_ptr<const Headers> headers) : headers(std::move(headers)) {}278 | ^279../src/client/channel.hh:62:5: error: constructor does not initialize these fields: headers [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]280 62 | explicit Factory(Headers hdrs) : headers(std::make_shared<const Headers>(std::move(hdrs))) {}281 | ^282 63 | auto CreateClientInterceptor(grpc::experimental::ClientRpcInfo * /*info*/)283 64 | -> grpc::experimental::Interceptor * override {284 65 | return new StaticHeaders(headers); // NOLINT(cppcoreguidelines-owning-memory): gRPC deletes it285 66 | }286 67 | private:287 68 | std::shared_ptr<const Headers> headers;288 | 289 | {}290../src/client/channel.hh:87:64: error: pointer parameter 'metadata' can be pointer to const [readability-non-const-parameter,-warnings-as-errors]291 87 | std::multimap<grpc::string, grpc::string> * metadata) -> grpc::Status override {292 | ^293 | const 294../src/daemon/backend.hh:79:25: error: the parameter 'event' of type 'BuildEvent' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]295 79 | auto toChunk(BuildEvent event) -> Chunk296 | ^297 | const &298../src/daemon/coordinator.cc:8:1: error: included header functional is not used directly [misc-include-cleaner,-warnings-as-errors]299 8 | #include <functional>300 | ^~~~~~~~~~~~~~~~~~~~~301 9 | #include <initializer_list>302../src/daemon/coordinator.cc:9:1: error: included header initializer_list is not used directly [misc-include-cleaner,-warnings-as-errors]303 9 | #include <initializer_list>304 | ^~~~~~~~~~~~~~~~~~~~~~~~~~~305 10 | #include <memory>306../src/daemon/coordinator.cc:17:1: error: included header unordered_set is not used directly [misc-include-cleaner,-warnings-as-errors]307 17 | #include <unordered_set>308 | ^~~~~~~~~~~~~~~~~~~~~~~~309 18 | #include <utility>310../src/daemon/coordinator.cc:19:1: error: included header vector is not used directly [misc-include-cleaner,-warnings-as-errors]311 19 | #include <vector>312 | ^~~~~~~~~~~~~~~~~313 20 | 314../src/daemon/coordinator.cc:35:1: error: included header sync_stream.h is not used directly [misc-include-cleaner,-warnings-as-errors]315 35 | #include <grpcpp/support/sync_stream.h>316 | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~317 36 | 318../src/daemon/coordinator.cc:47:1: error: included header nix_remote.grpc.pb.h is not used directly [misc-include-cleaner,-warnings-as-errors]319 47 | #include "nix_remote.grpc.pb.h"320 | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~321 48 | #include "nix_remote.pb.h"322../src/daemon/coordinator.cc:70:1: error: constructor does not initialize these fields: state, sendFn [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]323 70 | Builder::Builder(const Options & options, Metrics & metrics)324 | ^325../src/daemon/coordinator.cc:91:15: error: method 'onRevoke' can be made static [readability-convert-member-functions-to-static,-warnings-as-errors]326 91 | void Builder::onRevoke(const nix::remote::Revoke & rev)327 | ^328../src/daemon/coordinator.cc:112:15: error: method 'admit' can be made static [readability-convert-member-functions-to-static,-warnings-as-errors]329 112 | auto Builder::admit(const std::string & drvPath) -> std::optional<Admission>330 | ^331../src/daemon/coordinator.cc:125:15: error: method 'finished' can be made static [readability-convert-member-functions-to-static,-warnings-as-errors]332 125 | void Builder::finished(333 | ^334 | static 335../src/daemon/coordinator.cc:129:17: error: the parameter 'resultWire' of type 'std::string' (aka 'basic_string<char>') is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]336 129 | std::string resultWire)337 | ^338 | const &339../src/daemon/coordinator.cc:210:15: error: method 'send' can be made static [readability-convert-member-functions-to-static,-warnings-as-errors]340 210 | auto Builder::send(const WorkerMsg & msg) const -> bool341 | ^ ~~~~~342../src/daemon/coordinator.cc:216:15: error: method 'tick' can be made static [readability-convert-member-functions-to-static,-warnings-as-errors]343 216 | void Builder::tick()344 | ^345../src/daemon/coordinator.cc:296:24: error: no header providing "nix::Error" is directly included [misc-include-cleaner,-warnings-as-errors]346 12 | throw nix::Error("loading CA certificates: %s", status.ToString());347 | ^348../src/daemon/coordinator.cc:322:5: error: if with identical then and else branches [bugprone-branch-clone,-warnings-as-errors]349 322 | if (active) {350 | ^351../src/daemon/coordinator.cc:324:7: note: else branch starts here352 324 | } else {353 | ^354../src/daemon/coordinator.cc:341:1: error: constructor does not initialize these fields: scheduler, eds [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]355 341 | Coordinator::Coordinator(const Options & options, Auth & auth, Metrics & metrics)356 | ^357../src/daemon/coordinator.cc:350:9: error: variable 'present' of type 'Dispatcher::PresentFn' (aka 'std::function<std::unordered_set<basic_string<char>> (const std::vector<basic_string<char>> &)>') can be declared 'const' [misc-const-correctness,-warnings-as-errors]358 350 | Dispatcher::PresentFn present;359 | ^360 | const 361../src/daemon/coordinator.cc:409:20: error: variable 'elect' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]362 409 | const bool elect = options.niks3.enabled() && (!builder || !options.schedulerAddr.empty());363 | ^ 364 | = false365../src/daemon/coordinator.cc:458:9: error: variable 'restarting' of type 'bool' can be declared 'const' [misc-const-correctness,-warnings-as-errors]366 458 | bool restarting = false;367 | ^368 | const 369/build/source/build/../src/daemon/coordinator.hh:96:5: error: function 'hello' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]370 96 | auto hello() const -> nix::remote::WorkerMsg;371 | ^372 | [[nodiscard]] 373/build/source/build/../src/daemon/coordinator.hh:109:5: error: function 'send' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]374 109 | auto send(const nix::remote::WorkerMsg & msg) const -> bool;375 | ^376 | [[nodiscard]] 377/build/source/build/../src/daemon/coordinator.hh:112:21: error: member 'options' of type 'const Options &' is a reference [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]378 112 | const Options & options;379 | ^380/build/source/build/../src/daemon/coordinator.hh:113:15: error: member 'metrics' of type 'Metrics &' is a reference [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]381 113 | Metrics & metrics;382 | ^383/build/source/build/../src/daemon/coordinator.hh:115:12: error: constructor does not initialize these fields: expected [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]384 115 | struct State385 | ^386 116 | {387 117 | std::unordered_map<std::string, Expected> expected;388 | 389 | {}390../src/daemon/eds.hh:17:10: error: 'eds.grpc.pb.h' file not found [clang-diagnostic-error]391 17 | #include "eds.grpc.pb.h"392 | ^~~~~~~~~~~~~~~393../src/daemon/sched-reactor.hh:28:8: error: constructor does not initialize these fields: queue [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]394 28 | struct SendQueue395 | ^396 29 | {397 30 | // About a minute of Expects at full rate. Beyond it the peer is stuck.398 31 | static constexpr size_t limit = 1U << 16U;399 32 | // Messages per Write.400 33 | static constexpr int maxBatch = 1024;401 34 | 402 35 | // Leaf lock, may be taken inside Dispatcher::mutex.403 36 | absl::Mutex mutex;404 37 | std::deque<Msg> queue ABSL_GUARDED_BY(mutex);405 | {}406../src/daemon/sched-reactor.hh:169:30: error: the parameter 'fin' of type 'grpc::Status' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]407 169 | void finish(grpc::Status fin)408 | ^409 | const &410../src/daemon/sched-reactor.hh:226:18: error: member 'disp' of type 'Dispatcher &' is a reference [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]411 226 | Dispatcher & disp;412 | ^413../src/daemon/sched-reactor.hh:255:18: error: member 'disp' of type 'Dispatcher &' is a reference [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]414 255 | Dispatcher & disp;415 | ^416>>> /nix/store/7wgbxsfygsdmgsai483p205pkcpy6ls8-clang-tools-22.1.8/bin/clang-tidy --use-color -quiet -p /build/source/build /build/source/src/client/channel.cc417Errors encountered while running clang-tidy418[1/1] (1/2) Processing file /build/source/src/client/channel.cc.419[1/1] (2/2) Processing file /build/source/src/client/channel.cc.420FAILED: [code=1] meson-internal__clang-tidy 421/nix/store/sc7hggvmvma7m8bbgmp8gsa1q1x37aq8-meson-1.10.2/bin/meson --internal clangtidy /build/source /build/source/build --color always422ninja: build stopped: subcommand failed.