nix-grpc-store-clang-tidy-0.1.0-beta.3
checks.aarch64-darwin.clang-tidy
· build #524
· raw
unpackPhase
1unpacking source archive /nix/store/2iw3srf3py4530w1hp78kvln0h6ja33p-source2source root is sourceconfigurePhase
3mesonConfigurePhase flags: --prefix=/nix/store/21w0qcdb0j3gpn4yrh8k518nz7xmwj2k-nix-grpc-store-clang-tidy-0.1.0-beta.3 --libdir=/nix/store/21w0qcdb0j3gpn4yrh8k518nz7xmwj2k-nix-grpc-store-clang-tidy-0.1.0-beta.3/lib --libexecdir=/nix/store/21w0qcdb0j3gpn4yrh8k518nz7xmwj2k-nix-grpc-store-clang-tidy-0.1.0-beta.3/libexec --bindir=/nix/store/21w0qcdb0j3gpn4yrh8k518nz7xmwj2k-nix-grpc-store-clang-tidy-0.1.0-beta.3/bin --sbindir=/nix/store/21w0qcdb0j3gpn4yrh8k518nz7xmwj2k-nix-grpc-store-clang-tidy-0.1.0-beta.3/sbin --includedir=/nix/store/21w0qcdb0j3gpn4yrh8k518nz7xmwj2k-nix-grpc-store-clang-tidy-0.1.0-beta.3/include --mandir=/nix/store/21w0qcdb0j3gpn4yrh8k518nz7xmwj2k-nix-grpc-store-clang-tidy-0.1.0-beta.3/share/man --infodir=/nix/store/21w0qcdb0j3gpn4yrh8k518nz7xmwj2k-nix-grpc-store-clang-tidy-0.1.0-beta.3/share/info --localedir=/nix/store/21w0qcdb0j3gpn4yrh8k518nz7xmwj2k-nix-grpc-store-clang-tidy-0.1.0-beta.3/share/locale -Dauto_features=enabled -Dwrap_mode=nodownload --buildtype=plain -Db_pch=false4The Meson build system5Version: 1.10.26Source dir: /nix/var/nix/builds/nix-13329-3537576181/source7Build dir: /nix/var/nix/builds/nix-13329-3537576181/source/build8Build type: native build9WARNING: Project does not target a minimum version but uses feature introduced in '1.1': meson.options file. Use meson_options.txt instead10Project name: nix-grpc-store11Project version: 0.1.0-beta.312C++ compiler for the host machine: clang++ (clang 22.1.8 "clang version 22.1.8")13C++ linker for the host machine: clang++ ld64 956.614Host machine cpu family: aarch6415Host machine cpu: aarch6416Found pkg-config: YES (/nix/store/kd2x1bj3gwfh2hb69fk5ym043h2qavxc-pkg-config-wrapper-0.29.2/bin/pkg-config) 0.29.217Run-time dependency grpc++ found: YES 1.83.018Run-time dependency protobuf found: YES 36.1.019Run-time dependency libzstd found: YES 1.5.720Run-time dependency threads found: YES21Run-time dependency libcrypto found: YES 3.6.422Run-time dependency prometheus-cpp-core found: YES 1.3.023Run-time dependency prometheus-cpp-pull found: YES 1.3.024Run-time dependency absl_flat_hash_map found: YES 2026010725Run-time dependency absl_hash found: YES 2026010726Run-time dependency absl_synchronization found: YES 2026010727Compiler for C++ supports arguments -Werror=thread-safety: YES 28Run-time dependency jemalloc found: YES 5.3.1_029Run-time dependency nix-store found: YES 2.36.0pre20260920_5711f8fe30Run-time dependency nix-util found: YES 2.36.0pre20260920_5711f8fe31Run-time dependency libcurl found: YES 8.22.032Run-time dependency nlohmann_json found: YES 3.12.033Check usable header "jwt-cpp/traits/nlohmann-json/defaults.h" : YES 34Program protoc found: YES (/nix/store/r1npr0vx8d17c0fhh9gvg9mpaiphn62a-protobuf-36.1/bin/protoc)35Program grpc_cpp_plugin found: YES (/nix/store/0mm81ldgq4ssz7gnh8589gx9zfcxpdhq-grpc-1.83.0/bin/grpc_cpp_plugin)36Run-time dependency dl found: YES37Program tests/farm-client-test.sh found: YES (/nix/var/nix/builds/nix-13329-3537576181/source/tests/farm-client-test.sh)38Program tests/oidc-test.sh found: YES (/nix/var/nix/builds/nix-13329-3537576181/source/tests/oidc-test.sh)39Build targets in project: 1240WARNING: Project specifies no minimum version but uses features which were added in versions:41 * 1.1: {'meson.options file'}4243nix-grpc-store 0.1.0-beta.34445 User defined options46 auto_features: enabled47 b_pch : false48 bindir : /nix/store/21w0qcdb0j3gpn4yrh8k518nz7xmwj2k-nix-grpc-store-clang-tidy-0.1.0-beta.3/bin49 buildtype : plain50 includedir : /nix/store/21w0qcdb0j3gpn4yrh8k518nz7xmwj2k-nix-grpc-store-clang-tidy-0.1.0-beta.3/include51 infodir : /nix/store/21w0qcdb0j3gpn4yrh8k518nz7xmwj2k-nix-grpc-store-clang-tidy-0.1.0-beta.3/share/info52 libdir : /nix/store/21w0qcdb0j3gpn4yrh8k518nz7xmwj2k-nix-grpc-store-clang-tidy-0.1.0-beta.3/lib53 libexecdir : /nix/store/21w0qcdb0j3gpn4yrh8k518nz7xmwj2k-nix-grpc-store-clang-tidy-0.1.0-beta.3/libexec54 localedir : /nix/store/21w0qcdb0j3gpn4yrh8k518nz7xmwj2k-nix-grpc-store-clang-tidy-0.1.0-beta.3/share/locale55 mandir : /nix/store/21w0qcdb0j3gpn4yrh8k518nz7xmwj2k-nix-grpc-store-clang-tidy-0.1.0-beta.3/share/man56 prefix : /nix/store/21w0qcdb0j3gpn4yrh8k518nz7xmwj2k-nix-grpc-store-clang-tidy-0.1.0-beta.357 sbindir : /nix/store/21w0qcdb0j3gpn4yrh8k518nz7xmwj2k-nix-grpc-store-clang-tidy-0.1.0-beta.3/sbin58 wrap_mode : nodownload5960Found ninja-1.13.2 at /nix/store/kalf64hrn0zrxlacfvgymwbck77qvsr9-ninja-1.13.2/bin/ninja61mesonConfigurePhase: enabled\ parallel\ buildingbuildPhase
62[1/1] Generating nix_remote_proto with a custom command63[0/1] /nix/store/j2s018h6gc2q0z3sw002br2zas3m1l9d-meson-1.10.2/bin/meson --internal clangtidy /nix/var/nix/builds/nix-13329-3537576181/source /nix/var/nix/builds/nix-13329-3537576181/source/build --color always64>>> /nix/store/l8sbl3yky84xqxj3a5hazrjdx52avnf2-clang-tools-22.1.8/bin/clang-tidy --use-color -quiet -p /nix/var/nix/builds/nix-13329-3537576181/source/build /nix/var/nix/builds/nix-13329-3537576181/source/src/daemon/main.cc65Error while processing /nix/var/nix/builds/nix-13329-3537576181/source/src/daemon/main.cc.66../src/daemon/coordinator.hh:112:21: error: member 'options' of type 'const Options &' is a reference [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]67 112 | const Options & options;68 | ^69../src/daemon/coordinator.hh:113:15: error: member 'metrics' of type 'Metrics &' is a reference [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]70 113 | Metrics & metrics;71 | ^72../src/daemon/coordinator.hh:115:12: error: constructor does not initialize these fields: expected [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]73 115 | struct State74 | ^75 116 | {76 117 | std::unordered_map<std::string, Expected> expected;77 | 78 | {}79../src/daemon/eds.hh:17:10: error: 'eds.grpc.pb.h' file not found [clang-diagnostic-error]80 17 | #include "eds.grpc.pb.h"81 | ^~~~~~~~~~~~~~~82../src/daemon/main.cc:21:1: error: included header filesystem is not used directly [misc-include-cleaner,-warnings-as-errors]83 21 | #include <filesystem>84 | ^~~~~~~~~~~~~~~~~~~~~85 22 | #include <map>86../src/daemon/main.cc:22:1: error: included header map is not used directly [misc-include-cleaner,-warnings-as-errors]87 22 | #include <map>88 | ^~~~~~~~~~~~~~89 23 | #include <memory>90../src/daemon/main.cc:26:1: error: included header ranges is not used directly [misc-include-cleaner,-warnings-as-errors]91 26 | #include <ranges>92 | ^~~~~~~~~~~~~~~~~93 27 | #include <span>94../src/daemon/main.cc:32:1: error: included header vector is not used directly [misc-include-cleaner,-warnings-as-errors]95 32 | #include <vector>96 | ^~~~~~~~~~~~~~~~~97 33 | 98../src/daemon/main.cc:77:1: error: included header path-info-wire.hh is not used directly [misc-include-cleaner,-warnings-as-errors]99 77 | #include "path-info-wire.hh"100 | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~101 78 | #include "metrics.hh"102../src/daemon/main.cc:231:9: error: 3 adjacent parameters of 'NixRemoteService' of similar type ('std::string') are easily swapped by mistake [bugprone-easily-swappable-parameters,-warnings-as-errors]103 231 | std::string socketPath,104 | ^~~~~~~~~~~~~~~~~~~~~~~105 232 | std::string storeUri,106 | ~~~~~~~~~~~~~~~~~~~~~107 233 | std::string workerName,108 | ~~~~~~~~~~~~~~~~~~~~~~109../src/daemon/main.cc:231:21: note: the first parameter in the range is 'socketPath'110 231 | std::string socketPath,111 | ^~~~~~~~~~112../src/daemon/main.cc:233:21: note: the last parameter in the range is 'workerName'113 233 | std::string workerName,114 | ^~~~~~~~~~115../src/daemon/main.cc:231:21: error: the parameter 'socketPath' of type 'std::string' (aka 'basic_string<char>') is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]116 231 | std::string socketPath,117 | ^118 | const &119../src/daemon/main.cc:260:15: error: empty catch statements hide issues; to handle exceptions appropriately, consider re-throwing, handling, or avoiding catch altogether [bugprone-empty-catch,-warnings-as-errors]120 260 | } catch (nix::Error & err) {121 | ^122../src/daemon/main.cc:297:13: error: variable 'paths' of type 'nix::StorePathSet' (aka 'std::set<StorePath>') can be declared 'const' [misc-const-correctness,-warnings-as-errors]123 297 | nix::StorePathSet paths;124 | ^125 | const 126../src/daemon/main.cc:669:62: error: the parameter 'event' of type 'nixgrpc::BuildEvent' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]127 669 | auto const sendLogLine = [&](nixgrpc::BuildEvent event) -> void {128 | ^129 | const &130../src/path-info-wire.hh:35:5: error: variable 'path' of type 'nix::StorePath' can be declared 'const' [misc-const-correctness,-warnings-as-errors]131 35 | nix::StorePath path(entry.path());132 | ^133 | const 134../src/pump.hh:65:27: error: 2 adjacent parameters of 'readCoalesced' of similar type ('int') are easily swapped by mistake [bugprone-easily-swappable-parameters,-warnings-as-errors]135 65 | inline auto readCoalesced(int sourceFd, std::span<char> buf) -> ssize_t136 | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~137../src/pump.hh:65:31: note: the first parameter in the range is 'sourceFd'138 65 | inline auto readCoalesced(int sourceFd, std::span<char> buf) -> ssize_t139 | ^~~~~~~~140../src/pump.hh:65:57: note: the last parameter in the range is 'buf'141 65 | inline auto readCoalesced(int sourceFd, std::span<char> buf) -> ssize_t142 | ^~~143../src/pump.hh:159:23: error: variable 'count' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]144 159 | ssize_t const count = readCoalesced(sourceFd, input);145 | ^ 146 | = 0147../src/pump.hh:276:44: error: the parameter 'initial' of type 'std::string' (aka 'basic_string<char>') is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]148 276 | static auto makeInitialMsg(std::string initial) -> Msg149 | ^150 | const &151>>> /nix/store/l8sbl3yky84xqxj3a5hazrjdx52avnf2-clang-tools-22.1.8/bin/clang-tidy --use-color -quiet -p /nix/var/nix/builds/nix-13329-3537576181/source/build /nix/var/nix/builds/nix-13329-3537576181/source/src/daemon/coordinator.cc152Error while processing /nix/var/nix/builds/nix-13329-3537576181/source/src/daemon/coordinator.cc.153../src/client/channel.hh:46:3: error: constructor does not initialize these fields: headers [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]154 46 | explicit StaticHeaders(std::shared_ptr<const Headers> headers) : headers(std::move(headers)) {}155 | ^156../src/client/channel.hh:62:5: error: constructor does not initialize these fields: headers [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]157 62 | explicit Factory(Headers hdrs) : headers(std::make_shared<const Headers>(std::move(hdrs))) {}158 | ^159 63 | auto CreateClientInterceptor(grpc::experimental::ClientRpcInfo * /*info*/)160 64 | -> grpc::experimental::Interceptor * override {161 65 | return new StaticHeaders(headers); // NOLINT(cppcoreguidelines-owning-memory): gRPC deletes it162 66 | }163 67 | private:164 68 | std::shared_ptr<const Headers> headers;165 | 166 | {}167../src/client/channel.hh:87:64: error: pointer parameter 'metadata' can be pointer to const [readability-non-const-parameter,-warnings-as-errors]168 87 | std::multimap<grpc::string, grpc::string> * metadata) -> grpc::Status override {169 | ^170 | const 171../src/daemon/backend.hh:79:25: error: the parameter 'event' of type 'BuildEvent' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]172 79 | auto toChunk(BuildEvent event) -> Chunk173 | ^174 | const &175../src/daemon/coordinator.cc:8:1: error: included header functional is not used directly [misc-include-cleaner,-warnings-as-errors]176 8 | #include <functional>177 | ^~~~~~~~~~~~~~~~~~~~~178 9 | #include <initializer_list>179../src/daemon/coordinator.cc:9:1: error: included header initializer_list is not used directly [misc-include-cleaner,-warnings-as-errors]180 9 | #include <initializer_list>181 | ^~~~~~~~~~~~~~~~~~~~~~~~~~~182 10 | #include <memory>183../src/daemon/coordinator.cc:17:1: error: included header unordered_set is not used directly [misc-include-cleaner,-warnings-as-errors]184 17 | #include <unordered_set>185 | ^~~~~~~~~~~~~~~~~~~~~~~~186 18 | #include <utility>187../src/daemon/coordinator.cc:19:1: error: included header vector is not used directly [misc-include-cleaner,-warnings-as-errors]188 19 | #include <vector>189 | ^~~~~~~~~~~~~~~~~190 20 | 191../src/daemon/coordinator.cc:35:1: error: included header sync_stream.h is not used directly [misc-include-cleaner,-warnings-as-errors]192 35 | #include <grpcpp/support/sync_stream.h>193 | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~194 36 | 195../src/daemon/coordinator.cc:47:1: error: included header nix_remote.grpc.pb.h is not used directly [misc-include-cleaner,-warnings-as-errors]196 47 | #include "nix_remote.grpc.pb.h"197 | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~198 48 | #include "nix_remote.pb.h"199../src/daemon/coordinator.cc:70:1: error: constructor does not initialize these fields: state, sendFn [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]200 70 | Builder::Builder(const Options & options, Metrics & metrics)201 | ^202../src/daemon/coordinator.cc:91:15: error: method 'onRevoke' can be made static [readability-convert-member-functions-to-static,-warnings-as-errors]203 91 | void Builder::onRevoke(const nix::remote::Revoke & rev)204 | ^205../src/daemon/coordinator.cc:112:15: error: method 'admit' can be made static [readability-convert-member-functions-to-static,-warnings-as-errors]206 112 | auto Builder::admit(const std::string & drvPath) -> std::optional<Admission>207 | ^208../src/daemon/coordinator.cc:125:15: error: method 'finished' can be made static [readability-convert-member-functions-to-static,-warnings-as-errors]209 125 | void Builder::finished(210 | ^211 | static 212../src/daemon/coordinator.cc:129:17: error: the parameter 'resultWire' of type 'std::string' (aka 'basic_string<char>') is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]213 129 | std::string resultWire)214 | ^215 | const &216../src/daemon/coordinator.cc:210:15: error: method 'send' can be made static [readability-convert-member-functions-to-static,-warnings-as-errors]217 210 | auto Builder::send(const WorkerMsg & msg) const -> bool218 | ^ ~~~~~219../src/daemon/coordinator.cc:216:15: error: method 'tick' can be made static [readability-convert-member-functions-to-static,-warnings-as-errors]220 216 | void Builder::tick()221 | ^222../src/daemon/coordinator.cc:296:24: error: no header providing "nix::Error" is directly included [misc-include-cleaner,-warnings-as-errors]223 12 | throw nix::Error("loading CA certificates: %s", status.ToString());224 | ^225../src/daemon/coordinator.cc:322:5: error: if with identical then and else branches [bugprone-branch-clone,-warnings-as-errors]226 322 | if (active) {227 | ^228../src/daemon/coordinator.cc:324:7: note: else branch starts here229 324 | } else {230 | ^231../src/daemon/coordinator.cc:341:1: error: constructor does not initialize these fields: scheduler, eds [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]232 341 | Coordinator::Coordinator(const Options & options, Auth & auth, Metrics & metrics)233 | ^234../src/daemon/coordinator.cc:350:9: error: variable 'present' of type 'Dispatcher::PresentFn' (aka 'std::function<std::unordered_set<basic_string<char>> (const std::vector<basic_string<char>> &)>') can be declared 'const' [misc-const-correctness,-warnings-as-errors]235 350 | Dispatcher::PresentFn present;236 | ^237 | const 238../src/daemon/coordinator.cc:409:20: error: variable 'elect' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]239 409 | const bool elect = options.niks3.enabled() && (!builder || !options.schedulerAddr.empty());240 | ^ 241 | = false242../src/daemon/coordinator.cc:458:9: error: variable 'restarting' of type 'bool' can be declared 'const' [misc-const-correctness,-warnings-as-errors]243 458 | bool restarting = false;244 | ^245 | const 246/nix/var/nix/builds/nix-13329-3537576181/source/build/../src/daemon/coordinator.hh:112:21: error: member 'options' of type 'const Options &' is a reference [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]247 112 | const Options & options;248 | ^249/nix/var/nix/builds/nix-13329-3537576181/source/build/../src/daemon/coordinator.hh:113:15: error: member 'metrics' of type 'Metrics &' is a reference [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]250 113 | Metrics & metrics;251 | ^252/nix/var/nix/builds/nix-13329-3537576181/source/build/../src/daemon/coordinator.hh:115:12: error: constructor does not initialize these fields: expected [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]253 115 | struct State254 | ^255 116 | {256 117 | std::unordered_map<std::string, Expected> expected;257 | 258 | {}259../src/daemon/eds.hh:17:10: error: 'eds.grpc.pb.h' file not found [clang-diagnostic-error]260 17 | #include "eds.grpc.pb.h"261 | ^~~~~~~~~~~~~~~262../src/daemon/sched-reactor.hh:28:8: error: constructor does not initialize these fields: queue [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]263 28 | struct SendQueue264 | ^265 29 | {266 30 | // About a minute of Expects at full rate. Beyond it the peer is stuck.267 31 | static constexpr size_t limit = 1U << 16U;268 32 | // Messages per Write.269 33 | static constexpr int maxBatch = 1024;270 34 | 271 35 | // Leaf lock, may be taken inside Dispatcher::mutex.272 36 | absl::Mutex mutex;273 37 | std::deque<Msg> queue ABSL_GUARDED_BY(mutex);274 | {}275../src/daemon/sched-reactor.hh:169:30: error: the parameter 'fin' of type 'grpc::Status' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]276 169 | void finish(grpc::Status fin)277 | ^278 | const &279../src/daemon/sched-reactor.hh:226:18: error: member 'disp' of type 'Dispatcher &' is a reference [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]280 226 | Dispatcher & disp;281 | ^282../src/daemon/sched-reactor.hh:255:18: error: member 'disp' of type 'Dispatcher &' is a reference [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]283 255 | Dispatcher & disp;284 | ^285>>> /nix/store/l8sbl3yky84xqxj3a5hazrjdx52avnf2-clang-tools-22.1.8/bin/clang-tidy --use-color -quiet -p /nix/var/nix/builds/nix-13329-3537576181/source/build /nix/var/nix/builds/nix-13329-3537576181/source/src/client/channel.cc286[1/1] (1/2) Processing file /nix/var/nix/builds/nix-13329-3537576181/source/src/client/channel.cc.287[1/1] (2/2) Processing file /nix/var/nix/builds/nix-13329-3537576181/source/src/client/channel.cc.288>>> /nix/store/l8sbl3yky84xqxj3a5hazrjdx52avnf2-clang-tools-22.1.8/bin/clang-tidy --use-color -quiet -p /nix/var/nix/builds/nix-13329-3537576181/source/build /nix/var/nix/builds/nix-13329-3537576181/source/src/daemon/eds.cc289Errors encountered while running clang-tidy290Error while processing /nix/var/nix/builds/nix-13329-3537576181/source/src/daemon/eds.cc.291../src/daemon/eds.cc:13:1: error: included header set is not used directly [misc-include-cleaner,-warnings-as-errors]292 13 | #include <set>293 | ^~~~~~~~~~~~~~294 14 | #include <string>295../src/daemon/eds.cc:17:1: error: included header vector is not used directly [misc-include-cleaner,-warnings-as-errors]296 17 | #include <vector>297 | ^~~~~~~~~~~~~~~~~298 18 | 299../src/daemon/eds.cc:24:1: error: included header server_callback.h is not used directly [misc-include-cleaner,-warnings-as-errors]300 24 | #include <grpcpp/support/server_callback.h>301 | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~302 25 | #include <grpcpp/support/status.h>303../src/daemon/eds.cc:32:1: error: included header sched-reactor.hh is not used directly [misc-include-cleaner,-warnings-as-errors]304 32 | #include "sched-reactor.hh"305 | ^~~~~~~~~~~~~~~~~~~~~~~~~~~306 33 | 307../src/daemon/eds.cc:129:16: error: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr,-warnings-as-errors]308 128 | if (std::cmp_greater(req.resource_names_size(), maxNames)) {309 | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~310 | return !static_cast<bool>(std::cmp_greater(req.resource_names_size(), maxNames))311 129 | return false;312 | ~~~~~~~^~~~~~313 130 | }314 | ~315 131 | for (const auto & name : req.resource_names()) {316 | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~317 132 | if (name.empty() || name.size() > maxNameLen) {318 | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~319 133 | return false;320 | ~~~~~~~~~~~~~321 134 | }322 | ~323 135 | names.insert(name);324 | ~~~~~~~~~~~~~~~~~~~325 136 | }326 | ~327 137 | return true;328 | ~~~~~~~~~~~329../src/daemon/eds.cc:156:5: error: constructor does not initialize these fields: in, out, names [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]330 156 | EdsReactor(grpc::CallbackServerContext * ctx, Dispatcher & disp, EdsService & svc)331 | ^332../src/daemon/eds.cc:166:9: error: 'watch' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer,-warnings-as-errors]333 159 | , svc(svc)334 | 335 160 | , stream(std::make_shared<Stream>())336 161 | {337 162 | {338 163 | const absl::MutexLock lock(stream->mutex);339 164 | stream->reactor = this;340 165 | }341 166 | watch = disp.watchMembership([stream = stream] -> void {342 | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~343 167 | EdsReactor * run = nullptr;344 | ~~~~~~~~~~~~~~~~~~~~~~~~~~~345 168 | {346 | ~347 169 | const absl::MutexLock lock(stream->mutex);348 | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~349 170 | if (stream->reactor != nullptr && stream->reactor->beginWake()) {350 | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~351 171 | run = stream->reactor;352 | ~~~~~~~~~~~~~~~~~~~~~~353 172 | }354 | ~355 173 | }356 | ~357 174 | if (run != nullptr) {358 | ~~~~~~~~~~~~~~~~~~~~~359../src/daemon/eds.cc:293:13: error: variable 'failure' of type 'std::string_view' (aka 'basic_string_view<char>') can be declared 'const' [misc-const-correctness,-warnings-as-errors]360 293 | std::string_view failure;361 | ^362 | const 363../src/daemon/eds.cc:326:30: error: the parameter 'fin' of type 'grpc::Status' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]364 326 | void finish(grpc::Status fin)365 | ^366 | const &367../src/daemon/eds.cc:354:18: error: member 'disp' of type 'Dispatcher &' is a reference [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]368 354 | Dispatcher & disp;369 | ^370../src/daemon/eds.cc:355:18: error: member 'svc' of type 'EdsService &' is a reference [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]371 355 | EdsService & svc;372 | ^373../src/daemon/eds.cc:370:1: error: constructor does not initialize these fields: rendered [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]374 370 | EdsService::EdsService(Dispatcher & dispatcher, Auth & auth)375 | ^376/nix/var/nix/builds/nix-13329-3537576181/source/build/../src/daemon/eds.hh:17:10: error: 'eds.grpc.pb.h' file not found [clang-diagnostic-error]377 17 | #include "eds.grpc.pb.h"378 | ^~~~~~~~~~~~~~~379../src/daemon/sched-reactor.hh:28:8: error: constructor does not initialize these fields: queue [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]380 28 | struct SendQueue381 | ^382 29 | {383 30 | // About a minute of Expects at full rate. Beyond it the peer is stuck.384 31 | static constexpr size_t limit = 1U << 16U;385 32 | // Messages per Write.386 33 | static constexpr int maxBatch = 1024;387 34 | 388 35 | // Leaf lock, may be taken inside Dispatcher::mutex.389 36 | absl::Mutex mutex;390 37 | std::deque<Msg> queue ABSL_GUARDED_BY(mutex);391 | {}392../src/daemon/sched-reactor.hh:169:30: error: the parameter 'fin' of type 'grpc::Status' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]393 169 | void finish(grpc::Status fin)394 | ^395 | const &396../src/daemon/sched-reactor.hh:226:18: error: member 'disp' of type 'Dispatcher &' is a reference [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]397 226 | Dispatcher & disp;398 | ^399../src/daemon/sched-reactor.hh:255:18: error: member 'disp' of type 'Dispatcher &' is a reference [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]400 255 | Dispatcher & disp;401 | ^402FAILED: [code=1] meson-internal__clang-tidy 403/nix/store/j2s018h6gc2q0z3sw002br2zas3m1l9d-meson-1.10.2/bin/meson --internal clangtidy /nix/var/nix/builds/nix-13329-3537576181/source /nix/var/nix/builds/nix-13329-3537576181/source/build --color always404ninja: build stopped: subcommand failed.