nixbot

builds

cancelled checks.x86_64-linux.clippy build #316 · raw · ·

1this derivation will be built:2  /nix/store/0y29866g59g5li0b2p8d36hhnmxdx9d4-harmonia-clippy-3.2.0.drv3building '/nix/store/0y29866g59g5li0b2p8d36hhnmxdx9d4-harmonia-clippy-3.2.0.drv'4harmonia-clippy-3.2.0> tribuchet: building on jamie5harmonia-clippy-3.2.0> Running phase: unpackPhase6harmonia-clippy-3.2.0> unpacking source archive /nix/store/6yc8ydvfkk9gsc5ji3mfyrfwmggi71im-source7harmonia-clippy-3.2.0> source root is source8harmonia-clippy-3.2.0> Running phase: patchPhase9harmonia-clippy-3.2.0> Executing configureCargoCommonVars10harmonia-clippy-3.2.0> decompressing cargo artifacts from /nix/store/8q4j51n17h3agji5hasaf9lm35d7792y-harmonia-deps-3.2.0/target.tar.zst to target11harmonia-clippy-3.2.0> Running phase: updateAutotoolsGnuConfigScriptsPhase12harmonia-clippy-3.2.0> Running phase: configurePhase13harmonia-clippy-3.2.0> will append /build/source/.cargo-home/config.toml with contents of /nix/store/xc96ks47xba4z0s5la7v4q690ckqknvf-vendor-cargo-deps/config.toml14harmonia-clippy-3.2.0> default configurePhase, nothing to do15harmonia-clippy-3.2.0> Running phase: buildPhase16harmonia-clippy-3.2.0> +++ command cargo --version17harmonia-clippy-3.2.0> cargo 1.97.0 (c980f4866 2026-06-30)18harmonia-clippy-3.2.0> +++ command cargo clippy --release --locked --all-targets --all-features -- -D warnings19harmonia-clippy-3.2.0>     Checking harmonia-utils-base-encoding v0.0.0-alpha.0 (/build/source/harmonia-utils-base-encoding)20harmonia-clippy-3.2.0>     Checking harmonia-file-core v3.2.0 (/build/source/harmonia-file-core)21harmonia-clippy-3.2.0>     Checking harmonia-utils-io v0.0.0-alpha.0 (/build/source/harmonia-utils-io)22harmonia-clippy-3.2.0>     Checking harmonia-utils-test v0.0.0-alpha.0 (/build/source/harmonia-utils-test)23harmonia-clippy-3.2.0>    Compiling harmonia-protocol-derive v3.2.0 (/build/source/harmonia-protocol-derive)24harmonia-clippy-3.2.0>     Checking harmonia-client v3.2.0 (/build/source/harmonia-client)25harmonia-clippy-3.2.0>     Checking harmonia-ssh-store v3.2.0 (/build/source/harmonia-ssh-store)26harmonia-clippy-3.2.0>     Checking harmonia-utils-hash v0.0.0-alpha.0 (/build/source/harmonia-utils-hash)27harmonia-clippy-3.2.0>     Checking harmonia-utils-signature v3.2.0 (/build/source/harmonia-utils-signature)28harmonia-clippy-3.2.0>     Checking harmonia-file-nar v3.2.0 (/build/source/harmonia-file-nar)29harmonia-clippy-3.2.0>     Checking harmonia-store-path v3.2.0 (/build/source/harmonia-store-path)30harmonia-clippy-3.2.0>     Checking harmonia-store-content-address v3.2.0 (/build/source/harmonia-store-content-address)31harmonia-clippy-3.2.0>     Checking harmonia-store-fs v3.2.0 (/build/source/harmonia-store-fs)32harmonia-clippy-3.2.0>     Checking harmonia-store-ref-scan v0.0.0-alpha.0 (/build/source/harmonia-store-ref-scan)33harmonia-clippy-3.2.0>     Checking harmonia-bench v3.2.0 (/build/source/harmonia-bench)34harmonia-clippy-3.2.0>     Checking harmonia-store-derivation v0.0.0-alpha.0 (/build/source/harmonia-store-derivation)35harmonia-clippy-3.2.0>     Checking harmonia-store-path-info v3.2.0 (/build/source/harmonia-store-path-info)36harmonia-clippy-3.2.0>     Checking harmonia-store-nar-info v3.2.0 (/build/source/harmonia-store-nar-info)37harmonia-clippy-3.2.0>     Checking harmonia-store-db v3.2.0 (/build/source/harmonia-store-db)38harmonia-clippy-3.2.0>     Checking harmonia-store-aterm v0.0.0-alpha.0 (/build/source/harmonia-store-aterm)39harmonia-clippy-3.2.0>     Checking harmonia-store-build-result v3.2.0 (/build/source/harmonia-store-build-result)40harmonia-clippy-3.2.0>     Checking harmonia-protocol v3.2.0 (/build/source/harmonia-protocol)41harmonia-clippy-3.2.0>     Checking harmonia-store-gc v3.2.0 (/build/source/harmonia-store-gc)42harmonia-clippy-3.2.0>     Checking harmonia-cache v3.2.0 (/build/source/harmonia-cache)43harmonia-clippy-3.2.0> error: this expression creates a reference which is immediately dereferenced by the compiler44harmonia-clippy-3.2.0>    --> harmonia-store-gc/src/gc.rs:186:3645harmonia-clippy-3.2.0>     |46harmonia-clippy-3.2.0> 186 |     let _gc_lock = acquire_gc_lock(&store.layout.state_dir())?;47harmonia-clippy-3.2.0>     |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `store.layout.state_dir()`48harmonia-clippy-3.2.0>     |49harmonia-clippy-3.2.0>     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow50harmonia-clippy-3.2.0>     = note: `-D clippy::needless-borrow` implied by `-D warnings`51harmonia-clippy-3.2.0>     = help: to override `-D warnings` add `#[allow(clippy::needless_borrow)]`52harmonia-clippy-3.2.0> 53harmonia-clippy-3.2.0> error: this expression creates a reference which is immediately dereferenced by the compiler54harmonia-clippy-3.2.0>    --> harmonia-store-gc/src/gc.rs:201:3755harmonia-clippy-3.2.0>     |56harmonia-clippy-3.2.0> 201 |         match GcSocketServer::start(&store.layout.state_dir(), live, graph) {57harmonia-clippy-3.2.0>     |                                     ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `store.layout.state_dir()`58harmonia-clippy-3.2.0>     |59harmonia-clippy-3.2.0>     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow60harmonia-clippy-3.2.0> 61harmonia-clippy-3.2.0> error: this expression creates a reference which is immediately dereferenced by the compiler62harmonia-clippy-3.2.0>    --> harmonia-store-gc/src/gc.rs:225:2563harmonia-clippy-3.2.0>     |64harmonia-clippy-3.2.0> 225 |             .load_graph(&store.layout.store_dir(), &opts.graph_options)?,65harmonia-clippy-3.2.0>     |                         ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `store.layout.store_dir()`66harmonia-clippy-3.2.0>     |67harmonia-clippy-3.2.0>     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow68harmonia-clippy-3.2.0> 69harmonia-clippy-3.2.0> error: this expression creates a reference which is immediately dereferenced by the compiler70harmonia-clippy-3.2.0>    --> harmonia-store-gc/src/gc.rs:260:971harmonia-clippy-3.2.0>     |72harmonia-clippy-3.2.0> 260 |         &store.layout.state_dir(),73harmonia-clippy-3.2.0>     |         ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `store.layout.state_dir()`74harmonia-clippy-3.2.0>     |75harmonia-clippy-3.2.0>     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow76harmonia-clippy-3.2.0> 77harmonia-clippy-3.2.0> error: this expression creates a reference which is immediately dereferenced by the compiler78harmonia-clippy-3.2.0>    --> harmonia-store-gc/src/gc.rs:276:3179harmonia-clippy-3.2.0>     |80harmonia-clippy-3.2.0> 276 |     for tr in find_temp_roots(&store.layout.state_dir())? {81harmonia-clippy-3.2.0>     |                               ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `store.layout.state_dir()`82harmonia-clippy-3.2.0>     |83harmonia-clippy-3.2.0>     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow84harmonia-clippy-3.2.0> 85harmonia-clippy-3.2.0> error: the borrowed expression implements the required traits86harmonia-clippy-3.2.0>    --> harmonia-store-gc/src/gc.rs:314:3987harmonia-clippy-3.2.0>     |88harmonia-clippy-3.2.0> 314 |     if let Ok(entries) = fs::read_dir(&store.layout.real_store_dir()) {89harmonia-clippy-3.2.0>     |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `store.layout.real_store_dir()`90harmonia-clippy-3.2.0>     |91harmonia-clippy-3.2.0>     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args92harmonia-clippy-3.2.0>     = note: `-D clippy::needless-borrows-for-generic-args` implied by `-D warnings`93harmonia-clippy-3.2.0>     = help: to override `-D warnings` add `#[allow(clippy::needless_borrows_for_generic_args)]`94harmonia-clippy-3.2.0> 95harmonia-clippy-3.2.0> error: this expression creates a reference which is immediately dereferenced by the compiler96harmonia-clippy-3.2.0>    --> harmonia-store-gc/src/gc.rs:570:4997harmonia-clippy-3.2.0>     |98harmonia-clippy-3.2.0> 570 |     let bytes_freed = bytes_freed + clean_links(&store.layout.links_dir())?;99harmonia-clippy-3.2.0>     |                                                 ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `store.layout.links_dir()`100harmonia-clippy-3.2.0>     |101harmonia-clippy-3.2.0>     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow102harmonia-clippy-3.2.0> 103harmonia-clippy-3.2.0> error: call to `.clone()` on a reference in this situation does nothing104harmonia-clippy-3.2.0>    --> harmonia-store-gc/src/gc.rs:385:55105harmonia-clippy-3.2.0>     |106harmonia-clippy-3.2.0> 385 |     let real_store_dir = store.layout.real_store_dir().clone();107harmonia-clippy-3.2.0>     |                                                       ^^^^^^^^108harmonia-clippy-3.2.0>     |109harmonia-clippy-3.2.0>     = note: the type `std::path::Path` does not implement `Clone`, so calling `clone` on `&std::path::Path` copies the reference, which does not do anything and can be removed110harmonia-clippy-3.2.0>     = note: `-D noop-method-call` implied by `-D warnings`111harmonia-clippy-3.2.0>     = help: to override `-D warnings` add `#[allow(noop_method_call)]`112harmonia-clippy-3.2.0> help: remove this redundant call113harmonia-clippy-3.2.0>     |114harmonia-clippy-3.2.0> 385 -     let real_store_dir = store.layout.real_store_dir().clone();115harmonia-clippy-3.2.0> 385 +     let real_store_dir = store.layout.real_store_dir();116harmonia-clippy-3.2.0>     |117harmonia-clippy-3.2.0> 118harmonia-clippy-3.2.0> error: could not compile `harmonia-store-gc` (lib) due to 8 previous errors119harmonia-clippy-3.2.0> warning: build failed, waiting for other jobs to finish...120harmonia-clippy-3.2.0> error: could not compile `harmonia-store-gc` (lib test) due to 8 previous errors