harmonia-clippy-3.2.0
checks.aarch64-darwin.clippy
· build #343
· raw
unpackPhase
1unpacking source archive /nix/store/qzb5xhans9l9zapfdpsbkdjiphf9nb1f-source2source root is sourcepatchPhase
3Executing configureCargoCommonVars4decompressing cargo artifacts from /nix/store/y895mg3wagbdq93vasah0za9bc6hpqd4-harmonia-deps-3.2.0/target.tar.zst to targetconfigurePhase
5will append /nix/var/nix/builds/nix-72171-3577744800/source/.cargo-home/config.toml with contents of /nix/store/2a1wbxqfgkj4ng9s3ghkw73j4sah48vq-vendor-cargo-deps/config.toml6default configurePhase, nothing to dobuildPhase
7+++ command cargo --version8cargo 1.97.0 (c980f4866 2026-06-30)9+++ command cargo clippy --release --locked --all-targets --all-features -- -D warnings10 Checking harmonia-utils-base-encoding v0.0.0-alpha.0 (/nix/var/nix/builds/nix-72171-3577744800/source/harmonia-utils-base-encoding)11 Checking harmonia-utils-test v0.0.0-alpha.0 (/nix/var/nix/builds/nix-72171-3577744800/source/harmonia-utils-test)12 Checking harmonia-file-core v3.2.0 (/nix/var/nix/builds/nix-72171-3577744800/source/harmonia-file-core)13 Checking harmonia-utils-io v0.0.0-alpha.0 (/nix/var/nix/builds/nix-72171-3577744800/source/harmonia-utils-io)14 Compiling harmonia-protocol-derive v3.2.0 (/nix/var/nix/builds/nix-72171-3577744800/source/harmonia-protocol-derive)15 Checking harmonia-client v3.2.0 (/nix/var/nix/builds/nix-72171-3577744800/source/harmonia-client)16 Checking harmonia-ssh-store v3.2.0 (/nix/var/nix/builds/nix-72171-3577744800/source/harmonia-ssh-store)17 Checking harmonia-utils-hash v0.0.0-alpha.0 (/nix/var/nix/builds/nix-72171-3577744800/source/harmonia-utils-hash)18 Checking harmonia-utils-signature v3.2.0 (/nix/var/nix/builds/nix-72171-3577744800/source/harmonia-utils-signature)19 Checking harmonia-file-nar v3.2.0 (/nix/var/nix/builds/nix-72171-3577744800/source/harmonia-file-nar)20 Checking harmonia-store-path v3.2.0 (/nix/var/nix/builds/nix-72171-3577744800/source/harmonia-store-path)21 Checking harmonia-store-content-address v3.2.0 (/nix/var/nix/builds/nix-72171-3577744800/source/harmonia-store-content-address)22 Checking harmonia-store-fs v3.2.0 (/nix/var/nix/builds/nix-72171-3577744800/source/harmonia-store-fs)23 Checking harmonia-store-ref-scan v0.0.0-alpha.0 (/nix/var/nix/builds/nix-72171-3577744800/source/harmonia-store-ref-scan)24 Checking harmonia-bench v3.2.0 (/nix/var/nix/builds/nix-72171-3577744800/source/harmonia-bench)25 Checking harmonia-store-derivation v0.0.0-alpha.0 (/nix/var/nix/builds/nix-72171-3577744800/source/harmonia-store-derivation)26 Checking harmonia-store-path-info v3.2.0 (/nix/var/nix/builds/nix-72171-3577744800/source/harmonia-store-path-info)27 Checking harmonia-store-nar-info v3.2.0 (/nix/var/nix/builds/nix-72171-3577744800/source/harmonia-store-nar-info)28 Checking harmonia-store-db v3.2.0 (/nix/var/nix/builds/nix-72171-3577744800/source/harmonia-store-db)29 Checking harmonia-store-aterm v0.0.0-alpha.0 (/nix/var/nix/builds/nix-72171-3577744800/source/harmonia-store-aterm)30 Checking harmonia-store-build-result v3.2.0 (/nix/var/nix/builds/nix-72171-3577744800/source/harmonia-store-build-result)31 Checking harmonia-store-gc v3.2.0 (/nix/var/nix/builds/nix-72171-3577744800/source/harmonia-store-gc)32 Checking harmonia-cache v3.2.0 (/nix/var/nix/builds/nix-72171-3577744800/source/harmonia-cache)33 Checking harmonia-protocol v3.2.0 (/nix/var/nix/builds/nix-72171-3577744800/source/harmonia-protocol)34error: this expression creates a reference which is immediately dereferenced by the compiler35 --> harmonia-store-gc/src/gc.rs:186:3636 |37186 | let _gc_lock = acquire_gc_lock(&store.layout.state_dir())?;38 | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `store.layout.state_dir()`39 |40 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow41 = note: `-D clippy::needless-borrow` implied by `-D warnings`42 = help: to override `-D warnings` add `#[allow(clippy::needless_borrow)]`4344error: this expression creates a reference which is immediately dereferenced by the compiler45 --> harmonia-store-gc/src/gc.rs:201:3746 |47201 | match GcSocketServer::start(&store.layout.state_dir(), live, graph) {48 | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `store.layout.state_dir()`49 |50 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow5152error: this expression creates a reference which is immediately dereferenced by the compiler53 --> harmonia-store-gc/src/gc.rs:225:2554 |55225 | .load_graph(&store.layout.store_dir(), &opts.graph_options)?,56 | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `store.layout.store_dir()`57 |58 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow5960error: this expression creates a reference which is immediately dereferenced by the compiler61 --> harmonia-store-gc/src/gc.rs:260:962 |63260 | &store.layout.state_dir(),64 | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `store.layout.state_dir()`65 |66 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow6768error: this expression creates a reference which is immediately dereferenced by the compiler69 --> harmonia-store-gc/src/gc.rs:276:3170 |71276 | for tr in find_temp_roots(&store.layout.state_dir())? {72 | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `store.layout.state_dir()`73 |74 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow7576error: the borrowed expression implements the required traits77 --> harmonia-store-gc/src/gc.rs:314:3978 |79314 | if let Ok(entries) = fs::read_dir(&store.layout.real_store_dir()) {80 | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `store.layout.real_store_dir()`81 |82 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args83 = note: `-D clippy::needless-borrows-for-generic-args` implied by `-D warnings`84 = help: to override `-D warnings` add `#[allow(clippy::needless_borrows_for_generic_args)]`8586error: this expression creates a reference which is immediately dereferenced by the compiler87 --> harmonia-store-gc/src/gc.rs:570:4988 |89570 | let bytes_freed = bytes_freed + clean_links(&store.layout.links_dir())?;90 | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `store.layout.links_dir()`91 |92 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow9394error: this `if` statement can be collapsed95 --> harmonia-store-gc/src/roots/runtime_roots.rs:109:596 |97109 | / if n > 0 {98110 | | if let Ok(s) = std::str::from_utf8(&buf[..n as usize]) {99111 | | add_unchecked(store_prefix, s, unchecked);100112 | | }101113 | | }102 | |_____^103 |104 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if105 = note: `-D clippy::collapsible-if` implied by `-D warnings`106 = help: to override `-D warnings` add `#[allow(clippy::collapsible_if)]`107help: collapse nested if block108 |109109 ~ if n > 0110110 ~ && let Ok(s) = std::str::from_utf8(&buf[..n as usize]) {111111 | add_unchecked(store_prefix, s, unchecked);112112 ~ }113 |114115error: this `if` statement can be collapsed116 --> harmonia-store-gc/src/roots/runtime_roots.rs:187:9117 |118187 | / if r > 0 {119188 | | if let Some(p) = extract_cstr_path(&buf) {120189 | | add_unchecked(store_prefix, &p, unchecked);121190 | | }122191 | | }123 | |_________^124 |125 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if126help: collapse nested if block127 |128187 ~ if r > 0129188 ~ && let Some(p) = extract_cstr_path(&buf) {130189 | add_unchecked(store_prefix, &p, unchecked);131190 ~ }132 |133134error: call to `.clone()` on a reference in this situation does nothing135 --> harmonia-store-gc/src/gc.rs:385:55136 |137385 | let real_store_dir = store.layout.real_store_dir().clone();138 | ^^^^^^^^139 |140 = note: the type `std::path::Path` does not implement `Clone`, so calling `clone` on `&std::path::Path` copies the reference, which does not do anything and can be removed141 = note: `-D noop-method-call` implied by `-D warnings`142 = help: to override `-D warnings` add `#[allow(noop_method_call)]`143help: remove this redundant call144 |145385 - let real_store_dir = store.layout.real_store_dir().clone();146385 + let real_store_dir = store.layout.real_store_dir();147 |148149error: could not compile `harmonia-store-gc` (lib) due to 10 previous errors150warning: build failed, waiting for other jobs to finish...151error: could not compile `harmonia-store-gc` (lib test) due to 10 previous errors