harmonia-clippy-3.2.0
checks.x86_64-linux.clippy
· build #343
· raw
1tribuchet: building on jamie
unpackPhase
2unpacking source archive /nix/store/qzb5xhans9l9zapfdpsbkdjiphf9nb1f-source3source root is sourcepatchPhase
4Executing configureCargoCommonVars5decompressing cargo artifacts from /nix/store/8q4j51n17h3agji5hasaf9lm35d7792y-harmonia-deps-3.2.0/target.tar.zst to targetconfigurePhase
6will append /build/source/.cargo-home/config.toml with contents of /nix/store/xc96ks47xba4z0s5la7v4q690ckqknvf-vendor-cargo-deps/config.toml7default configurePhase, nothing to dobuildPhase
8+++ command cargo --version9cargo 1.97.0 (c980f4866 2026-06-30)10+++ command cargo clippy --release --locked --all-targets --all-features -- -D warnings11 Checking harmonia-utils-base-encoding v0.0.0-alpha.0 (/build/source/harmonia-utils-base-encoding)12 Checking harmonia-file-core v3.2.0 (/build/source/harmonia-file-core)13 Checking harmonia-utils-io v0.0.0-alpha.0 (/build/source/harmonia-utils-io)14 Checking harmonia-utils-test v0.0.0-alpha.0 (/build/source/harmonia-utils-test)15 Compiling harmonia-protocol-derive v3.2.0 (/build/source/harmonia-protocol-derive)16 Checking harmonia-ssh-store v3.2.0 (/build/source/harmonia-ssh-store)17 Checking harmonia-client v3.2.0 (/build/source/harmonia-client)18 Checking harmonia-utils-hash v0.0.0-alpha.0 (/build/source/harmonia-utils-hash)19 Checking harmonia-utils-signature v3.2.0 (/build/source/harmonia-utils-signature)20 Checking harmonia-file-nar v3.2.0 (/build/source/harmonia-file-nar)21 Checking harmonia-store-path v3.2.0 (/build/source/harmonia-store-path)22 Checking harmonia-store-content-address v3.2.0 (/build/source/harmonia-store-content-address)23 Checking harmonia-store-fs v3.2.0 (/build/source/harmonia-store-fs)24 Checking harmonia-store-ref-scan v0.0.0-alpha.0 (/build/source/harmonia-store-ref-scan)25 Checking harmonia-bench v3.2.0 (/build/source/harmonia-bench)26 Checking harmonia-store-derivation v0.0.0-alpha.0 (/build/source/harmonia-store-derivation)27 Checking harmonia-store-path-info v3.2.0 (/build/source/harmonia-store-path-info)28 Checking harmonia-store-nar-info v3.2.0 (/build/source/harmonia-store-nar-info)29 Checking harmonia-store-db v3.2.0 (/build/source/harmonia-store-db)30 Checking harmonia-store-aterm v0.0.0-alpha.0 (/build/source/harmonia-store-aterm)31 Checking harmonia-store-build-result v3.2.0 (/build/source/harmonia-store-build-result)32 Checking harmonia-protocol v3.2.0 (/build/source/harmonia-protocol)33 Checking harmonia-store-gc v3.2.0 (/build/source/harmonia-store-gc)34 Checking harmonia-cache v3.2.0 (/build/source/harmonia-cache)35error: this expression creates a reference which is immediately dereferenced by the compiler36 --> harmonia-store-gc/src/gc.rs:186:3637 |38186 | let _gc_lock = acquire_gc_lock(&store.layout.state_dir())?;39 | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `store.layout.state_dir()`40 |41 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow42 = note: `-D clippy::needless-borrow` implied by `-D warnings`43 = help: to override `-D warnings` add `#[allow(clippy::needless_borrow)]`4445error: this expression creates a reference which is immediately dereferenced by the compiler46 --> harmonia-store-gc/src/gc.rs:201:3747 |48201 | match GcSocketServer::start(&store.layout.state_dir(), live, graph) {49 | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `store.layout.state_dir()`50 |51 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow5253error: this expression creates a reference which is immediately dereferenced by the compiler54 --> harmonia-store-gc/src/gc.rs:225:2555 |56225 | .load_graph(&store.layout.store_dir(), &opts.graph_options)?,57 | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `store.layout.store_dir()`58 |59 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow6061error: this expression creates a reference which is immediately dereferenced by the compiler62 --> harmonia-store-gc/src/gc.rs:260:963 |64260 | &store.layout.state_dir(),65 | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `store.layout.state_dir()`66 |67 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow6869error: this expression creates a reference which is immediately dereferenced by the compiler70 --> harmonia-store-gc/src/gc.rs:276:3171 |72276 | for tr in find_temp_roots(&store.layout.state_dir())? {73 | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `store.layout.state_dir()`74 |75 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow7677error: the borrowed expression implements the required traits78 --> harmonia-store-gc/src/gc.rs:314:3979 |80314 | if let Ok(entries) = fs::read_dir(&store.layout.real_store_dir()) {81 | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `store.layout.real_store_dir()`82 |83 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args84 = note: `-D clippy::needless-borrows-for-generic-args` implied by `-D warnings`85 = help: to override `-D warnings` add `#[allow(clippy::needless_borrows_for_generic_args)]`8687error: this expression creates a reference which is immediately dereferenced by the compiler88 --> harmonia-store-gc/src/gc.rs:570:4989 |90570 | let bytes_freed = bytes_freed + clean_links(&store.layout.links_dir())?;91 | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `store.layout.links_dir()`92 |93 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow9495error: call to `.clone()` on a reference in this situation does nothing96 --> harmonia-store-gc/src/gc.rs:385:5597 |98385 | let real_store_dir = store.layout.real_store_dir().clone();99 | ^^^^^^^^100 |101 = note: the type `std::path::Path` does not implement `Clone`, so calling `clone` on `&std::path::Path` copies the reference, which does not do anything and can be removed102 = note: `-D noop-method-call` implied by `-D warnings`103 = help: to override `-D warnings` add `#[allow(noop_method_call)]`104help: remove this redundant call105 |106385 - let real_store_dir = store.layout.real_store_dir().clone();107385 + let real_store_dir = store.layout.real_store_dir();108 |109110error: could not compile `harmonia-store-gc` (lib) due to 8 previous errors111warning: build failed, waiting for other jobs to finish...112error: could not compile `harmonia-store-gc` (lib test) due to 8 previous errors