tribuchet: building on jamie Running phase: unpackPhase unpacking source archive /nix/store/i85sgl83b3rb4rcwp9hssnj2jml5c11d-source source root is source Running phase: patchPhase Executing configureCargoCommonVars decompressing cargo artifacts from /nix/store/mjv06m65vrxnjd0jd1nfvhrp9s6ldl3p-harmonia-deps-3.2.0/target.tar.zst to target Running phase: updateAutotoolsGnuConfigScriptsPhase Running phase: configurePhase will append /build/source/.cargo-home/config.toml with contents of /nix/store/rya8qxyqb0h7cv75npa1bw6aixc1cs6k-vendor-cargo-deps/config.toml default configurePhase, nothing to do Running phase: buildPhase +++ command cargo --version cargo 1.97.0 (c980f4866 2026-06-30) +++ command cargo clippy --release --locked --all-targets --all-features -- -D warnings Checking harmonia-utils-base-encoding v0.0.0-alpha.0 (/build/source/harmonia-utils-base-encoding) Checking harmonia-file-core v3.2.0 (/build/source/harmonia-file-core) Checking harmonia-utils-io v0.0.0-alpha.0 (/build/source/harmonia-utils-io) Checking harmonia-utils-test v0.0.0-alpha.0 (/build/source/harmonia-utils-test) Compiling harmonia-protocol-derive v3.2.0 (/build/source/harmonia-protocol-derive) Checking harmonia-client v3.2.0 (/build/source/harmonia-client) Checking harmonia-ssh-store v3.2.0 (/build/source/harmonia-ssh-store) Checking harmonia-utils-hash v0.0.0-alpha.0 (/build/source/harmonia-utils-hash) Checking harmonia-utils-signature v3.2.0 (/build/source/harmonia-utils-signature) Checking harmonia-file-nar v3.2.0 (/build/source/harmonia-file-nar) Checking harmonia-store-path v3.2.0 (/build/source/harmonia-store-path) Checking harmonia-store-content-address v3.2.0 (/build/source/harmonia-store-content-address) Checking harmonia-store-ref-scan v0.0.0-alpha.0 (/build/source/harmonia-store-ref-scan) Checking harmonia-store-fs v3.2.0 (/build/source/harmonia-store-fs) Checking harmonia-bench v3.2.0 (/build/source/harmonia-bench) Checking harmonia-store-derivation v0.0.0-alpha.0 (/build/source/harmonia-store-derivation) Checking harmonia-store-path-info v3.2.0 (/build/source/harmonia-store-path-info) Checking harmonia-store-nar-info v3.2.0 (/build/source/harmonia-store-nar-info) Checking harmonia-store-db v3.2.0 (/build/source/harmonia-store-db) Checking harmonia-store-aterm v0.0.0-alpha.0 (/build/source/harmonia-store-aterm) Checking harmonia-store-build-result v3.2.0 (/build/source/harmonia-store-build-result) Checking harmonia-protocol v3.2.0 (/build/source/harmonia-protocol) Checking harmonia-cache v3.2.0 (/build/source/harmonia-cache) Checking harmonia-store-gc v3.2.0 (/build/source/harmonia-store-gc) error: this expression creates a reference which is immediately dereferenced by the compiler --> harmonia-store-gc/src/gc.rs:186:36 | 186 | let _gc_lock = acquire_gc_lock(&store.layout.state_dir())?; | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `store.layout.state_dir()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `-D clippy::needless-borrow` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::needless_borrow)]` error: this expression creates a reference which is immediately dereferenced by the compiler --> harmonia-store-gc/src/gc.rs:201:37 | 201 | match GcSocketServer::start(&store.layout.state_dir(), live, graph) { | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `store.layout.state_dir()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow error: this expression creates a reference which is immediately dereferenced by the compiler --> harmonia-store-gc/src/gc.rs:225:25 | 225 | .load_graph(&store.layout.store_dir(), &opts.graph_options)?, | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `store.layout.store_dir()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow error: this expression creates a reference which is immediately dereferenced by the compiler --> harmonia-store-gc/src/gc.rs:260:9 | 260 | &store.layout.state_dir(), | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `store.layout.state_dir()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow error: this expression creates a reference which is immediately dereferenced by the compiler --> harmonia-store-gc/src/gc.rs:276:31 | 276 | for tr in find_temp_roots(&store.layout.state_dir())? { | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `store.layout.state_dir()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow error: the borrowed expression implements the required traits --> harmonia-store-gc/src/gc.rs:314:39 | 314 | if let Ok(entries) = fs::read_dir(&store.layout.real_store_dir()) { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `store.layout.real_store_dir()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args = note: `-D clippy::needless-borrows-for-generic-args` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::needless_borrows_for_generic_args)]` error: this expression creates a reference which is immediately dereferenced by the compiler --> harmonia-store-gc/src/gc.rs:570:49 | 570 | let bytes_freed = bytes_freed + clean_links(&store.layout.links_dir())?; | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `store.layout.links_dir()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow error: call to `.clone()` on a reference in this situation does nothing --> harmonia-store-gc/src/gc.rs:385:55 | 385 | let real_store_dir = store.layout.real_store_dir().clone(); | ^^^^^^^^ | = note: the type `std::path::Path` does not implement `Clone`, so calling `clone` on `&std::path::Path` copies the reference, which does not do anything and can be removed = note: `-D noop-method-call` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(noop_method_call)]` help: remove this redundant call | 385 - let real_store_dir = store.layout.real_store_dir().clone(); 385 + let real_store_dir = store.layout.real_store_dir(); | error: could not compile `harmonia-store-gc` (lib) due to 8 previous errors warning: build failed, waiting for other jobs to finish... error: could not compile `harmonia-store-gc` (lib test) due to 8 previous errors