harmonia-clippy-3.2.0
checks.aarch64-darwin.clippy
· build #354
· raw
unpackPhase
1unpacking source archive /nix/store/brm289pnxkwqkhaqyrhfrh60zw39qhhw-source2source root is sourcepatchPhase
3Executing configureCargoCommonVars4decompressing cargo artifacts from /nix/store/ghgkd4jy080sqpdz7mh779b989gwjpsy-harmonia-deps-3.2.0/target.tar.zst to targetconfigurePhase
5will append /nix/var/nix/builds/nix-15657-1938767589/source/.cargo-home/config.toml with contents of /nix/store/2a1wbxqfgkj4ng9s3ghkw73j4sah48vq-vendor-cargo-deps/config.toml6default configurePhase, nothing to dobuildPhase
7+++ command cargo --version8cargo 1.97.0 (c980f4866 2026-06-30)9+++ command cargo clippy --release --locked --all-targets --all-features -- -D warnings10 Checking harmonia-utils-base-encoding v0.0.0-alpha.0 (/nix/var/nix/builds/nix-15657-1938767589/source/harmonia-utils-base-encoding)11 Checking harmonia-utils-test v0.0.0-alpha.0 (/nix/var/nix/builds/nix-15657-1938767589/source/harmonia-utils-test)12 Checking harmonia-file-core v3.2.0 (/nix/var/nix/builds/nix-15657-1938767589/source/harmonia-file-core)13 Checking harmonia-utils-io v0.0.0-alpha.0 (/nix/var/nix/builds/nix-15657-1938767589/source/harmonia-utils-io)14 Compiling harmonia-protocol-derive v3.2.0 (/nix/var/nix/builds/nix-15657-1938767589/source/harmonia-protocol-derive)15 Checking harmonia-ssh-store v3.2.0 (/nix/var/nix/builds/nix-15657-1938767589/source/harmonia-ssh-store)16 Checking harmonia-client v3.2.0 (/nix/var/nix/builds/nix-15657-1938767589/source/harmonia-client)17 Checking harmonia-utils-hash v0.0.0-alpha.0 (/nix/var/nix/builds/nix-15657-1938767589/source/harmonia-utils-hash)18 Checking harmonia-utils-signature v3.2.0 (/nix/var/nix/builds/nix-15657-1938767589/source/harmonia-utils-signature)19 Checking harmonia-file-nar v3.2.0 (/nix/var/nix/builds/nix-15657-1938767589/source/harmonia-file-nar)20 Checking harmonia-store-path v3.2.0 (/nix/var/nix/builds/nix-15657-1938767589/source/harmonia-store-path)21 Checking harmonia-store-content-address v3.2.0 (/nix/var/nix/builds/nix-15657-1938767589/source/harmonia-store-content-address)22 Checking harmonia-store-fs v3.2.0 (/nix/var/nix/builds/nix-15657-1938767589/source/harmonia-store-fs)23 Checking harmonia-store-ref-scan v0.0.0-alpha.0 (/nix/var/nix/builds/nix-15657-1938767589/source/harmonia-store-ref-scan)24 Checking harmonia-bench v3.2.0 (/nix/var/nix/builds/nix-15657-1938767589/source/harmonia-bench)25 Checking harmonia-store-derivation v0.0.0-alpha.0 (/nix/var/nix/builds/nix-15657-1938767589/source/harmonia-store-derivation)26 Checking harmonia-store-path-info v3.2.0 (/nix/var/nix/builds/nix-15657-1938767589/source/harmonia-store-path-info)27 Checking harmonia-store-nar-info v3.2.0 (/nix/var/nix/builds/nix-15657-1938767589/source/harmonia-store-nar-info)28 Checking harmonia-store-db v3.2.0 (/nix/var/nix/builds/nix-15657-1938767589/source/harmonia-store-db)29 Checking harmonia-store-aterm v0.0.0-alpha.0 (/nix/var/nix/builds/nix-15657-1938767589/source/harmonia-store-aterm)30 Checking harmonia-store-build-result v3.2.0 (/nix/var/nix/builds/nix-15657-1938767589/source/harmonia-store-build-result)31 Checking harmonia-store-gc v3.2.0 (/nix/var/nix/builds/nix-15657-1938767589/source/harmonia-store-gc)32 Checking harmonia-cache v3.2.0 (/nix/var/nix/builds/nix-15657-1938767589/source/harmonia-cache)33error: this expression creates a reference which is immediately dereferenced by the compiler34 --> harmonia-store-gc/src/gc.rs:186:3635 |36186 | let _gc_lock = acquire_gc_lock(&store.layout.state_dir())?;37 | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `store.layout.state_dir()`38 |39 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow40 = note: `-D clippy::needless-borrow` implied by `-D warnings`41 = help: to override `-D warnings` add `#[allow(clippy::needless_borrow)]`4243error: this expression creates a reference which is immediately dereferenced by the compiler44 --> harmonia-store-gc/src/gc.rs:201:3745 |46201 | match GcSocketServer::start(&store.layout.state_dir(), live, graph) {47 | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `store.layout.state_dir()`48 |49 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow5051error: this expression creates a reference which is immediately dereferenced by the compiler52 --> harmonia-store-gc/src/gc.rs:225:2553 |54225 | .load_graph(&store.layout.store_dir(), &opts.graph_options)?,55 | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `store.layout.store_dir()`56 |57 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow5859error: this expression creates a reference which is immediately dereferenced by the compiler60 --> harmonia-store-gc/src/gc.rs:260:961 |62260 | &store.layout.state_dir(),63 | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `store.layout.state_dir()`64 |65 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow6667error: this expression creates a reference which is immediately dereferenced by the compiler68 --> harmonia-store-gc/src/gc.rs:276:3169 |70276 | for tr in find_temp_roots(&store.layout.state_dir())? {71 | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `store.layout.state_dir()`72 |73 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow7475error: the borrowed expression implements the required traits76 --> harmonia-store-gc/src/gc.rs:314:3977 |78314 | if let Ok(entries) = fs::read_dir(&store.layout.real_store_dir()) {79 | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `store.layout.real_store_dir()`80 |81 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args82 = note: `-D clippy::needless-borrows-for-generic-args` implied by `-D warnings`83 = help: to override `-D warnings` add `#[allow(clippy::needless_borrows_for_generic_args)]`8485error: this expression creates a reference which is immediately dereferenced by the compiler86 --> harmonia-store-gc/src/gc.rs:570:4987 |88570 | let bytes_freed = bytes_freed + clean_links(&store.layout.links_dir())?;89 | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `store.layout.links_dir()`90 |91 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow9293error: this `if` statement can be collapsed94 --> harmonia-store-gc/src/roots/runtime_roots.rs:109:595 |96109 | / if n > 0 {97110 | | if let Ok(s) = std::str::from_utf8(&buf[..n as usize]) {98111 | | add_unchecked(store_prefix, s, unchecked);99112 | | }100113 | | }101 | |_____^102 |103 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if104 = note: `-D clippy::collapsible-if` implied by `-D warnings`105 = help: to override `-D warnings` add `#[allow(clippy::collapsible_if)]`106help: collapse nested if block107 |108109 ~ if n > 0109110 ~ && let Ok(s) = std::str::from_utf8(&buf[..n as usize]) {110111 | add_unchecked(store_prefix, s, unchecked);111112 ~ }112 |113114error: this `if` statement can be collapsed115 --> harmonia-store-gc/src/roots/runtime_roots.rs:187:9116 |117187 | / if r > 0 {118188 | | if let Some(p) = extract_cstr_path(&buf) {119189 | | add_unchecked(store_prefix, &p, unchecked);120190 | | }121191 | | }122 | |_________^123 |124 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if125help: collapse nested if block126 |127187 ~ if r > 0128188 ~ && let Some(p) = extract_cstr_path(&buf) {129189 | add_unchecked(store_prefix, &p, unchecked);130190 ~ }131 |132133error: call to `.clone()` on a reference in this situation does nothing134 --> harmonia-store-gc/src/gc.rs:385:55135 |136385 | let real_store_dir = store.layout.real_store_dir().clone();137 | ^^^^^^^^138 |139 = note: the type `std::path::Path` does not implement `Clone`, so calling `clone` on `&std::path::Path` copies the reference, which does not do anything and can be removed140 = note: `-D noop-method-call` implied by `-D warnings`141 = help: to override `-D warnings` add `#[allow(noop_method_call)]`142help: remove this redundant call143 |144385 - let real_store_dir = store.layout.real_store_dir().clone();145385 + let real_store_dir = store.layout.real_store_dir();146 |147148error: could not compile `harmonia-store-gc` (lib) due to 10 previous errors149warning: build failed, waiting for other jobs to finish...150error: could not compile `harmonia-store-gc` (lib test) due to 10 previous errors