nix-grpc-store-clang-tidy-0.1.0-beta.4
checks.aarch64-darwin.clang-tidy
· build #558
· raw
unpackPhase
1unpacking source archive /nix/store/dyq8rcqb3y33yzng7wafxas1m3s0hhz1-source2source root is sourceconfigurePhase
3mesonConfigurePhase flags: --prefix=/nix/store/7569wpihl3vmc7zl983c4r4an44zmp13-nix-grpc-store-clang-tidy-0.1.0-beta.4 --libdir=/nix/store/7569wpihl3vmc7zl983c4r4an44zmp13-nix-grpc-store-clang-tidy-0.1.0-beta.4/lib --libexecdir=/nix/store/7569wpihl3vmc7zl983c4r4an44zmp13-nix-grpc-store-clang-tidy-0.1.0-beta.4/libexec --bindir=/nix/store/7569wpihl3vmc7zl983c4r4an44zmp13-nix-grpc-store-clang-tidy-0.1.0-beta.4/bin --sbindir=/nix/store/7569wpihl3vmc7zl983c4r4an44zmp13-nix-grpc-store-clang-tidy-0.1.0-beta.4/sbin --includedir=/nix/store/7569wpihl3vmc7zl983c4r4an44zmp13-nix-grpc-store-clang-tidy-0.1.0-beta.4/include --mandir=/nix/store/7569wpihl3vmc7zl983c4r4an44zmp13-nix-grpc-store-clang-tidy-0.1.0-beta.4/share/man --infodir=/nix/store/7569wpihl3vmc7zl983c4r4an44zmp13-nix-grpc-store-clang-tidy-0.1.0-beta.4/share/info --localedir=/nix/store/7569wpihl3vmc7zl983c4r4an44zmp13-nix-grpc-store-clang-tidy-0.1.0-beta.4/share/locale -Dauto_features=enabled -Dwrap_mode=nodownload --buildtype=plain -Db_pch=false4The Meson build system5Version: 1.10.26Source dir: /nix/var/nix/builds/nix-46934-3544683814/source7Build dir: /nix/var/nix/builds/nix-46934-3544683814/source/build8Build type: native build9WARNING: Project does not target a minimum version but uses feature introduced in '1.1': meson.options file. Use meson_options.txt instead10Project name: nix-grpc-store11Project version: 0.1.0-beta.412C++ compiler for the host machine: clang++ (clang 22.1.8 "clang version 22.1.8")13C++ linker for the host machine: clang++ ld64 956.614Host machine cpu family: aarch6415Host machine cpu: aarch6416Found pkg-config: YES (/nix/store/kd2x1bj3gwfh2hb69fk5ym043h2qavxc-pkg-config-wrapper-0.29.2/bin/pkg-config) 0.29.217Run-time dependency grpc++ found: YES 1.83.018Run-time dependency protobuf found: YES 36.1.019Run-time dependency libzstd found: YES 1.5.720Run-time dependency threads found: YES21Run-time dependency libcrypto found: YES 3.6.422Run-time dependency prometheus-cpp-core found: YES 1.3.023Run-time dependency prometheus-cpp-pull found: YES 1.3.024Run-time dependency absl_flat_hash_map found: YES 2026010725Run-time dependency absl_hash found: YES 2026010726Run-time dependency absl_synchronization found: YES 2026010727Compiler for C++ supports arguments -Werror=thread-safety: YES 28Run-time dependency jemalloc found: YES 5.3.1_029Run-time dependency nix-store found: YES 2.36.0pre20260920_5711f8fe30Run-time dependency nix-util found: YES 2.36.0pre20260920_5711f8fe31Run-time dependency libcurl found: YES 8.22.032Run-time dependency nlohmann_json found: YES 3.12.033Check usable header "jwt-cpp/traits/nlohmann-json/defaults.h" : YES 34Program protoc found: YES (/nix/store/r1npr0vx8d17c0fhh9gvg9mpaiphn62a-protobuf-36.1/bin/protoc)35Program grpc_cpp_plugin found: YES (/nix/store/0mm81ldgq4ssz7gnh8589gx9zfcxpdhq-grpc-1.83.0/bin/grpc_cpp_plugin)36Run-time dependency dl found: YES37Program tests/farm-client-test.sh found: YES (/nix/var/nix/builds/nix-46934-3544683814/source/tests/farm-client-test.sh)38Program tests/oidc-test.sh found: YES (/nix/var/nix/builds/nix-46934-3544683814/source/tests/oidc-test.sh)39Build targets in project: 1340WARNING: Project specifies no minimum version but uses features which were added in versions:41 * 1.1: {'meson.options file'}4243nix-grpc-store 0.1.0-beta.44445 User defined options46 auto_features: enabled47 b_pch : false48 bindir : /nix/store/7569wpihl3vmc7zl983c4r4an44zmp13-nix-grpc-store-clang-tidy-0.1.0-beta.4/bin49 buildtype : plain50 includedir : /nix/store/7569wpihl3vmc7zl983c4r4an44zmp13-nix-grpc-store-clang-tidy-0.1.0-beta.4/include51 infodir : /nix/store/7569wpihl3vmc7zl983c4r4an44zmp13-nix-grpc-store-clang-tidy-0.1.0-beta.4/share/info52 libdir : /nix/store/7569wpihl3vmc7zl983c4r4an44zmp13-nix-grpc-store-clang-tidy-0.1.0-beta.4/lib53 libexecdir : /nix/store/7569wpihl3vmc7zl983c4r4an44zmp13-nix-grpc-store-clang-tidy-0.1.0-beta.4/libexec54 localedir : /nix/store/7569wpihl3vmc7zl983c4r4an44zmp13-nix-grpc-store-clang-tidy-0.1.0-beta.4/share/locale55 mandir : /nix/store/7569wpihl3vmc7zl983c4r4an44zmp13-nix-grpc-store-clang-tidy-0.1.0-beta.4/share/man56 prefix : /nix/store/7569wpihl3vmc7zl983c4r4an44zmp13-nix-grpc-store-clang-tidy-0.1.0-beta.457 sbindir : /nix/store/7569wpihl3vmc7zl983c4r4an44zmp13-nix-grpc-store-clang-tidy-0.1.0-beta.4/sbin58 wrap_mode : nodownload5960Found ninja-1.13.2 at /nix/store/kalf64hrn0zrxlacfvgymwbck77qvsr9-ninja-1.13.2/bin/ninja61mesonConfigurePhase: enabled\ parallel\ buildingbuildPhase
62[2/2] Generating nix_remote_proto with a custom command63[0/1] /nix/store/j2s018h6gc2q0z3sw002br2zas3m1l9d-meson-1.10.2/bin/meson --internal clangtidy /nix/var/nix/builds/nix-46934-3544683814/source /nix/var/nix/builds/nix-46934-3544683814/source/build --color always64>>> /nix/store/l8sbl3yky84xqxj3a5hazrjdx52avnf2-clang-tools-22.1.8/bin/clang-tidy --use-color -quiet -p /nix/var/nix/builds/nix-46934-3544683814/source/build /nix/var/nix/builds/nix-46934-3544683814/source/tests/log-spill-test.cc65Error while processing /nix/var/nix/builds/nix-46934-3544683814/source/tests/log-spill-test.cc.66../src/daemon/log-spill.hh:25:7: error: class 'LogSpill' defines a non-default destructor, a copy constructor and a copy assignment operator but does not define a move constructor or a move assignment operator [cppcoreguidelines-special-member-functions,-warnings-as-errors]67 25 | class LogSpill68 | ^69../src/daemon/log-spill.hh:38:24: error: variable name 'fd' is too short, expected at least 3 characters [readability-identifier-length,-warnings-as-errors]70 38 | if (auto const fd = fd_.load(); fd >= 0) {71 | ^72../src/daemon/log-spill.hh:51:20: error: variable name 'at' is too short, expected at least 3 characters [readability-identifier-length,-warnings-as-errors]73 51 | auto const at = written_.load(std::memory_order_relaxed);74 | ^75../src/daemon/log-spill.hh:61:15: error: possibly unsafe 'operator[]', consider bounds-safe alternatives [cppcoreguidelines-pro-bounds-avoid-unchecked-container-access,-warnings-as-errors]76 61 | record[0] = static_cast<char>(kind);77 | ^~~78../src/daemon/log-spill.hh:63:35: error: do not use pointer arithmetic [cppcoreguidelines-pro-bounds-pointer-arithmetic,-warnings-as-errors]79 63 | std::memcpy(record.data() + 1, &len, sizeof len);80 | ^81../src/daemon/log-spill.hh:78:37: error: forwarding reference parameter 'fn' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward,-warnings-as-errors]82 78 | auto drain(size_t offset, Fn && fn) const -> size_t83 | ^84../src/daemon/log-spill.hh:78:37: error: parameter name 'fn' is too short, expected at least 3 characters [readability-identifier-length,-warnings-as-errors]85../src/daemon/log-spill.hh:81:20: error: variable name 'fd' is too short, expected at least 3 characters [readability-identifier-length,-warnings-as-errors]86 81 | auto const fd = fd_.load();87 | ^88../src/daemon/log-spill.hh:84:13: error: do not declare C-style arrays, use 'std::array' instead [cppcoreguidelines-avoid-c-arrays,modernize-avoid-c-arrays,-warnings-as-errors]89 84 | char header[kHeader];90 | ^~~~~~~~~~~~~~~~~~~~91../src/daemon/log-spill.hh:85:30: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]92 85 | if (!readAll(fd, header, kHeader, offset)) {93 | ^94../src/daemon/log-spill.hh:89:31: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]95 89 | std::memcpy(&len, header + 1, sizeof len);96 | ^97../src/daemon/log-spill.hh:89:38: error: do not use pointer arithmetic [cppcoreguidelines-pro-bounds-pointer-arithmetic,-warnings-as-errors]98 89 | std::memcpy(&len, header + 1, sizeof len);99 | ^100../src/daemon/log-spill.hh:110:28: error: function is not thread safe [concurrency-mt-unsafe,-warnings-as-errors]101 110 | auto const * env = std::getenv("TMPDIR");102 | ^103../src/daemon/log-spill.hh:112:14: error: variable name 'fd' is too short, expected at least 3 characters [readability-identifier-length,-warnings-as-errors]104 112 | auto fd = ::open(dir.c_str(), O_TMPFILE | O_RDWR | O_CLOEXEC, 0600);105 | ^106../src/daemon/log-spill.hh:112:39: error: use of undeclared identifier 'O_TMPFILE' [clang-diagnostic-error]107 112 | auto fd = ::open(dir.c_str(), O_TMPFILE | O_RDWR | O_CLOEXEC, 0600);108 | ^~~~~~~~~109../src/daemon/log-spill.hh:112:71: error: 0600 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers,-warnings-as-errors]110 112 | auto fd = ::open(dir.c_str(), O_TMPFILE | O_RDWR | O_CLOEXEC, 0600);111 | ^112../src/daemon/log-spill.hh:132:24: error: variable name 'n' is too short, expected at least 3 characters [readability-identifier-length,-warnings-as-errors]113 132 | auto const n = ::pwrite(fd_.load(), data.data() + done, data.size() - done, static_cast<off_t>(offset + done));114 | ^115../src/daemon/log-spill.hh:132:61: error: do not use pointer arithmetic [cppcoreguidelines-pro-bounds-pointer-arithmetic,-warnings-as-errors]116 132 | auto const n = ::pwrite(fd_.load(), data.data() + done, data.size() - done, static_cast<off_t>(offset + done));117 | ^118../src/daemon/log-spill.hh:132:89: error: either cast from 'size_t' (aka 'unsigned long') to 'off_t' (aka 'long long') is ineffective, or there is loss of precision before the conversion [bugprone-misplaced-widening-cast,-warnings-as-errors]119 132 | auto const n = ::pwrite(fd_.load(), data.data() + done, data.size() - done, static_cast<off_t>(offset + done));120 | ^121../src/daemon/log-spill.hh:144:29: error: parameter name 'fd' is too short, expected at least 3 characters [readability-identifier-length,-warnings-as-errors]122 144 | static auto readAll(int fd, char * buf, size_t len, size_t offset) -> bool123 | ^124../src/daemon/log-spill.hh:148:24: error: variable name 'n' is too short, expected at least 3 characters [readability-identifier-length,-warnings-as-errors]125 148 | auto const n = ::pread(fd, buf + done, len - done, static_cast<off_t>(offset + done));126 | ^127../src/daemon/log-spill.hh:148:44: error: do not use pointer arithmetic [cppcoreguidelines-pro-bounds-pointer-arithmetic,-warnings-as-errors]128 148 | auto const n = ::pread(fd, buf + done, len - done, static_cast<off_t>(offset + done));129 | ^130../src/daemon/log-spill.hh:148:64: error: either cast from 'size_t' (aka 'unsigned long') to 'off_t' (aka 'long long') is ineffective, or there is loss of precision before the conversion [bugprone-misplaced-widening-cast,-warnings-as-errors]131 148 | auto const n = ::pread(fd, buf + done, len - done, static_cast<off_t>(offset + done));132 | ^133../src/daemon/log-spill.hh:175:31: error: parameter name 'cv' is too short, expected at least 3 characters [readability-identifier-length,-warnings-as-errors]134 175 | std::condition_variable & cv,135 | ^136../src/daemon/log-spill.hh:178:18: error: forwarding reference parameter 'cancelled' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward,-warnings-as-errors]137 178 | Cancelled && cancelled,138 | ^139../src/daemon/log-spill.hh:179:13: error: forwarding reference parameter 'emit' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward,-warnings-as-errors]140 179 | Emit && emit) -> bool141 | ^142../src/daemon/log-spill.hh:195:16: error: 'wait_for' should be placed inside a while statement or used with a conditional parameter [bugprone-spuriously-wake-up-functions,cert-con36-c,cert-con54-cpp,-warnings-as-errors]143 195 | cv.wait_for(lock, poll);144 | ^145../tests/log-spill-test.cc:1:1: error: included header atomic is not used directly [misc-include-cleaner,-warnings-as-errors]146 1 | #include <atomic>147 | ^~~~~~~~~~~~~~~~~148 2 | #include <chrono>149../tests/log-spill-test.cc:16:13: error: function 'readAll' declared 'static', move to anonymous namespace instead [misc-use-anonymous-namespace,-warnings-as-errors]150 16 | static auto readAll(const LogSpill & spill) -> Records151 | ^152../tests/log-spill-test.cc:19:24: error: no header providing "uint8_t" is directly included [misc-include-cleaner,-warnings-as-errors]153 5 | #include <mutex>154 6 | #include <string>155 7 | #include <thread>156 8 | #include <utility>157 9 | #include <vector>158 10 | 159 11 | #include "log-spill.hh"160 12 | 161 13 | using nixgrpc::LogSpill;162 14 | using Records = std::vector<std::pair<int, std::string>>;163 15 | 164 16 | static auto readAll(const LogSpill & spill) -> Records165 17 | {166 18 | Records out;167 19 | spill.drain(0, [&](uint8_t kind, std::string_view text) -> void { out.emplace_back(kind, std::string(text)); });168 | ^169../tests/log-spill-test.cc:19:43: error: no header providing "std::string_view" is directly included [misc-include-cleaner,-warnings-as-errors]170 7 | #include <thread>171 8 | #include <utility>172 9 | #include <vector>173 10 | 174 11 | #include "log-spill.hh"175 12 | 176 13 | using nixgrpc::LogSpill;177 14 | using Records = std::vector<std::pair<int, std::string>>;178 15 | 179 16 | static auto readAll(const LogSpill & spill) -> Records180 17 | {181 18 | Records out;182 19 | spill.drain(0, [&](uint8_t kind, std::string_view text) -> void { out.emplace_back(kind, std::string(text)); });183 | ^184../tests/log-spill-test.cc:23:13: error: function 'follow' declared 'static', move to anonymous namespace instead [misc-use-anonymous-namespace,-warnings-as-errors]185 23 | static auto follow(LogSpill & spill, std::mutex & mutex, std::condition_variable & cv, const bool & finished) -> Records186 | ^187../tests/log-spill-test.cc:23:84: error: parameter name 'cv' is too short, expected at least 3 characters [readability-identifier-length,-warnings-as-errors]188 23 | static auto follow(LogSpill & spill, std::mutex & mutex, std::condition_variable & cv, const bool & finished) -> Records189 | ^190../tests/log-spill-test.cc:33:6: error: an exception may be thrown in function 'main' which should not throw exceptions [bugprone-exception-escape,-warnings-as-errors]191 33 | auto main() -> int192 | ^193/nix/store/9z187ss3liak3pngakax2ip7nb1dc7z5-libcxx-21.1.6+apple-sdk-26.5/include/c++/v1/stdexcept:256:3: note: frame #0: unhandled exception of type 'out_of_range' may be thrown in function '__throw_out_of_range' here194 256 | throw out_of_range(__msg);195 | ^196/nix/store/9z187ss3liak3pngakax2ip7nb1dc7z5-libcxx-21.1.6+apple-sdk-26.5/include/c++/v1/string_view:464:30: note: frame #1: function 'substr' calls function '__throw_out_of_range' here197 464 | return __pos > size() ? (__throw_out_of_range("string_view::substr"), basic_string_view())198 | ^199../src/daemon/log-spill.hh:50:16: note: frame #2: function 'append' calls function 'substr' here200 50 | text = text.substr(0, kMaxText);201 | ^202../tests/log-spill-test.cc:38:9: note: frame #3: function 'main' calls function 'append' here203 38 | spill.append(0, "first");204 | ^205../tests/log-spill-test.cc:41:37: error: 300000 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers,-warnings-as-errors]206 41 | spill.append(0, std::string(300000, 'x'));207 | ^208../tests/log-spill-test.cc:44:19: error: possibly unsafe 'operator[]', consider bounds-safe alternatives [cppcoreguidelines-pro-bounds-avoid-unchecked-container-access,-warnings-as-errors]209 44 | assert(got[0] == std::make_pair(0, std::string("first")));210 | ^211/nix/store/rq88pmfxfl98jhzfhb46jvl0rl8nyd6g-apple-sdk-14.4/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/assert.h:99:25: note: expanded from macro 'assert'212 99 | (__builtin_expect(!(e), 0) ? __assert_rtn(__func__, __ASSERT_FILE_NAME, __LINE__, #e) : (void)0)213 | ^214../tests/log-spill-test.cc:45:19: error: possibly unsafe 'operator[]', consider bounds-safe alternatives [cppcoreguidelines-pro-bounds-avoid-unchecked-container-access,-warnings-as-errors]215 45 | assert(got[1] == std::make_pair(1, std::string("build")));216 | ^217/nix/store/rq88pmfxfl98jhzfhb46jvl0rl8nyd6g-apple-sdk-14.4/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/assert.h:99:25: note: expanded from macro 'assert'218 99 | (__builtin_expect(!(e), 0) ? __assert_rtn(__func__, __ASSERT_FILE_NAME, __LINE__, #e) : (void)0)219 | ^220../tests/log-spill-test.cc:46:19: error: possibly unsafe 'operator[]', consider bounds-safe alternatives [cppcoreguidelines-pro-bounds-avoid-unchecked-container-access,-warnings-as-errors]221 46 | assert(got[2].second.empty());222 | ^223/nix/store/rq88pmfxfl98jhzfhb46jvl0rl8nyd6g-apple-sdk-14.4/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/assert.h:99:25: note: expanded from macro 'assert'224 99 | (__builtin_expect(!(e), 0) ? __assert_rtn(__func__, __ASSERT_FILE_NAME, __LINE__, #e) : (void)0)225 | ^226../tests/log-spill-test.cc:47:19: error: possibly unsafe 'operator[]', consider bounds-safe alternatives [cppcoreguidelines-pro-bounds-avoid-unchecked-container-access,-warnings-as-errors]227 47 | assert(got[3].second.size() == 300000);228 | ^229/nix/store/rq88pmfxfl98jhzfhb46jvl0rl8nyd6g-apple-sdk-14.4/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/assert.h:99:25: note: expanded from macro 'assert'230 99 | (__builtin_expect(!(e), 0) ? __assert_rtn(__func__, __ASSERT_FILE_NAME, __LINE__, #e) : (void)0)231 | ^232../tests/log-spill-test.cc:54:40: error: possibly unsafe 'operator[]', consider bounds-safe alternatives [cppcoreguidelines-pro-bounds-avoid-unchecked-container-access,-warnings-as-errors]233 54 | assert(rest.size() == 1 && rest[0].second == "later");234 | ^235/nix/store/rq88pmfxfl98jhzfhb46jvl0rl8nyd6g-apple-sdk-14.4/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/assert.h:99:25: note: expanded from macro 'assert'236 99 | (__builtin_expect(!(e), 0) ? __assert_rtn(__func__, __ASSERT_FILE_NAME, __LINE__, #e) : (void)0)237 | ^238../tests/log-spill-test.cc:59:24: error: 64 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers,-warnings-as-errors]239 59 | LogSpill spill(64);240 | ^241../tests/log-spill-test.cc:60:29: error: 50 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers,-warnings-as-errors]242 60 | for (int i = 0; i < 50; i++) {243 | ^244../tests/log-spill-test.cc:75:33: error: variable name 'cv' is too short, expected at least 3 characters [readability-identifier-length,-warnings-as-errors]245 75 | std::condition_variable cv;246 | ^247../tests/log-spill-test.cc:80:21: error: variable name 't1' is too short, expected at least 3 characters [readability-identifier-length,-warnings-as-errors]248 80 | std::thread t1([&] { early = follow(spill, mutex, cv, finished); });249 | ^250../tests/log-spill-test.cc:80:24: error: use a trailing return type for this lambda [modernize-use-trailing-return-type,-warnings-as-errors]251 80 | std::thread t1([&] { early = follow(spill, mutex, cv, finished); });252 | ^253 | -> void254../tests/log-spill-test.cc:81:27: error: use a trailing return type for this lambda [modernize-use-trailing-return-type,-warnings-as-errors]255 81 | std::thread owner([&] {256 | ^257 | -> void258../tests/log-spill-test.cc:91:34: error: 1000 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers,-warnings-as-errors]259 91 | while (spill.written() < 1000) {260 | ^261../tests/log-spill-test.cc:94:21: error: variable name 't2' is too short, expected at least 3 characters [readability-identifier-length,-warnings-as-errors]262 94 | std::thread t2([&] { late = follow(spill, mutex, cv, finished); });263 | ^264../tests/log-spill-test.cc:94:24: error: use a trailing return type for this lambda [modernize-use-trailing-return-type,-warnings-as-errors]265 94 | std::thread t2([&] { late = follow(spill, mutex, cv, finished); });266 | ^267 | -> void268../tests/log-spill-test.cc:101:30: error: possibly unsafe 'operator[]', consider bounds-safe alternatives [cppcoreguidelines-pro-bounds-avoid-unchecked-container-access,-warnings-as-errors]269 101 | assert((*got)[static_cast<size_t>(i)].second == "line " + std::to_string(i));270 | ^271/nix/store/rq88pmfxfl98jhzfhb46jvl0rl8nyd6g-apple-sdk-14.4/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/assert.h:99:25: note: expanded from macro 'assert'272 99 | (__builtin_expect(!(e), 0) ? __assert_rtn(__func__, __ASSERT_FILE_NAME, __LINE__, #e) : (void)0)273 | ^274../tests/log-spill-test.cc:101:43: error: no header providing "size_t" is directly included [misc-include-cleaner,-warnings-as-errors]275 5 | assert((*got)[static_cast<size_t>(i)].second == "line " + std::to_string(i));276 | ^277../tests/log-spill-test.cc:110:33: error: variable name 'cv' is too short, expected at least 3 characters [readability-identifier-length,-warnings-as-errors]278 110 | std::condition_variable cv;279 | ^280>>> /nix/store/l8sbl3yky84xqxj3a5hazrjdx52avnf2-clang-tools-22.1.8/bin/clang-tidy --use-color -quiet -p /nix/var/nix/builds/nix-46934-3544683814/source/build /nix/var/nix/builds/nix-46934-3544683814/source/src/client/channel.cc281[1/1] (1/2) Processing file /nix/var/nix/builds/nix-46934-3544683814/source/src/client/channel.cc.282[1/1] (2/2) Processing file /nix/var/nix/builds/nix-46934-3544683814/source/src/client/channel.cc.283>>> /nix/store/l8sbl3yky84xqxj3a5hazrjdx52avnf2-clang-tools-22.1.8/bin/clang-tidy --use-color -quiet -p /nix/var/nix/builds/nix-46934-3544683814/source/build /nix/var/nix/builds/nix-46934-3544683814/source/src/daemon/main.cc284Error while processing /nix/var/nix/builds/nix-46934-3544683814/source/src/daemon/main.cc.285../src/daemon/log-spill.hh:25:7: error: class 'LogSpill' defines a non-default destructor, a copy constructor and a copy assignment operator but does not define a move constructor or a move assignment operator [cppcoreguidelines-special-member-functions,-warnings-as-errors]286 25 | class LogSpill287 | ^288../src/daemon/log-spill.hh:38:24: error: variable name 'fd' is too short, expected at least 3 characters [readability-identifier-length,-warnings-as-errors]289 38 | if (auto const fd = fd_.load(); fd >= 0) {290 | ^291../src/daemon/log-spill.hh:51:20: error: variable name 'at' is too short, expected at least 3 characters [readability-identifier-length,-warnings-as-errors]292 51 | auto const at = written_.load(std::memory_order_relaxed);293 | ^294../src/daemon/log-spill.hh:61:15: error: possibly unsafe 'operator[]', consider bounds-safe alternatives [cppcoreguidelines-pro-bounds-avoid-unchecked-container-access,-warnings-as-errors]295 61 | record[0] = static_cast<char>(kind);296 | ^~~297../src/daemon/log-spill.hh:63:35: error: do not use pointer arithmetic [cppcoreguidelines-pro-bounds-pointer-arithmetic,-warnings-as-errors]298 63 | std::memcpy(record.data() + 1, &len, sizeof len);299 | ^300../src/daemon/log-spill.hh:78:37: error: forwarding reference parameter 'fn' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward,-warnings-as-errors]301 78 | auto drain(size_t offset, Fn && fn) const -> size_t302 | ^303../src/daemon/log-spill.hh:78:37: error: parameter name 'fn' is too short, expected at least 3 characters [readability-identifier-length,-warnings-as-errors]304../src/daemon/log-spill.hh:81:20: error: variable name 'fd' is too short, expected at least 3 characters [readability-identifier-length,-warnings-as-errors]305 81 | auto const fd = fd_.load();306 | ^307../src/daemon/log-spill.hh:84:13: error: do not declare C-style arrays, use 'std::array' instead [cppcoreguidelines-avoid-c-arrays,modernize-avoid-c-arrays,-warnings-as-errors]308 84 | char header[kHeader];309 | ^~~~~~~~~~~~~~~~~~~~310../src/daemon/log-spill.hh:85:30: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]311 85 | if (!readAll(fd, header, kHeader, offset)) {312 | ^313../src/daemon/log-spill.hh:89:31: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]314 89 | std::memcpy(&len, header + 1, sizeof len);315 | ^316../src/daemon/log-spill.hh:89:38: error: do not use pointer arithmetic [cppcoreguidelines-pro-bounds-pointer-arithmetic,-warnings-as-errors]317 89 | std::memcpy(&len, header + 1, sizeof len);318 | ^319../src/daemon/log-spill.hh:110:28: error: function is not thread safe [concurrency-mt-unsafe,-warnings-as-errors]320 110 | auto const * env = std::getenv("TMPDIR");321 | ^322../src/daemon/log-spill.hh:112:14: error: variable name 'fd' is too short, expected at least 3 characters [readability-identifier-length,-warnings-as-errors]323 112 | auto fd = ::open(dir.c_str(), O_TMPFILE | O_RDWR | O_CLOEXEC, 0600);324 | ^325../src/daemon/log-spill.hh:112:39: error: use of undeclared identifier 'O_TMPFILE' [clang-diagnostic-error]326 112 | auto fd = ::open(dir.c_str(), O_TMPFILE | O_RDWR | O_CLOEXEC, 0600);327 | ^~~~~~~~~328../src/daemon/log-spill.hh:112:71: error: 0600 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers,-warnings-as-errors]329 112 | auto fd = ::open(dir.c_str(), O_TMPFILE | O_RDWR | O_CLOEXEC, 0600);330 | ^331../src/daemon/log-spill.hh:132:24: error: variable name 'n' is too short, expected at least 3 characters [readability-identifier-length,-warnings-as-errors]332 132 | auto const n = ::pwrite(fd_.load(), data.data() + done, data.size() - done, static_cast<off_t>(offset + done));333 | ^334../src/daemon/log-spill.hh:132:61: error: do not use pointer arithmetic [cppcoreguidelines-pro-bounds-pointer-arithmetic,-warnings-as-errors]335 132 | auto const n = ::pwrite(fd_.load(), data.data() + done, data.size() - done, static_cast<off_t>(offset + done));336 | ^337../src/daemon/log-spill.hh:132:89: error: either cast from 'size_t' (aka 'unsigned long') to 'off_t' (aka 'long long') is ineffective, or there is loss of precision before the conversion [bugprone-misplaced-widening-cast,-warnings-as-errors]338 132 | auto const n = ::pwrite(fd_.load(), data.data() + done, data.size() - done, static_cast<off_t>(offset + done));339 | ^340../src/daemon/log-spill.hh:144:29: error: parameter name 'fd' is too short, expected at least 3 characters [readability-identifier-length,-warnings-as-errors]341 144 | static auto readAll(int fd, char * buf, size_t len, size_t offset) -> bool342 | ^343../src/daemon/log-spill.hh:148:24: error: variable name 'n' is too short, expected at least 3 characters [readability-identifier-length,-warnings-as-errors]344 148 | auto const n = ::pread(fd, buf + done, len - done, static_cast<off_t>(offset + done));345 | ^346../src/daemon/log-spill.hh:148:44: error: do not use pointer arithmetic [cppcoreguidelines-pro-bounds-pointer-arithmetic,-warnings-as-errors]347 148 | auto const n = ::pread(fd, buf + done, len - done, static_cast<off_t>(offset + done));348 | ^349../src/daemon/log-spill.hh:148:64: error: either cast from 'size_t' (aka 'unsigned long') to 'off_t' (aka 'long long') is ineffective, or there is loss of precision before the conversion [bugprone-misplaced-widening-cast,-warnings-as-errors]350 148 | auto const n = ::pread(fd, buf + done, len - done, static_cast<off_t>(offset + done));351 | ^352../src/daemon/log-spill.hh:175:31: error: parameter name 'cv' is too short, expected at least 3 characters [readability-identifier-length,-warnings-as-errors]353 175 | std::condition_variable & cv,354 | ^355../src/daemon/log-spill.hh:178:18: error: forwarding reference parameter 'cancelled' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward,-warnings-as-errors]356 178 | Cancelled && cancelled,357 | ^358../src/daemon/log-spill.hh:179:13: error: forwarding reference parameter 'emit' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward,-warnings-as-errors]359 179 | Emit && emit) -> bool360 | ^361../src/daemon/log-spill.hh:195:16: error: 'wait_for' should be placed inside a while statement or used with a conditional parameter [bugprone-spuriously-wake-up-functions,cert-con36-c,cert-con54-cpp,-warnings-as-errors]362 195 | cv.wait_for(lock, poll);363 | ^364../src/daemon/main.cc:504:41: error: no header providing "nixgrpc::followSpill" is directly included [misc-include-cleaner,-warnings-as-errors]365 71 | auto const completed = nixgrpc::followSpill(366 | ^367>>> /nix/store/l8sbl3yky84xqxj3a5hazrjdx52avnf2-clang-tools-22.1.8/bin/clang-tidy --use-color -quiet -p /nix/var/nix/builds/nix-46934-3544683814/source/build /nix/var/nix/builds/nix-46934-3544683814/source/src/daemon/coordinator.cc368Errors encountered while running clang-tidy369Error while processing /nix/var/nix/builds/nix-46934-3544683814/source/src/daemon/coordinator.cc.370../src/daemon/log-spill.hh:25:7: error: class 'LogSpill' defines a non-default destructor, a copy constructor and a copy assignment operator but does not define a move constructor or a move assignment operator [cppcoreguidelines-special-member-functions,-warnings-as-errors]371 25 | class LogSpill372 | ^373../src/daemon/log-spill.hh:38:24: error: variable name 'fd' is too short, expected at least 3 characters [readability-identifier-length,-warnings-as-errors]374 38 | if (auto const fd = fd_.load(); fd >= 0) {375 | ^376../src/daemon/log-spill.hh:51:20: error: variable name 'at' is too short, expected at least 3 characters [readability-identifier-length,-warnings-as-errors]377 51 | auto const at = written_.load(std::memory_order_relaxed);378 | ^379../src/daemon/log-spill.hh:61:15: error: possibly unsafe 'operator[]', consider bounds-safe alternatives [cppcoreguidelines-pro-bounds-avoid-unchecked-container-access,-warnings-as-errors]380 61 | record[0] = static_cast<char>(kind);381 | ^~~382../src/daemon/log-spill.hh:63:35: error: do not use pointer arithmetic [cppcoreguidelines-pro-bounds-pointer-arithmetic,-warnings-as-errors]383 63 | std::memcpy(record.data() + 1, &len, sizeof len);384 | ^385../src/daemon/log-spill.hh:78:37: error: forwarding reference parameter 'fn' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward,-warnings-as-errors]386 78 | auto drain(size_t offset, Fn && fn) const -> size_t387 | ^388../src/daemon/log-spill.hh:78:37: error: parameter name 'fn' is too short, expected at least 3 characters [readability-identifier-length,-warnings-as-errors]389../src/daemon/log-spill.hh:81:20: error: variable name 'fd' is too short, expected at least 3 characters [readability-identifier-length,-warnings-as-errors]390 81 | auto const fd = fd_.load();391 | ^392../src/daemon/log-spill.hh:84:13: error: do not declare C-style arrays, use 'std::array' instead [cppcoreguidelines-avoid-c-arrays,modernize-avoid-c-arrays,-warnings-as-errors]393 84 | char header[kHeader];394 | ^~~~~~~~~~~~~~~~~~~~395../src/daemon/log-spill.hh:85:30: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]396 85 | if (!readAll(fd, header, kHeader, offset)) {397 | ^398../src/daemon/log-spill.hh:89:31: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]399 89 | std::memcpy(&len, header + 1, sizeof len);400 | ^401../src/daemon/log-spill.hh:89:38: error: do not use pointer arithmetic [cppcoreguidelines-pro-bounds-pointer-arithmetic,-warnings-as-errors]402 89 | std::memcpy(&len, header + 1, sizeof len);403 | ^404../src/daemon/log-spill.hh:110:28: error: function is not thread safe [concurrency-mt-unsafe,-warnings-as-errors]405 110 | auto const * env = std::getenv("TMPDIR");406 | ^407../src/daemon/log-spill.hh:112:14: error: variable name 'fd' is too short, expected at least 3 characters [readability-identifier-length,-warnings-as-errors]408 112 | auto fd = ::open(dir.c_str(), O_TMPFILE | O_RDWR | O_CLOEXEC, 0600);409 | ^410../src/daemon/log-spill.hh:112:39: error: use of undeclared identifier 'O_TMPFILE' [clang-diagnostic-error]411 112 | auto fd = ::open(dir.c_str(), O_TMPFILE | O_RDWR | O_CLOEXEC, 0600);412 | ^~~~~~~~~413../src/daemon/log-spill.hh:112:71: error: 0600 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers,-warnings-as-errors]414 112 | auto fd = ::open(dir.c_str(), O_TMPFILE | O_RDWR | O_CLOEXEC, 0600);415 | ^416../src/daemon/log-spill.hh:132:24: error: variable name 'n' is too short, expected at least 3 characters [readability-identifier-length,-warnings-as-errors]417 132 | auto const n = ::pwrite(fd_.load(), data.data() + done, data.size() - done, static_cast<off_t>(offset + done));418 | ^419../src/daemon/log-spill.hh:132:61: error: do not use pointer arithmetic [cppcoreguidelines-pro-bounds-pointer-arithmetic,-warnings-as-errors]420 132 | auto const n = ::pwrite(fd_.load(), data.data() + done, data.size() - done, static_cast<off_t>(offset + done));421 | ^422../src/daemon/log-spill.hh:132:89: error: either cast from 'size_t' (aka 'unsigned long') to 'off_t' (aka 'long long') is ineffective, or there is loss of precision before the conversion [bugprone-misplaced-widening-cast,-warnings-as-errors]423 132 | auto const n = ::pwrite(fd_.load(), data.data() + done, data.size() - done, static_cast<off_t>(offset + done));424 | ^425../src/daemon/log-spill.hh:144:29: error: parameter name 'fd' is too short, expected at least 3 characters [readability-identifier-length,-warnings-as-errors]426 144 | static auto readAll(int fd, char * buf, size_t len, size_t offset) -> bool427 | ^428../src/daemon/log-spill.hh:148:24: error: variable name 'n' is too short, expected at least 3 characters [readability-identifier-length,-warnings-as-errors]429 148 | auto const n = ::pread(fd, buf + done, len - done, static_cast<off_t>(offset + done));430 | ^431../src/daemon/log-spill.hh:148:44: error: do not use pointer arithmetic [cppcoreguidelines-pro-bounds-pointer-arithmetic,-warnings-as-errors]432 148 | auto const n = ::pread(fd, buf + done, len - done, static_cast<off_t>(offset + done));433 | ^434../src/daemon/log-spill.hh:148:64: error: either cast from 'size_t' (aka 'unsigned long') to 'off_t' (aka 'long long') is ineffective, or there is loss of precision before the conversion [bugprone-misplaced-widening-cast,-warnings-as-errors]435 148 | auto const n = ::pread(fd, buf + done, len - done, static_cast<off_t>(offset + done));436 | ^437../src/daemon/log-spill.hh:175:31: error: parameter name 'cv' is too short, expected at least 3 characters [readability-identifier-length,-warnings-as-errors]438 175 | std::condition_variable & cv,439 | ^440../src/daemon/log-spill.hh:178:18: error: forwarding reference parameter 'cancelled' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward,-warnings-as-errors]441 178 | Cancelled && cancelled,442 | ^443../src/daemon/log-spill.hh:179:13: error: forwarding reference parameter 'emit' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward,-warnings-as-errors]444 179 | Emit && emit) -> bool445 | ^446../src/daemon/log-spill.hh:195:16: error: 'wait_for' should be placed inside a while statement or used with a conditional parameter [bugprone-spuriously-wake-up-functions,cert-con36-c,cert-con54-cpp,-warnings-as-errors]447 195 | cv.wait_for(lock, poll);448 | ^449FAILED: [code=1] meson-internal__clang-tidy 450/nix/store/j2s018h6gc2q0z3sw002br2zas3m1l9d-meson-1.10.2/bin/meson --internal clangtidy /nix/var/nix/builds/nix-46934-3544683814/source /nix/var/nix/builds/nix-46934-3544683814/source/build --color always451ninja: build stopped: subcommand failed.