nix-grpc-store-clang-tidy-0.1.0-beta.4
checks.aarch64-darwin.clang-tidy
· build #559
· raw
unpackPhase
1unpacking source archive /nix/store/bxwih2dxlpmglg1ppazbgqvnz69hibm3-source2source root is sourceconfigurePhase
3mesonConfigurePhase flags: --prefix=/nix/store/0srgypjd6k2y5bzgpdhr78bmll4l0jpn-nix-grpc-store-clang-tidy-0.1.0-beta.4 --libdir=/nix/store/0srgypjd6k2y5bzgpdhr78bmll4l0jpn-nix-grpc-store-clang-tidy-0.1.0-beta.4/lib --libexecdir=/nix/store/0srgypjd6k2y5bzgpdhr78bmll4l0jpn-nix-grpc-store-clang-tidy-0.1.0-beta.4/libexec --bindir=/nix/store/0srgypjd6k2y5bzgpdhr78bmll4l0jpn-nix-grpc-store-clang-tidy-0.1.0-beta.4/bin --sbindir=/nix/store/0srgypjd6k2y5bzgpdhr78bmll4l0jpn-nix-grpc-store-clang-tidy-0.1.0-beta.4/sbin --includedir=/nix/store/0srgypjd6k2y5bzgpdhr78bmll4l0jpn-nix-grpc-store-clang-tidy-0.1.0-beta.4/include --mandir=/nix/store/0srgypjd6k2y5bzgpdhr78bmll4l0jpn-nix-grpc-store-clang-tidy-0.1.0-beta.4/share/man --infodir=/nix/store/0srgypjd6k2y5bzgpdhr78bmll4l0jpn-nix-grpc-store-clang-tidy-0.1.0-beta.4/share/info --localedir=/nix/store/0srgypjd6k2y5bzgpdhr78bmll4l0jpn-nix-grpc-store-clang-tidy-0.1.0-beta.4/share/locale -Dauto_features=enabled -Dwrap_mode=nodownload --buildtype=plain -Db_pch=false4The Meson build system5Version: 1.10.26Source dir: /nix/var/nix/builds/nix-50839-4061795475/source7Build dir: /nix/var/nix/builds/nix-50839-4061795475/source/build8Build type: native build9WARNING: Project does not target a minimum version but uses feature introduced in '1.1': meson.options file. Use meson_options.txt instead10Project name: nix-grpc-store11Project version: 0.1.0-beta.412C++ compiler for the host machine: clang++ (clang 22.1.8 "clang version 22.1.8")13C++ linker for the host machine: clang++ ld64 956.614Host machine cpu family: aarch6415Host machine cpu: aarch6416Found pkg-config: YES (/nix/store/kd2x1bj3gwfh2hb69fk5ym043h2qavxc-pkg-config-wrapper-0.29.2/bin/pkg-config) 0.29.217Run-time dependency grpc++ found: YES 1.83.018Run-time dependency protobuf found: YES 36.1.019Run-time dependency libzstd found: YES 1.5.720Run-time dependency threads found: YES21Run-time dependency libcrypto found: YES 3.6.422Run-time dependency prometheus-cpp-core found: YES 1.3.023Run-time dependency prometheus-cpp-pull found: YES 1.3.024Run-time dependency absl_flat_hash_map found: YES 2026010725Run-time dependency absl_hash found: YES 2026010726Run-time dependency absl_synchronization found: YES 2026010727Compiler for C++ supports arguments -Werror=thread-safety: YES 28Run-time dependency jemalloc found: YES 5.3.1_029Run-time dependency nix-store found: YES 2.36.0pre20260920_5711f8fe30Run-time dependency nix-util found: YES 2.36.0pre20260920_5711f8fe31Run-time dependency libcurl found: YES 8.22.032Run-time dependency nlohmann_json found: YES 3.12.033Check usable header "jwt-cpp/traits/nlohmann-json/defaults.h" : YES 34Program protoc found: YES (/nix/store/r1npr0vx8d17c0fhh9gvg9mpaiphn62a-protobuf-36.1/bin/protoc)35Program grpc_cpp_plugin found: YES (/nix/store/0mm81ldgq4ssz7gnh8589gx9zfcxpdhq-grpc-1.83.0/bin/grpc_cpp_plugin)36Run-time dependency dl found: YES37Program tests/farm-client-test.sh found: YES (/nix/var/nix/builds/nix-50839-4061795475/source/tests/farm-client-test.sh)38Program tests/oidc-test.sh found: YES (/nix/var/nix/builds/nix-50839-4061795475/source/tests/oidc-test.sh)39Build targets in project: 1340WARNING: Project specifies no minimum version but uses features which were added in versions:41 * 1.1: {'meson.options file'}4243nix-grpc-store 0.1.0-beta.44445 User defined options46 auto_features: enabled47 b_pch : false48 bindir : /nix/store/0srgypjd6k2y5bzgpdhr78bmll4l0jpn-nix-grpc-store-clang-tidy-0.1.0-beta.4/bin49 buildtype : plain50 includedir : /nix/store/0srgypjd6k2y5bzgpdhr78bmll4l0jpn-nix-grpc-store-clang-tidy-0.1.0-beta.4/include51 infodir : /nix/store/0srgypjd6k2y5bzgpdhr78bmll4l0jpn-nix-grpc-store-clang-tidy-0.1.0-beta.4/share/info52 libdir : /nix/store/0srgypjd6k2y5bzgpdhr78bmll4l0jpn-nix-grpc-store-clang-tidy-0.1.0-beta.4/lib53 libexecdir : /nix/store/0srgypjd6k2y5bzgpdhr78bmll4l0jpn-nix-grpc-store-clang-tidy-0.1.0-beta.4/libexec54 localedir : /nix/store/0srgypjd6k2y5bzgpdhr78bmll4l0jpn-nix-grpc-store-clang-tidy-0.1.0-beta.4/share/locale55 mandir : /nix/store/0srgypjd6k2y5bzgpdhr78bmll4l0jpn-nix-grpc-store-clang-tidy-0.1.0-beta.4/share/man56 prefix : /nix/store/0srgypjd6k2y5bzgpdhr78bmll4l0jpn-nix-grpc-store-clang-tidy-0.1.0-beta.457 sbindir : /nix/store/0srgypjd6k2y5bzgpdhr78bmll4l0jpn-nix-grpc-store-clang-tidy-0.1.0-beta.4/sbin58 wrap_mode : nodownload5960Found ninja-1.13.2 at /nix/store/kalf64hrn0zrxlacfvgymwbck77qvsr9-ninja-1.13.2/bin/ninja61mesonConfigurePhase: enabled\ parallel\ buildingbuildPhase
62[2/2] Generating nix_remote_proto with a custom command63[0/1] /nix/store/j2s018h6gc2q0z3sw002br2zas3m1l9d-meson-1.10.2/bin/meson --internal clangtidy /nix/var/nix/builds/nix-50839-4061795475/source /nix/var/nix/builds/nix-50839-4061795475/source/build --color always64>>> /nix/store/l8sbl3yky84xqxj3a5hazrjdx52avnf2-clang-tools-22.1.8/bin/clang-tidy --use-color -quiet -p /nix/var/nix/builds/nix-50839-4061795475/source/build /nix/var/nix/builds/nix-50839-4061795475/source/src/daemon/coordinator.cc65Error while processing /nix/var/nix/builds/nix-50839-4061795475/source/src/daemon/coordinator.cc.66../src/daemon/log-spill.hh:38:27: error: parameter name 'fd' is too short, expected at least 3 characters [readability-identifier-length,-warnings-as-errors]67 38 | explicit UniqueFd(int fd) noexcept : fd_(fd) {}68 | ^69../src/daemon/log-spill.hh:85:20: error: variable name 'at' is too short, expected at least 3 characters [readability-identifier-length,-warnings-as-errors]70 85 | auto const at = written_.load(std::memory_order_relaxed);71 | ^72../src/daemon/log-spill.hh:100:80: error: possibly unsafe 'operator[]', consider bounds-safe alternatives [cppcoreguidelines-pro-bounds-avoid-unchecked-container-access,-warnings-as-errors]73 100 | std::array<std::byte, kHeader> header{static_cast<std::byte>(kind), len[0], len[1], len[2], len[3]};74 | ^~~75../src/daemon/log-spill.hh:100:88: error: possibly unsafe 'operator[]', consider bounds-safe alternatives [cppcoreguidelines-pro-bounds-avoid-unchecked-container-access,-warnings-as-errors]76 100 | std::array<std::byte, kHeader> header{static_cast<std::byte>(kind), len[0], len[1], len[2], len[3]};77 | ^~~78../src/daemon/log-spill.hh:100:96: error: possibly unsafe 'operator[]', consider bounds-safe alternatives [cppcoreguidelines-pro-bounds-avoid-unchecked-container-access,-warnings-as-errors]79 100 | std::array<std::byte, kHeader> header{static_cast<std::byte>(kind), len[0], len[1], len[2], len[3]};80 | ^~~81../src/daemon/log-spill.hh:100:104: error: possibly unsafe 'operator[]', consider bounds-safe alternatives [cppcoreguidelines-pro-bounds-avoid-unchecked-container-access,-warnings-as-errors]82 100 | std::array<std::byte, kHeader> header{static_cast<std::byte>(kind), len[0], len[1], len[2], len[3]};83 | ^~~84../src/daemon/log-spill.hh:116:42: error: forwarding reference parameter 'fn' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward,-warnings-as-errors]85 116 | auto drain(std::size_t offset, Fn && fn) const -> std::size_t86 | ^87../src/daemon/log-spill.hh:116:42: error: parameter name 'fn' is too short, expected at least 3 characters [readability-identifier-length,-warnings-as-errors]88../src/daemon/log-spill.hh:128:67: error: possibly unsafe 'operator[]', consider bounds-safe alternatives [cppcoreguidelines-pro-bounds-avoid-unchecked-container-access,-warnings-as-errors]89 128 | auto const kind = std::to_integer<std::uint8_t>(header[0]);90 | ^~~91../src/daemon/log-spill.hh:149:25: error: variable name 'ec' is too short, expected at least 3 characters [readability-identifier-length,-warnings-as-errors]92 149 | std::error_code ec;93 | ^94../src/daemon/log-spill.hh:154:22: error: variable name 'fd' is too short, expected at least 3 characters [readability-identifier-length,-warnings-as-errors]95 154 | if (UniqueFd fd(::open(dir.c_str(), O_TMPFILE | O_RDWR | O_CLOEXEC, 0600)); fd) {96 | ^97../src/daemon/log-spill.hh:154:45: error: use of undeclared identifier 'O_TMPFILE' [clang-diagnostic-error]98 154 | if (UniqueFd fd(::open(dir.c_str(), O_TMPFILE | O_RDWR | O_CLOEXEC, 0600)); fd) {99 | ^~~~~~~~~100../src/daemon/log-spill.hh:154:77: error: 0600 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers,-warnings-as-errors]101 154 | if (UniqueFd fd(::open(dir.c_str(), O_TMPFILE | O_RDWR | O_CLOEXEC, 0600)); fd) {102 | ^103../src/daemon/log-spill.hh:155:20: error: no viable conversion from returned value of type 'UniqueFd' to function return type 'std::expected<UniqueFd, std::error_code>' [clang-diagnostic-error]104 155 | return fd;105 | ^~106/nix/store/9z187ss3liak3pngakax2ip7nb1dc7z5-libcxx-21.1.6+apple-sdk-26.5/include/c++/v1/__expected/expected.h:486:35: note: candidate constructor not viable: no known conversion from 'UniqueFd' to 'const expected<nixgrpc::UniqueFd, std::error_code> &' for 1st argument107 486 | _LIBCPP_HIDE_FROM_ABI constexpr expected(const expected&) = delete;108 | ^ ~~~~~~~~~~~~~~~109/nix/store/9z187ss3liak3pngakax2ip7nb1dc7z5-libcxx-21.1.6+apple-sdk-26.5/include/c++/v1/__expected/expected.h:504:35: note: candidate constructor not viable: no known conversion from 'UniqueFd' to 'expected<nixgrpc::UniqueFd, std::error_code> &&' for 1st argument110 504 | _LIBCPP_HIDE_FROM_ABI constexpr expected(expected&& __other) noexcept(111 | ^ ~~~~~~~~~~~~~~~~~~112/nix/store/9z187ss3liak3pngakax2ip7nb1dc7z5-libcxx-21.1.6+apple-sdk-26.5/include/c++/v1/__expected/expected.h:546:7: note: candidate template ignored: could not match 'expected<_Up, _OtherErr>' against 'UniqueFd'113 546 | expected(const expected<_Up, _OtherErr>& __other) noexcept(114 | ^115/nix/store/9z187ss3liak3pngakax2ip7nb1dc7z5-libcxx-21.1.6+apple-sdk-26.5/include/c++/v1/__expected/expected.h:554:7: note: candidate template ignored: could not match 'expected<_Up, _OtherErr>' against 'UniqueFd'116 554 | expected(expected<_Up, _OtherErr>&& __other) noexcept(117 | ^118/nix/store/9z187ss3liak3pngakax2ip7nb1dc7z5-libcxx-21.1.6+apple-sdk-26.5/include/c++/v1/__expected/expected.h:563:7: note: candidate template ignored: constraints not satisfied [with _Up = UniqueFd &]119 563 | expected(_Up&& __u) noexcept(is_nothrow_constructible_v<_Tp, _Up>) // strengthened120 | ^121/nix/store/9z187ss3liak3pngakax2ip7nb1dc7z5-libcxx-21.1.6+apple-sdk-26.5/include/c++/v1/__expected/expected.h:560:14: note: because 'is_constructible_v<nixgrpc::UniqueFd, nixgrpc::UniqueFd &>' evaluated to false122 560 | is_constructible_v<_Tp, _Up> && !__is_std_unexpected<remove_cvref_t<_Up>>::value &&123 | ^124../src/daemon/log-spill.hh:158:18: error: variable name 'fd' is too short, expected at least 3 characters [readability-identifier-length,-warnings-as-errors]125 158 | UniqueFd fd(::mkostemp(name.data(), O_CLOEXEC));126 | ^127../src/daemon/log-spill.hh:169:24: error: variable name 'n' is too short, expected at least 3 characters [readability-identifier-length,-warnings-as-errors]128 169 | auto const n = ::pwrite(fd_.get(), data.data(), data.size(), static_cast<off_t>(offset));129 | ^130../src/daemon/log-spill.hh:185:24: error: variable name 'n' is too short, expected at least 3 characters [readability-identifier-length,-warnings-as-errors]131 185 | auto const n = ::pread(fd_.get(), out.data(), out.size(), static_cast<off_t>(offset));132 | ^133../src/daemon/log-spill.hh:212:31: error: parameter name 'cv' is too short, expected at least 3 characters [readability-identifier-length,-warnings-as-errors]134 212 | std::condition_variable & cv,135 | ^136../src/daemon/log-spill.hh:215:18: error: forwarding reference parameter 'cancelled' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward,-warnings-as-errors]137 215 | Cancelled && cancelled,138 | ^139../src/daemon/log-spill.hh:216:13: error: forwarding reference parameter 'emit' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward,-warnings-as-errors]140 216 | Emit && emit) -> bool141 | ^142../src/daemon/log-spill.hh:232:16: error: 'wait_for' should be placed inside a while statement or used with a conditional parameter [bugprone-spuriously-wake-up-functions,cert-con36-c,cert-con54-cpp,-warnings-as-errors]143 232 | cv.wait_for(lock, poll);144 | ^145/nix/store/9z187ss3liak3pngakax2ip7nb1dc7z5-libcxx-21.1.6+apple-sdk-26.5/include/c++/v1/__expected/expected.h:560:14: error: call to deleted constructor of 'nixgrpc::UniqueFd' [clang-diagnostic-error]146 560 | is_constructible_v<_Tp, _Up> && !__is_std_unexpected<remove_cvref_t<_Up>>::value &&147 | ^~~~~~~~~~~~~~~~~~148../src/daemon/log-spill.hh:48:5: note: 'UniqueFd' has been explicitly marked deleted here149 48 | UniqueFd(const UniqueFd &) = delete;150 | ^151../src/daemon/log-spill.hh:34:7: note: 'UniqueFd' defined here152 34 | class UniqueFd153 | ^154/nix/store/9z187ss3liak3pngakax2ip7nb1dc7z5-libcxx-21.1.6+apple-sdk-26.5/include/c++/v1/__expected/expected.h:568:87: note: candidate template ignored: could not match 'unexpected<_OtherErr>' against 'UniqueFd'155 568 | _LIBCPP_HIDE_FROM_ABI constexpr explicit(!is_convertible_v<const _OtherErr&, _Err>) expected(156 | ^157/nix/store/9z187ss3liak3pngakax2ip7nb1dc7z5-libcxx-21.1.6+apple-sdk-26.5/include/c++/v1/__expected/expected.h:575:7: note: candidate template ignored: could not match 'unexpected<_OtherErr>' against 'UniqueFd'158 575 | expected(unexpected<_OtherErr>&& __unex) noexcept(is_nothrow_constructible_v<_Err, _OtherErr>) // strengthened159 | ^160/nix/store/9z187ss3liak3pngakax2ip7nb1dc7z5-libcxx-21.1.6+apple-sdk-26.5/include/c++/v1/__expected/expected.h:488:35: note: candidate constructor not viable: constraints not satisfied161 488 | _LIBCPP_HIDE_FROM_ABI constexpr expected(const expected&)162 | ^163/nix/store/9z187ss3liak3pngakax2ip7nb1dc7z5-libcxx-21.1.6+apple-sdk-26.5/include/c++/v1/__expected/expected.h:489:14: note: because 'is_copy_constructible_v<nixgrpc::UniqueFd>' evaluated to false164 489 | requires(is_copy_constructible_v<_Tp> && is_copy_constructible_v<_Err> && is_trivially_copy_constructible_v<_Tp> &&165 | ^166/nix/store/9z187ss3liak3pngakax2ip7nb1dc7z5-libcxx-21.1.6+apple-sdk-26.5/include/c++/v1/__expected/expected.h:493:35: note: candidate constructor not viable: constraints not satisfied167 493 | _LIBCPP_HIDE_FROM_ABI constexpr expected(const expected& __other) noexcept(168 | ^169/nix/store/9z187ss3liak3pngakax2ip7nb1dc7z5-libcxx-21.1.6+apple-sdk-26.5/include/c++/v1/__expected/expected.h:495:14: note: because 'is_copy_constructible_v<nixgrpc::UniqueFd>' evaluated to false170 495 | requires(is_copy_constructible_v<_Tp> && is_copy_constructible_v<_Err> &&171 | ^172/nix/store/9z187ss3liak3pngakax2ip7nb1dc7z5-libcxx-21.1.6+apple-sdk-26.5/include/c++/v1/__expected/expected.h:499:35: note: candidate constructor not viable: constraints not satisfied173 499 | _LIBCPP_HIDE_FROM_ABI constexpr expected(expected&&)174 | ^175/nix/store/9z187ss3liak3pngakax2ip7nb1dc7z5-libcxx-21.1.6+apple-sdk-26.5/include/c++/v1/__expected/expected.h:500:79: note: because 'is_trivially_move_constructible_v<nixgrpc::UniqueFd>' evaluated to false176 500 | requires(is_move_constructible_v<_Tp> && is_move_constructible_v<_Err> && is_trivially_move_constructible_v<_Tp> &&177 | ^178/nix/store/9z187ss3liak3pngakax2ip7nb1dc7z5-libcxx-21.1.6+apple-sdk-26.5/include/c++/v1/__expected/expected.h:580:44: note: explicit constructor is not a candidate179 580 | _LIBCPP_HIDE_FROM_ABI constexpr explicit expected(in_place_t, _Args&&... __args) noexcept(180 | ^181/nix/store/9z187ss3liak3pngakax2ip7nb1dc7z5-libcxx-21.1.6+apple-sdk-26.5/include/c++/v1/__expected/expected.h:592:44: note: explicit constructor is not a candidate182 592 | _LIBCPP_HIDE_FROM_ABI constexpr explicit expected(unexpect_t, _Args&&... __args) noexcept(183 | ^184>>> /nix/store/l8sbl3yky84xqxj3a5hazrjdx52avnf2-clang-tools-22.1.8/bin/clang-tidy --use-color -quiet -p /nix/var/nix/builds/nix-50839-4061795475/source/build /nix/var/nix/builds/nix-50839-4061795475/source/src/client/channel.cc185[1/1] (1/2) Processing file /nix/var/nix/builds/nix-50839-4061795475/source/src/client/channel.cc.186[1/1] (2/2) Processing file /nix/var/nix/builds/nix-50839-4061795475/source/src/client/channel.cc.187>>> /nix/store/l8sbl3yky84xqxj3a5hazrjdx52avnf2-clang-tools-22.1.8/bin/clang-tidy --use-color -quiet -p /nix/var/nix/builds/nix-50839-4061795475/source/build /nix/var/nix/builds/nix-50839-4061795475/source/tests/log-spill-test.cc188Error while processing /nix/var/nix/builds/nix-50839-4061795475/source/tests/log-spill-test.cc.189../src/daemon/log-spill.hh:38:27: error: parameter name 'fd' is too short, expected at least 3 characters [readability-identifier-length,-warnings-as-errors]190 38 | explicit UniqueFd(int fd) noexcept : fd_(fd) {}191 | ^192../src/daemon/log-spill.hh:85:20: error: variable name 'at' is too short, expected at least 3 characters [readability-identifier-length,-warnings-as-errors]193 85 | auto const at = written_.load(std::memory_order_relaxed);194 | ^195../src/daemon/log-spill.hh:100:80: error: possibly unsafe 'operator[]', consider bounds-safe alternatives [cppcoreguidelines-pro-bounds-avoid-unchecked-container-access,-warnings-as-errors]196 100 | std::array<std::byte, kHeader> header{static_cast<std::byte>(kind), len[0], len[1], len[2], len[3]};197 | ^~~198../src/daemon/log-spill.hh:100:88: error: possibly unsafe 'operator[]', consider bounds-safe alternatives [cppcoreguidelines-pro-bounds-avoid-unchecked-container-access,-warnings-as-errors]199 100 | std::array<std::byte, kHeader> header{static_cast<std::byte>(kind), len[0], len[1], len[2], len[3]};200 | ^~~201../src/daemon/log-spill.hh:100:96: error: possibly unsafe 'operator[]', consider bounds-safe alternatives [cppcoreguidelines-pro-bounds-avoid-unchecked-container-access,-warnings-as-errors]202 100 | std::array<std::byte, kHeader> header{static_cast<std::byte>(kind), len[0], len[1], len[2], len[3]};203 | ^~~204../src/daemon/log-spill.hh:100:104: error: possibly unsafe 'operator[]', consider bounds-safe alternatives [cppcoreguidelines-pro-bounds-avoid-unchecked-container-access,-warnings-as-errors]205 100 | std::array<std::byte, kHeader> header{static_cast<std::byte>(kind), len[0], len[1], len[2], len[3]};206 | ^~~207../src/daemon/log-spill.hh:116:42: error: forwarding reference parameter 'fn' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward,-warnings-as-errors]208 116 | auto drain(std::size_t offset, Fn && fn) const -> std::size_t209 | ^210../src/daemon/log-spill.hh:116:42: error: parameter name 'fn' is too short, expected at least 3 characters [readability-identifier-length,-warnings-as-errors]211../src/daemon/log-spill.hh:128:67: error: possibly unsafe 'operator[]', consider bounds-safe alternatives [cppcoreguidelines-pro-bounds-avoid-unchecked-container-access,-warnings-as-errors]212 128 | auto const kind = std::to_integer<std::uint8_t>(header[0]);213 | ^~~214../src/daemon/log-spill.hh:149:25: error: variable name 'ec' is too short, expected at least 3 characters [readability-identifier-length,-warnings-as-errors]215 149 | std::error_code ec;216 | ^217../src/daemon/log-spill.hh:154:22: error: variable name 'fd' is too short, expected at least 3 characters [readability-identifier-length,-warnings-as-errors]218 154 | if (UniqueFd fd(::open(dir.c_str(), O_TMPFILE | O_RDWR | O_CLOEXEC, 0600)); fd) {219 | ^220../src/daemon/log-spill.hh:154:45: error: use of undeclared identifier 'O_TMPFILE' [clang-diagnostic-error]221 154 | if (UniqueFd fd(::open(dir.c_str(), O_TMPFILE | O_RDWR | O_CLOEXEC, 0600)); fd) {222 | ^~~~~~~~~223../src/daemon/log-spill.hh:154:77: error: 0600 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers,-warnings-as-errors]224 154 | if (UniqueFd fd(::open(dir.c_str(), O_TMPFILE | O_RDWR | O_CLOEXEC, 0600)); fd) {225 | ^226../src/daemon/log-spill.hh:155:20: error: no viable conversion from returned value of type 'UniqueFd' to function return type 'std::expected<UniqueFd, std::error_code>' [clang-diagnostic-error]227 155 | return fd;228 | ^~229/nix/store/9z187ss3liak3pngakax2ip7nb1dc7z5-libcxx-21.1.6+apple-sdk-26.5/include/c++/v1/__expected/expected.h:486:35: note: candidate constructor not viable: no known conversion from 'UniqueFd' to 'const expected<nixgrpc::UniqueFd, std::error_code> &' for 1st argument230 486 | _LIBCPP_HIDE_FROM_ABI constexpr expected(const expected&) = delete;231 | ^ ~~~~~~~~~~~~~~~232/nix/store/9z187ss3liak3pngakax2ip7nb1dc7z5-libcxx-21.1.6+apple-sdk-26.5/include/c++/v1/__expected/expected.h:504:35: note: candidate constructor not viable: no known conversion from 'UniqueFd' to 'expected<nixgrpc::UniqueFd, std::error_code> &&' for 1st argument233 504 | _LIBCPP_HIDE_FROM_ABI constexpr expected(expected&& __other) noexcept(234 | ^ ~~~~~~~~~~~~~~~~~~235/nix/store/9z187ss3liak3pngakax2ip7nb1dc7z5-libcxx-21.1.6+apple-sdk-26.5/include/c++/v1/__expected/expected.h:546:7: note: candidate template ignored: could not match 'expected<_Up, _OtherErr>' against 'UniqueFd'236 546 | expected(const expected<_Up, _OtherErr>& __other) noexcept(237 | ^238/nix/store/9z187ss3liak3pngakax2ip7nb1dc7z5-libcxx-21.1.6+apple-sdk-26.5/include/c++/v1/__expected/expected.h:554:7: note: candidate template ignored: could not match 'expected<_Up, _OtherErr>' against 'UniqueFd'239 554 | expected(expected<_Up, _OtherErr>&& __other) noexcept(240 | ^241/nix/store/9z187ss3liak3pngakax2ip7nb1dc7z5-libcxx-21.1.6+apple-sdk-26.5/include/c++/v1/__expected/expected.h:563:7: note: candidate template ignored: constraints not satisfied [with _Up = UniqueFd &]242 563 | expected(_Up&& __u) noexcept(is_nothrow_constructible_v<_Tp, _Up>) // strengthened243 | ^244/nix/store/9z187ss3liak3pngakax2ip7nb1dc7z5-libcxx-21.1.6+apple-sdk-26.5/include/c++/v1/__expected/expected.h:560:14: note: because 'is_constructible_v<nixgrpc::UniqueFd, nixgrpc::UniqueFd &>' evaluated to false245 560 | is_constructible_v<_Tp, _Up> && !__is_std_unexpected<remove_cvref_t<_Up>>::value &&246 | ^247../src/daemon/log-spill.hh:158:18: error: variable name 'fd' is too short, expected at least 3 characters [readability-identifier-length,-warnings-as-errors]248 158 | UniqueFd fd(::mkostemp(name.data(), O_CLOEXEC));249 | ^250../src/daemon/log-spill.hh:169:24: error: variable name 'n' is too short, expected at least 3 characters [readability-identifier-length,-warnings-as-errors]251 169 | auto const n = ::pwrite(fd_.get(), data.data(), data.size(), static_cast<off_t>(offset));252 | ^253../src/daemon/log-spill.hh:185:24: error: variable name 'n' is too short, expected at least 3 characters [readability-identifier-length,-warnings-as-errors]254 185 | auto const n = ::pread(fd_.get(), out.data(), out.size(), static_cast<off_t>(offset));255 | ^256../src/daemon/log-spill.hh:212:31: error: parameter name 'cv' is too short, expected at least 3 characters [readability-identifier-length,-warnings-as-errors]257 212 | std::condition_variable & cv,258 | ^259../src/daemon/log-spill.hh:215:18: error: forwarding reference parameter 'cancelled' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward,-warnings-as-errors]260 215 | Cancelled && cancelled,261 | ^262../src/daemon/log-spill.hh:216:13: error: forwarding reference parameter 'emit' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward,-warnings-as-errors]263 216 | Emit && emit) -> bool264 | ^265../src/daemon/log-spill.hh:232:16: error: 'wait_for' should be placed inside a while statement or used with a conditional parameter [bugprone-spuriously-wake-up-functions,cert-con36-c,cert-con54-cpp,-warnings-as-errors]266 232 | cv.wait_for(lock, poll);267 | ^268../tests/log-spill-test.cc:1:1: error: included header atomic is not used directly [misc-include-cleaner,-warnings-as-errors]269 1 | #include <atomic>270 | ^~~~~~~~~~~~~~~~~271 2 | #include <cassert>272../tests/log-spill-test.cc:23:45: error: no header providing "std::string_view" is directly included [misc-include-cleaner,-warnings-as-errors]273 8 | #include <thread>274 9 | #include <utility>275 10 | #include <vector>276 11 | 277 12 | #include "log-spill.hh"278 13 | 279 14 | using nixgrpc::LogSpill;280 15 | using nixgrpc::SpillKind;281 16 | using Records = std::vector<std::pair<SpillKind, std::string>>;282 17 | 283 18 | namespace {284 19 | 285 20 | auto readAll(const LogSpill & spill) -> Records286 21 | {287 22 | Records out;288 23 | spill.drain(0, [&](SpillKind kind, std::string_view text) -> void { out.emplace_back(kind, std::string(text)); });289 | ^290../tests/log-spill-test.cc:27:83: error: parameter name 'cv' is too short, expected at least 3 characters [readability-identifier-length,-warnings-as-errors]291 27 | auto follow(const LogSpill & spill, std::mutex & mutex, std::condition_variable & cv, const bool & finished) -> Records292 | ^293../tests/log-spill-test.cc:44:47: error: 300000 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers,-warnings-as-errors]294 44 | spill.append(SpillKind::line, std::string(300000, 'x'));295 | ^296../tests/log-spill-test.cc:47:15: error: possibly unsafe 'operator[]', consider bounds-safe alternatives [cppcoreguidelines-pro-bounds-avoid-unchecked-container-access,-warnings-as-errors]297 47 | assert(got[0] == std::make_pair(SpillKind::line, std::string("first")));298 | ^299/nix/store/rq88pmfxfl98jhzfhb46jvl0rl8nyd6g-apple-sdk-14.4/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/assert.h:99:25: note: expanded from macro 'assert'300 99 | (__builtin_expect(!(e), 0) ? __assert_rtn(__func__, __ASSERT_FILE_NAME, __LINE__, #e) : (void)0)301 | ^302../tests/log-spill-test.cc:48:15: error: possibly unsafe 'operator[]', consider bounds-safe alternatives [cppcoreguidelines-pro-bounds-avoid-unchecked-container-access,-warnings-as-errors]303 48 | assert(got[1] == std::make_pair(SpillKind::phase, std::string("build")));304 | ^305/nix/store/rq88pmfxfl98jhzfhb46jvl0rl8nyd6g-apple-sdk-14.4/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/assert.h:99:25: note: expanded from macro 'assert'306 99 | (__builtin_expect(!(e), 0) ? __assert_rtn(__func__, __ASSERT_FILE_NAME, __LINE__, #e) : (void)0)307 | ^308../tests/log-spill-test.cc:49:15: error: possibly unsafe 'operator[]', consider bounds-safe alternatives [cppcoreguidelines-pro-bounds-avoid-unchecked-container-access,-warnings-as-errors]309 49 | assert(got[2].second.empty());310 | ^311/nix/store/rq88pmfxfl98jhzfhb46jvl0rl8nyd6g-apple-sdk-14.4/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/assert.h:99:25: note: expanded from macro 'assert'312 99 | (__builtin_expect(!(e), 0) ? __assert_rtn(__func__, __ASSERT_FILE_NAME, __LINE__, #e) : (void)0)313 | ^314../tests/log-spill-test.cc:50:15: error: possibly unsafe 'operator[]', consider bounds-safe alternatives [cppcoreguidelines-pro-bounds-avoid-unchecked-container-access,-warnings-as-errors]315 50 | assert(got[3].second.size() == 300000);316 | ^317/nix/store/rq88pmfxfl98jhzfhb46jvl0rl8nyd6g-apple-sdk-14.4/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/assert.h:99:25: note: expanded from macro 'assert'318 99 | (__builtin_expect(!(e), 0) ? __assert_rtn(__func__, __ASSERT_FILE_NAME, __LINE__, #e) : (void)0)319 | ^320../tests/log-spill-test.cc:57:36: error: possibly unsafe 'operator[]', consider bounds-safe alternatives [cppcoreguidelines-pro-bounds-avoid-unchecked-container-access,-warnings-as-errors]321 57 | assert(rest.size() == 1 && rest[0].second == "later");322 | ^323/nix/store/rq88pmfxfl98jhzfhb46jvl0rl8nyd6g-apple-sdk-14.4/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/assert.h:99:25: note: expanded from macro 'assert'324 99 | (__builtin_expect(!(e), 0) ? __assert_rtn(__func__, __ASSERT_FILE_NAME, __LINE__, #e) : (void)0)325 | ^326../tests/log-spill-test.cc:63:68: error: 5 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers,-warnings-as-errors]327 63 | spill.append(SpillKind::line, std::string(LogSpill::kMaxText + 5, 'x'));328 | ^329../tests/log-spill-test.cc:65:34: error: possibly unsafe 'operator[]', consider bounds-safe alternatives [cppcoreguidelines-pro-bounds-avoid-unchecked-container-access,-warnings-as-errors]330 65 | assert(got.size() == 1 && got[0].second.size() == LogSpill::kMaxText);331 | ^332/nix/store/rq88pmfxfl98jhzfhb46jvl0rl8nyd6g-apple-sdk-14.4/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/assert.h:99:25: note: expanded from macro 'assert'333 99 | (__builtin_expect(!(e), 0) ? __assert_rtn(__func__, __ASSERT_FILE_NAME, __LINE__, #e) : (void)0)334 | ^335../tests/log-spill-test.cc:70:20: error: 64 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers,-warnings-as-errors]336 70 | LogSpill spill(64);337 | ^338../tests/log-spill-test.cc:71:25: error: 50 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers,-warnings-as-errors]339 71 | for (int i = 0; i < 50; i++) {340 | ^341../tests/log-spill-test.cc:85:36: error: possibly unsafe 'operator[]', consider bounds-safe alternatives [cppcoreguidelines-pro-bounds-avoid-unchecked-container-access,-warnings-as-errors]342 85 | assert(only.size() == 1 && only[0].second == LogSpill::kTruncated);343 | ^344/nix/store/rq88pmfxfl98jhzfhb46jvl0rl8nyd6g-apple-sdk-14.4/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/assert.h:99:25: note: expanded from macro 'assert'345 99 | (__builtin_expect(!(e), 0) ? __assert_rtn(__func__, __ASSERT_FILE_NAME, __LINE__, #e) : (void)0)346 | ^347../tests/log-spill-test.cc:90:5: error: function is not thread safe [concurrency-mt-unsafe,-warnings-as-errors]348 90 | setenv("TMPDIR", "/nonexistent-dir", 1);349 | ^350../tests/log-spill-test.cc:90:5: error: no header providing "setenv" is directly included [misc-include-cleaner,-warnings-as-errors]351 7 | setenv("TMPDIR", "/nonexistent-dir", 1);352 | ^353../tests/log-spill-test.cc:95:5: error: function is not thread safe [concurrency-mt-unsafe,-warnings-as-errors]354 95 | unsetenv("TMPDIR");355 | ^356../tests/log-spill-test.cc:95:5: error: no header providing "unsetenv" is directly included [misc-include-cleaner,-warnings-as-errors]357../tests/log-spill-test.cc:103:29: error: variable name 'cv' is too short, expected at least 3 characters [readability-identifier-length,-warnings-as-errors]358 103 | std::condition_variable cv;359 | ^360../tests/log-spill-test.cc:119:30: error: 1000 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers,-warnings-as-errors]361 119 | while (spill.written() < 1000) {362 | ^363../tests/log-spill-test.cc:129:26: error: possibly unsafe 'operator[]', consider bounds-safe alternatives [cppcoreguidelines-pro-bounds-avoid-unchecked-container-access,-warnings-as-errors]364 129 | assert((*got)[static_cast<std::size_t>(i)].second == "line " + std::to_string(i));365 | ^366/nix/store/rq88pmfxfl98jhzfhb46jvl0rl8nyd6g-apple-sdk-14.4/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/assert.h:99:25: note: expanded from macro 'assert'367 99 | (__builtin_expect(!(e), 0) ? __assert_rtn(__func__, __ASSERT_FILE_NAME, __LINE__, #e) : (void)0)368 | ^369../tests/log-spill-test.cc:138:29: error: variable name 'cv' is too short, expected at least 3 characters [readability-identifier-length,-warnings-as-errors]370 138 | std::condition_variable cv;371 | ^372../tests/log-spill-test.cc:149:6: error: an exception may be thrown in function 'main' which should not throw exceptions [bugprone-exception-escape,-warnings-as-errors]373 149 | auto main() -> int374 | ^375/nix/store/9z187ss3liak3pngakax2ip7nb1dc7z5-libcxx-21.1.6+apple-sdk-26.5/include/c++/v1/__new/exceptions.h:67:3: note: frame #0: unhandled exception of type 'bad_array_new_length' may be thrown in function '__throw_bad_array_new_length' here376 67 | throw bad_array_new_length();377 | ^378/nix/store/9z187ss3liak3pngakax2ip7nb1dc7z5-libcxx-21.1.6+apple-sdk-26.5/include/c++/v1/__memory/allocator.h:101:7: note: frame #1: function 'allocate' calls function '__throw_bad_array_new_length' here379 101 | std::__throw_bad_array_new_length();380 | ^381/nix/store/9z187ss3liak3pngakax2ip7nb1dc7z5-libcxx-21.1.6+apple-sdk-26.5/include/c++/v1/__memory/allocator.h:112:13: note: frame #2: function 'allocate_at_least' calls function 'allocate' here382 112 | return {allocate(__n), __n};383 | ^384/nix/store/9z187ss3liak3pngakax2ip7nb1dc7z5-libcxx-21.1.6+apple-sdk-26.5/include/c++/v1/__memory/allocator_traits.h:280:14: note: frame #3: function 'allocate_at_least<std::allocator<char>>' calls function 'allocate_at_least' here385 280 | return __alloc.allocate_at_least(__n);386 | ^387/nix/store/9z187ss3liak3pngakax2ip7nb1dc7z5-libcxx-21.1.6+apple-sdk-26.5/include/c++/v1/__memory/allocate_at_least.h:26:10: note: frame #4: function '__allocate_at_least<std::allocator<char>>' calls function 'allocate_at_least<std::allocator<char>>' here388 26 | return std::allocator_traits<_Alloc>::allocate_at_least(__alloc, __n);389 | ^390/nix/store/9z187ss3liak3pngakax2ip7nb1dc7z5-libcxx-21.1.6+apple-sdk-26.5/include/c++/v1/string:2749:23: note: frame #5: function '__grow_by' calls function '__allocate_at_least<std::allocator<char>>' here391 2749 | auto __allocation = std::__allocate_at_least(__alloc_, __cap + 1);392 | ^393/nix/store/9z187ss3liak3pngakax2ip7nb1dc7z5-libcxx-21.1.6+apple-sdk-26.5/include/c++/v1/string:2776:3: note: frame #6: function '__grow_by_without_replace' calls function '__grow_by' here394 2776 | __grow_by(__old_cap, __delta_cap, __old_sz, __n_copy, __n_del, __n_add);395 | ^396/nix/store/9z187ss3liak3pngakax2ip7nb1dc7z5-libcxx-21.1.6+apple-sdk-26.5/include/c++/v1/string:3041:7: note: frame #7: function 'append' calls function '__grow_by_without_replace' here397 3041 | __grow_by_without_replace(__cap, __sz + __n - __cap, __sz, __sz, 0);398 | ^399/nix/store/9z187ss3liak3pngakax2ip7nb1dc7z5-libcxx-21.1.6+apple-sdk-26.5/include/c++/v1/string:3394:5: note: frame #8: function 'resize' calls function 'append' here400 3394 | append(__n - __sz, __c);401 | ^402/nix/store/9z187ss3liak3pngakax2ip7nb1dc7z5-libcxx-21.1.6+apple-sdk-26.5/include/c++/v1/string:1307:84: note: frame #9: function 'resize' calls function 'resize' here403 1307 | _LIBCPP_HIDE_FROM_ABI _LIBCPP_CONSTEXPR_SINCE_CXX20 void resize(size_type __n) { resize(__n, value_type()); }404 | ^405../src/daemon/log-spill.hh:132:13: note: frame #10: function 'drain<(lambda at ../tests/log-spill-test.cc:23:20)>' calls function 'resize' here406 132 | text.resize(len);407 | ^408../tests/log-spill-test.cc:23:5: note: frame #11: function 'readAll' calls function 'drain<(lambda at ../tests/log-spill-test.cc:23:20)>' here409 23 | spill.drain(0, [&](SpillKind kind, std::string_view text) -> void { out.emplace_back(kind, std::string(text)); });410 | ^411../tests/log-spill-test.cc:40:12: note: frame #12: function 'roundTrip' calls function 'readAll' here412 40 | assert(readAll(spill).empty());413 | ^414../tests/log-spill-test.cc:151:5: note: frame #13: function 'main' calls function 'roundTrip' here415 151 | roundTrip();416 | ^417/nix/store/9z187ss3liak3pngakax2ip7nb1dc7z5-libcxx-21.1.6+apple-sdk-26.5/include/c++/v1/__expected/expected.h:560:14: error: call to deleted constructor of 'nixgrpc::UniqueFd' [clang-diagnostic-error]418 560 | is_constructible_v<_Tp, _Up> && !__is_std_unexpected<remove_cvref_t<_Up>>::value &&419 | ^~~~~~~~~~~~~~~~~~420../src/daemon/log-spill.hh:48:5: note: 'UniqueFd' has been explicitly marked deleted here421 48 | UniqueFd(const UniqueFd &) = delete;422 | ^423../src/daemon/log-spill.hh:34:7: note: 'UniqueFd' defined here424 34 | class UniqueFd425 | ^426/nix/store/9z187ss3liak3pngakax2ip7nb1dc7z5-libcxx-21.1.6+apple-sdk-26.5/include/c++/v1/__expected/expected.h:568:87: note: candidate template ignored: could not match 'unexpected<_OtherErr>' against 'UniqueFd'427 568 | _LIBCPP_HIDE_FROM_ABI constexpr explicit(!is_convertible_v<const _OtherErr&, _Err>) expected(428 | ^429/nix/store/9z187ss3liak3pngakax2ip7nb1dc7z5-libcxx-21.1.6+apple-sdk-26.5/include/c++/v1/__expected/expected.h:575:7: note: candidate template ignored: could not match 'unexpected<_OtherErr>' against 'UniqueFd'430 575 | expected(unexpected<_OtherErr>&& __unex) noexcept(is_nothrow_constructible_v<_Err, _OtherErr>) // strengthened431 | ^432/nix/store/9z187ss3liak3pngakax2ip7nb1dc7z5-libcxx-21.1.6+apple-sdk-26.5/include/c++/v1/__expected/expected.h:488:35: note: candidate constructor not viable: constraints not satisfied433 488 | _LIBCPP_HIDE_FROM_ABI constexpr expected(const expected&)434 | ^435/nix/store/9z187ss3liak3pngakax2ip7nb1dc7z5-libcxx-21.1.6+apple-sdk-26.5/include/c++/v1/__expected/expected.h:489:14: note: because 'is_copy_constructible_v<nixgrpc::UniqueFd>' evaluated to false436 489 | requires(is_copy_constructible_v<_Tp> && is_copy_constructible_v<_Err> && is_trivially_copy_constructible_v<_Tp> &&437 | ^438/nix/store/9z187ss3liak3pngakax2ip7nb1dc7z5-libcxx-21.1.6+apple-sdk-26.5/include/c++/v1/__expected/expected.h:493:35: note: candidate constructor not viable: constraints not satisfied439 493 | _LIBCPP_HIDE_FROM_ABI constexpr expected(const expected& __other) noexcept(440 | ^441/nix/store/9z187ss3liak3pngakax2ip7nb1dc7z5-libcxx-21.1.6+apple-sdk-26.5/include/c++/v1/__expected/expected.h:495:14: note: because 'is_copy_constructible_v<nixgrpc::UniqueFd>' evaluated to false442 495 | requires(is_copy_constructible_v<_Tp> && is_copy_constructible_v<_Err> &&443 | ^444/nix/store/9z187ss3liak3pngakax2ip7nb1dc7z5-libcxx-21.1.6+apple-sdk-26.5/include/c++/v1/__expected/expected.h:499:35: note: candidate constructor not viable: constraints not satisfied445 499 | _LIBCPP_HIDE_FROM_ABI constexpr expected(expected&&)446 | ^447/nix/store/9z187ss3liak3pngakax2ip7nb1dc7z5-libcxx-21.1.6+apple-sdk-26.5/include/c++/v1/__expected/expected.h:500:79: note: because 'is_trivially_move_constructible_v<nixgrpc::UniqueFd>' evaluated to false448 500 | requires(is_move_constructible_v<_Tp> && is_move_constructible_v<_Err> && is_trivially_move_constructible_v<_Tp> &&449 | ^450/nix/store/9z187ss3liak3pngakax2ip7nb1dc7z5-libcxx-21.1.6+apple-sdk-26.5/include/c++/v1/__expected/expected.h:580:44: note: explicit constructor is not a candidate451 580 | _LIBCPP_HIDE_FROM_ABI constexpr explicit expected(in_place_t, _Args&&... __args) noexcept(452 | ^453/nix/store/9z187ss3liak3pngakax2ip7nb1dc7z5-libcxx-21.1.6+apple-sdk-26.5/include/c++/v1/__expected/expected.h:592:44: note: explicit constructor is not a candidate454 592 | _LIBCPP_HIDE_FROM_ABI constexpr explicit expected(unexpect_t, _Args&&... __args) noexcept(455 | ^456>>> /nix/store/l8sbl3yky84xqxj3a5hazrjdx52avnf2-clang-tools-22.1.8/bin/clang-tidy --use-color -quiet -p /nix/var/nix/builds/nix-50839-4061795475/source/build /nix/var/nix/builds/nix-50839-4061795475/source/src/daemon/main.cc457Errors encountered while running clang-tidy458Error while processing /nix/var/nix/builds/nix-50839-4061795475/source/src/daemon/main.cc.459../src/daemon/log-spill.hh:38:27: error: parameter name 'fd' is too short, expected at least 3 characters [readability-identifier-length,-warnings-as-errors]460 38 | explicit UniqueFd(int fd) noexcept : fd_(fd) {}461 | ^462../src/daemon/log-spill.hh:85:20: error: variable name 'at' is too short, expected at least 3 characters [readability-identifier-length,-warnings-as-errors]463 85 | auto const at = written_.load(std::memory_order_relaxed);464 | ^465../src/daemon/log-spill.hh:100:80: error: possibly unsafe 'operator[]', consider bounds-safe alternatives [cppcoreguidelines-pro-bounds-avoid-unchecked-container-access,-warnings-as-errors]466 100 | std::array<std::byte, kHeader> header{static_cast<std::byte>(kind), len[0], len[1], len[2], len[3]};467 | ^~~468../src/daemon/log-spill.hh:100:88: error: possibly unsafe 'operator[]', consider bounds-safe alternatives [cppcoreguidelines-pro-bounds-avoid-unchecked-container-access,-warnings-as-errors]469 100 | std::array<std::byte, kHeader> header{static_cast<std::byte>(kind), len[0], len[1], len[2], len[3]};470 | ^~~471../src/daemon/log-spill.hh:100:96: error: possibly unsafe 'operator[]', consider bounds-safe alternatives [cppcoreguidelines-pro-bounds-avoid-unchecked-container-access,-warnings-as-errors]472 100 | std::array<std::byte, kHeader> header{static_cast<std::byte>(kind), len[0], len[1], len[2], len[3]};473 | ^~~474../src/daemon/log-spill.hh:100:104: error: possibly unsafe 'operator[]', consider bounds-safe alternatives [cppcoreguidelines-pro-bounds-avoid-unchecked-container-access,-warnings-as-errors]475 100 | std::array<std::byte, kHeader> header{static_cast<std::byte>(kind), len[0], len[1], len[2], len[3]};476 | ^~~477../src/daemon/log-spill.hh:116:42: error: forwarding reference parameter 'fn' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward,-warnings-as-errors]478 116 | auto drain(std::size_t offset, Fn && fn) const -> std::size_t479 | ^480../src/daemon/log-spill.hh:116:42: error: parameter name 'fn' is too short, expected at least 3 characters [readability-identifier-length,-warnings-as-errors]481../src/daemon/log-spill.hh:128:67: error: possibly unsafe 'operator[]', consider bounds-safe alternatives [cppcoreguidelines-pro-bounds-avoid-unchecked-container-access,-warnings-as-errors]482 128 | auto const kind = std::to_integer<std::uint8_t>(header[0]);483 | ^~~484../src/daemon/log-spill.hh:149:25: error: variable name 'ec' is too short, expected at least 3 characters [readability-identifier-length,-warnings-as-errors]485 149 | std::error_code ec;486 | ^487../src/daemon/log-spill.hh:154:22: error: variable name 'fd' is too short, expected at least 3 characters [readability-identifier-length,-warnings-as-errors]488 154 | if (UniqueFd fd(::open(dir.c_str(), O_TMPFILE | O_RDWR | O_CLOEXEC, 0600)); fd) {489 | ^490../src/daemon/log-spill.hh:154:45: error: use of undeclared identifier 'O_TMPFILE' [clang-diagnostic-error]491 154 | if (UniqueFd fd(::open(dir.c_str(), O_TMPFILE | O_RDWR | O_CLOEXEC, 0600)); fd) {492 | ^~~~~~~~~493../src/daemon/log-spill.hh:154:77: error: 0600 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers,-warnings-as-errors]494 154 | if (UniqueFd fd(::open(dir.c_str(), O_TMPFILE | O_RDWR | O_CLOEXEC, 0600)); fd) {495 | ^496../src/daemon/log-spill.hh:155:20: error: no viable conversion from returned value of type 'UniqueFd' to function return type 'std::expected<UniqueFd, std::error_code>' [clang-diagnostic-error]497 155 | return fd;498 | ^~499/nix/store/9z187ss3liak3pngakax2ip7nb1dc7z5-libcxx-21.1.6+apple-sdk-26.5/include/c++/v1/__expected/expected.h:486:35: note: candidate constructor not viable: no known conversion from 'UniqueFd' to 'const expected<nixgrpc::UniqueFd, std::error_code> &' for 1st argument500 486 | _LIBCPP_HIDE_FROM_ABI constexpr expected(const expected&) = delete;501 | ^ ~~~~~~~~~~~~~~~502/nix/store/9z187ss3liak3pngakax2ip7nb1dc7z5-libcxx-21.1.6+apple-sdk-26.5/include/c++/v1/__expected/expected.h:504:35: note: candidate constructor not viable: no known conversion from 'UniqueFd' to 'expected<nixgrpc::UniqueFd, std::error_code> &&' for 1st argument503 504 | _LIBCPP_HIDE_FROM_ABI constexpr expected(expected&& __other) noexcept(504 | ^ ~~~~~~~~~~~~~~~~~~505/nix/store/9z187ss3liak3pngakax2ip7nb1dc7z5-libcxx-21.1.6+apple-sdk-26.5/include/c++/v1/__expected/expected.h:546:7: note: candidate template ignored: could not match 'expected<_Up, _OtherErr>' against 'UniqueFd'506 546 | expected(const expected<_Up, _OtherErr>& __other) noexcept(507 | ^508/nix/store/9z187ss3liak3pngakax2ip7nb1dc7z5-libcxx-21.1.6+apple-sdk-26.5/include/c++/v1/__expected/expected.h:554:7: note: candidate template ignored: could not match 'expected<_Up, _OtherErr>' against 'UniqueFd'509 554 | expected(expected<_Up, _OtherErr>&& __other) noexcept(510 | ^511/nix/store/9z187ss3liak3pngakax2ip7nb1dc7z5-libcxx-21.1.6+apple-sdk-26.5/include/c++/v1/__expected/expected.h:563:7: note: candidate template ignored: constraints not satisfied [with _Up = UniqueFd &]512 563 | expected(_Up&& __u) noexcept(is_nothrow_constructible_v<_Tp, _Up>) // strengthened513 | ^514/nix/store/9z187ss3liak3pngakax2ip7nb1dc7z5-libcxx-21.1.6+apple-sdk-26.5/include/c++/v1/__expected/expected.h:560:14: note: because 'is_constructible_v<nixgrpc::UniqueFd, nixgrpc::UniqueFd &>' evaluated to false515 560 | is_constructible_v<_Tp, _Up> && !__is_std_unexpected<remove_cvref_t<_Up>>::value &&516 | ^517../src/daemon/log-spill.hh:158:18: error: variable name 'fd' is too short, expected at least 3 characters [readability-identifier-length,-warnings-as-errors]518 158 | UniqueFd fd(::mkostemp(name.data(), O_CLOEXEC));519 | ^520../src/daemon/log-spill.hh:169:24: error: variable name 'n' is too short, expected at least 3 characters [readability-identifier-length,-warnings-as-errors]521 169 | auto const n = ::pwrite(fd_.get(), data.data(), data.size(), static_cast<off_t>(offset));522 | ^523../src/daemon/log-spill.hh:185:24: error: variable name 'n' is too short, expected at least 3 characters [readability-identifier-length,-warnings-as-errors]524 185 | auto const n = ::pread(fd_.get(), out.data(), out.size(), static_cast<off_t>(offset));525 | ^526../src/daemon/log-spill.hh:212:31: error: parameter name 'cv' is too short, expected at least 3 characters [readability-identifier-length,-warnings-as-errors]527 212 | std::condition_variable & cv,528 | ^529../src/daemon/log-spill.hh:215:18: error: forwarding reference parameter 'cancelled' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward,-warnings-as-errors]530 215 | Cancelled && cancelled,531 | ^532../src/daemon/log-spill.hh:216:13: error: forwarding reference parameter 'emit' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward,-warnings-as-errors]533 216 | Emit && emit) -> bool534 | ^535../src/daemon/log-spill.hh:232:16: error: 'wait_for' should be placed inside a while statement or used with a conditional parameter [bugprone-spuriously-wake-up-functions,cert-con36-c,cert-con54-cpp,-warnings-as-errors]536 232 | cv.wait_for(lock, poll);537 | ^538../src/daemon/main.cc:96:41: error: no header providing "nixgrpc::SpillKind" is directly included [misc-include-cleaner,-warnings-as-errors]539 71 | static_assert(static_cast<int>(nixgrpc::SpillKind::line) == static_cast<int>(nixgrpc::BuildEvent::Kind::line));540 | ^541../src/daemon/main.cc:507:41: error: no header providing "nixgrpc::followSpill" is directly included [misc-include-cleaner,-warnings-as-errors]542 507 | auto const completed = nixgrpc::followSpill(543 | ^544/nix/store/9z187ss3liak3pngakax2ip7nb1dc7z5-libcxx-21.1.6+apple-sdk-26.5/include/c++/v1/__expected/expected.h:560:14: error: call to deleted constructor of 'nixgrpc::UniqueFd' [clang-diagnostic-error]545 560 | is_constructible_v<_Tp, _Up> && !__is_std_unexpected<remove_cvref_t<_Up>>::value &&546 | ^~~~~~~~~~~~~~~~~~547../src/daemon/log-spill.hh:48:5: note: 'UniqueFd' has been explicitly marked deleted here548 48 | UniqueFd(const UniqueFd &) = delete;549 | ^550../src/daemon/log-spill.hh:34:7: note: 'UniqueFd' defined here551 34 | class UniqueFd552 | ^553/nix/store/9z187ss3liak3pngakax2ip7nb1dc7z5-libcxx-21.1.6+apple-sdk-26.5/include/c++/v1/__expected/expected.h:568:87: note: candidate template ignored: could not match 'unexpected<_OtherErr>' against 'UniqueFd'554 568 | _LIBCPP_HIDE_FROM_ABI constexpr explicit(!is_convertible_v<const _OtherErr&, _Err>) expected(555 | ^556/nix/store/9z187ss3liak3pngakax2ip7nb1dc7z5-libcxx-21.1.6+apple-sdk-26.5/include/c++/v1/__expected/expected.h:575:7: note: candidate template ignored: could not match 'unexpected<_OtherErr>' against 'UniqueFd'557 575 | expected(unexpected<_OtherErr>&& __unex) noexcept(is_nothrow_constructible_v<_Err, _OtherErr>) // strengthened558 | ^559/nix/store/9z187ss3liak3pngakax2ip7nb1dc7z5-libcxx-21.1.6+apple-sdk-26.5/include/c++/v1/__expected/expected.h:488:35: note: candidate constructor not viable: constraints not satisfied560 488 | _LIBCPP_HIDE_FROM_ABI constexpr expected(const expected&)561 | ^562/nix/store/9z187ss3liak3pngakax2ip7nb1dc7z5-libcxx-21.1.6+apple-sdk-26.5/include/c++/v1/__expected/expected.h:489:14: note: because 'is_copy_constructible_v<nixgrpc::UniqueFd>' evaluated to false563 489 | requires(is_copy_constructible_v<_Tp> && is_copy_constructible_v<_Err> && is_trivially_copy_constructible_v<_Tp> &&564 | ^565/nix/store/9z187ss3liak3pngakax2ip7nb1dc7z5-libcxx-21.1.6+apple-sdk-26.5/include/c++/v1/__expected/expected.h:493:35: note: candidate constructor not viable: constraints not satisfied566 493 | _LIBCPP_HIDE_FROM_ABI constexpr expected(const expected& __other) noexcept(567 | ^568/nix/store/9z187ss3liak3pngakax2ip7nb1dc7z5-libcxx-21.1.6+apple-sdk-26.5/include/c++/v1/__expected/expected.h:495:14: note: because 'is_copy_constructible_v<nixgrpc::UniqueFd>' evaluated to false569 495 | requires(is_copy_constructible_v<_Tp> && is_copy_constructible_v<_Err> &&570 | ^571/nix/store/9z187ss3liak3pngakax2ip7nb1dc7z5-libcxx-21.1.6+apple-sdk-26.5/include/c++/v1/__expected/expected.h:499:35: note: candidate constructor not viable: constraints not satisfied572 499 | _LIBCPP_HIDE_FROM_ABI constexpr expected(expected&&)573 | ^574/nix/store/9z187ss3liak3pngakax2ip7nb1dc7z5-libcxx-21.1.6+apple-sdk-26.5/include/c++/v1/__expected/expected.h:500:79: note: because 'is_trivially_move_constructible_v<nixgrpc::UniqueFd>' evaluated to false575 500 | requires(is_move_constructible_v<_Tp> && is_move_constructible_v<_Err> && is_trivially_move_constructible_v<_Tp> &&576 | ^577/nix/store/9z187ss3liak3pngakax2ip7nb1dc7z5-libcxx-21.1.6+apple-sdk-26.5/include/c++/v1/__expected/expected.h:580:44: note: explicit constructor is not a candidate578 580 | _LIBCPP_HIDE_FROM_ABI constexpr explicit expected(in_place_t, _Args&&... __args) noexcept(579 | ^580/nix/store/9z187ss3liak3pngakax2ip7nb1dc7z5-libcxx-21.1.6+apple-sdk-26.5/include/c++/v1/__expected/expected.h:592:44: note: explicit constructor is not a candidate581 592 | _LIBCPP_HIDE_FROM_ABI constexpr explicit expected(unexpect_t, _Args&&... __args) noexcept(582 | ^583FAILED: [code=1] meson-internal__clang-tidy 584/nix/store/j2s018h6gc2q0z3sw002br2zas3m1l9d-meson-1.10.2/bin/meson --internal clangtidy /nix/var/nix/builds/nix-50839-4061795475/source /nix/var/nix/builds/nix-50839-4061795475/source/build --color always585ninja: build stopped: subcommand failed.