nix-grpc-store-clang-tidy-0.1.0-beta.4
checks.aarch64-linux.clang-tidy
· build #559
· raw
1tribuchet: building on eliza
unpackPhase
2unpacking source archive /nix/store/bxwih2dxlpmglg1ppazbgqvnz69hibm3-source3source root is sourceconfigurePhase
4mesonConfigurePhase flags: --prefix=/nix/store/wakiqq4hbcyr0lqyzg54961yphshwlsk-nix-grpc-store-clang-tidy-0.1.0-beta.4 --libdir=/nix/store/wakiqq4hbcyr0lqyzg54961yphshwlsk-nix-grpc-store-clang-tidy-0.1.0-beta.4/lib --libexecdir=/nix/store/wakiqq4hbcyr0lqyzg54961yphshwlsk-nix-grpc-store-clang-tidy-0.1.0-beta.4/libexec --bindir=/nix/store/wakiqq4hbcyr0lqyzg54961yphshwlsk-nix-grpc-store-clang-tidy-0.1.0-beta.4/bin --sbindir=/nix/store/wakiqq4hbcyr0lqyzg54961yphshwlsk-nix-grpc-store-clang-tidy-0.1.0-beta.4/sbin --includedir=/nix/store/wakiqq4hbcyr0lqyzg54961yphshwlsk-nix-grpc-store-clang-tidy-0.1.0-beta.4/include --mandir=/nix/store/wakiqq4hbcyr0lqyzg54961yphshwlsk-nix-grpc-store-clang-tidy-0.1.0-beta.4/share/man --infodir=/nix/store/wakiqq4hbcyr0lqyzg54961yphshwlsk-nix-grpc-store-clang-tidy-0.1.0-beta.4/share/info --localedir=/nix/store/wakiqq4hbcyr0lqyzg54961yphshwlsk-nix-grpc-store-clang-tidy-0.1.0-beta.4/share/locale -Dauto_features=enabled -Dwrap_mode=nodownload --buildtype=plain -Db_pch=false5The Meson build system6Version: 1.10.27Source dir: /build/source8Build dir: /build/source/build9Build type: native build10WARNING: Project does not target a minimum version but uses feature introduced in '1.1': meson.options file. Use meson_options.txt instead11Project name: nix-grpc-store12Project version: 0.1.0-beta.413C++ compiler for the host machine: clang++ (clang 22.1.8 "clang version 22.1.8")14C++ linker for the host machine: clang++ ld.bfd 2.4615Host machine cpu family: aarch6416Host machine cpu: aarch6417Found pkg-config: YES (/nix/store/96rqsbg8z242724qy85sbld7dbf4hipr-pkg-config-wrapper-0.29.2/bin/pkg-config) 0.29.218Run-time dependency grpc++ found: YES 1.83.019Run-time dependency protobuf found: YES 36.1.020Run-time dependency libzstd found: YES 1.5.721Run-time dependency threads found: YES22Run-time dependency libcrypto found: YES 3.6.423Run-time dependency prometheus-cpp-core found: YES 1.3.024Run-time dependency prometheus-cpp-pull found: YES 1.3.025Run-time dependency absl_flat_hash_map found: YES 2026010726Run-time dependency absl_hash found: YES 2026010727Run-time dependency absl_synchronization found: YES 2026010728Compiler for C++ supports arguments -Werror=thread-safety: YES 29Run-time dependency jemalloc found: YES 5.3.1_030Run-time dependency nix-store found: YES 2.36.0pre20260920_5711f8fe31Run-time dependency nix-util found: YES 2.36.0pre20260920_5711f8fe32Run-time dependency libcurl found: YES 8.22.033Run-time dependency nlohmann_json found: YES 3.12.034Check usable header "jwt-cpp/traits/nlohmann-json/defaults.h" : YES 35Program protoc found: YES (/nix/store/nxlmb8lkbnzwcj46mmsvn1gjrgzap7sw-protobuf-36.1/bin/protoc)36Program grpc_cpp_plugin found: YES (/nix/store/zsbcm1brz7v8ilrz6w8ij11yhbf8fyiv-grpc-1.83.0/bin/grpc_cpp_plugin)37Program mold found: YES (/nix/store/463q48w7fn9s93amh1y7jsyrws5sh8rm-mold-unwrapped-wrapper-2.42.1/bin/mold)38Run-time dependency dl found: YES39Program tests/farm-client-test.sh found: YES (/build/source/tests/farm-client-test.sh)40Program tests/oidc-test.sh found: YES (/build/source/tests/oidc-test.sh)41Build targets in project: 1342WARNING: Project specifies no minimum version but uses features which were added in versions:43 * 1.1: {'meson.options file'}4445nix-grpc-store 0.1.0-beta.44647 User defined options48 auto_features: enabled49 b_pch : false50 bindir : /nix/store/wakiqq4hbcyr0lqyzg54961yphshwlsk-nix-grpc-store-clang-tidy-0.1.0-beta.4/bin51 buildtype : plain52 includedir : /nix/store/wakiqq4hbcyr0lqyzg54961yphshwlsk-nix-grpc-store-clang-tidy-0.1.0-beta.4/include53 infodir : /nix/store/wakiqq4hbcyr0lqyzg54961yphshwlsk-nix-grpc-store-clang-tidy-0.1.0-beta.4/share/info54 libdir : /nix/store/wakiqq4hbcyr0lqyzg54961yphshwlsk-nix-grpc-store-clang-tidy-0.1.0-beta.4/lib55 libexecdir : /nix/store/wakiqq4hbcyr0lqyzg54961yphshwlsk-nix-grpc-store-clang-tidy-0.1.0-beta.4/libexec56 localedir : /nix/store/wakiqq4hbcyr0lqyzg54961yphshwlsk-nix-grpc-store-clang-tidy-0.1.0-beta.4/share/locale57 mandir : /nix/store/wakiqq4hbcyr0lqyzg54961yphshwlsk-nix-grpc-store-clang-tidy-0.1.0-beta.4/share/man58 prefix : /nix/store/wakiqq4hbcyr0lqyzg54961yphshwlsk-nix-grpc-store-clang-tidy-0.1.0-beta.459 sbindir : /nix/store/wakiqq4hbcyr0lqyzg54961yphshwlsk-nix-grpc-store-clang-tidy-0.1.0-beta.4/sbin60 wrap_mode : nodownload6162Found ninja-1.13.2 at /nix/store/ijbipgac9wyp1n5smvkd8fczs9jyr26g-ninja-1.13.2/bin/ninja63mesonConfigurePhase: enabled\ parallel\ buildingbuildPhase
64[1/2] Generating eds_proto with a custom command65[2/2] Generating nix_remote_proto with a custom command66[0/1] /nix/store/sc7hggvmvma7m8bbgmp8gsa1q1x37aq8-meson-1.10.2/bin/meson --internal clangtidy /build/source /build/source/build --color always67>>> /nix/store/7wgbxsfygsdmgsai483p205pkcpy6ls8-clang-tools-22.1.8/bin/clang-tidy --use-color -quiet -p /build/source/build /build/source/tests/log-spill-test.cc68../src/daemon/log-spill.hh:38:27: error: parameter name 'fd' is too short, expected at least 3 characters [readability-identifier-length,-warnings-as-errors]69 38 | explicit UniqueFd(int fd) noexcept : fd_(fd) {}70 | ^71../src/daemon/log-spill.hh:85:20: error: variable name 'at' is too short, expected at least 3 characters [readability-identifier-length,-warnings-as-errors]72 85 | auto const at = written_.load(std::memory_order_relaxed);73 | ^74../src/daemon/log-spill.hh:100:80: error: possibly unsafe 'operator[]', consider bounds-safe alternatives [cppcoreguidelines-pro-bounds-avoid-unchecked-container-access,-warnings-as-errors]75 100 | std::array<std::byte, kHeader> header{static_cast<std::byte>(kind), len[0], len[1], len[2], len[3]};76 | ^~~77../src/daemon/log-spill.hh:100:88: error: possibly unsafe 'operator[]', consider bounds-safe alternatives [cppcoreguidelines-pro-bounds-avoid-unchecked-container-access,-warnings-as-errors]78 100 | std::array<std::byte, kHeader> header{static_cast<std::byte>(kind), len[0], len[1], len[2], len[3]};79 | ^~~80../src/daemon/log-spill.hh:100:96: error: possibly unsafe 'operator[]', consider bounds-safe alternatives [cppcoreguidelines-pro-bounds-avoid-unchecked-container-access,-warnings-as-errors]81 100 | std::array<std::byte, kHeader> header{static_cast<std::byte>(kind), len[0], len[1], len[2], len[3]};82 | ^~~83../src/daemon/log-spill.hh:100:104: error: possibly unsafe 'operator[]', consider bounds-safe alternatives [cppcoreguidelines-pro-bounds-avoid-unchecked-container-access,-warnings-as-errors]84 100 | std::array<std::byte, kHeader> header{static_cast<std::byte>(kind), len[0], len[1], len[2], len[3]};85 | ^~~86../src/daemon/log-spill.hh:116:42: error: forwarding reference parameter 'fn' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward,-warnings-as-errors]87 116 | auto drain(std::size_t offset, Fn && fn) const -> std::size_t88 | ^89../src/daemon/log-spill.hh:116:42: error: parameter name 'fn' is too short, expected at least 3 characters [readability-identifier-length,-warnings-as-errors]90../src/daemon/log-spill.hh:128:67: error: possibly unsafe 'operator[]', consider bounds-safe alternatives [cppcoreguidelines-pro-bounds-avoid-unchecked-container-access,-warnings-as-errors]91 128 | auto const kind = std::to_integer<std::uint8_t>(header[0]);92 | ^~~93../src/daemon/log-spill.hh:149:25: error: variable name 'ec' is too short, expected at least 3 characters [readability-identifier-length,-warnings-as-errors]94 149 | std::error_code ec;95 | ^96../src/daemon/log-spill.hh:154:22: error: variable name 'fd' is too short, expected at least 3 characters [readability-identifier-length,-warnings-as-errors]97 154 | if (UniqueFd fd(::open(dir.c_str(), O_TMPFILE | O_RDWR | O_CLOEXEC, 0600)); fd) {98 | ^99../src/daemon/log-spill.hh:154:25: error: do not call c-style vararg functions [cppcoreguidelines-pro-type-vararg,-warnings-as-errors]100 154 | if (UniqueFd fd(::open(dir.c_str(), O_TMPFILE | O_RDWR | O_CLOEXEC, 0600)); fd) {101 | ^102../src/daemon/log-spill.hh:154:77: error: 0600 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers,-warnings-as-errors]103 154 | if (UniqueFd fd(::open(dir.c_str(), O_TMPFILE | O_RDWR | O_CLOEXEC, 0600)); fd) {104 | ^105../src/daemon/log-spill.hh:158:18: error: variable name 'fd' is too short, expected at least 3 characters [readability-identifier-length,-warnings-as-errors]106 158 | UniqueFd fd(::mkostemp(name.data(), O_CLOEXEC));107 | ^108../src/daemon/log-spill.hh:166:5: error: function 'writeAt' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]109 166 | auto writeAt(std::span<const std::byte> data, std::size_t offset) const -> bool110 | ^111 | [[nodiscard]] 112../src/daemon/log-spill.hh:169:24: error: variable name 'n' is too short, expected at least 3 characters [readability-identifier-length,-warnings-as-errors]113 169 | auto const n = ::pwrite(fd_.get(), data.data(), data.size(), static_cast<off_t>(offset));114 | ^115../src/daemon/log-spill.hh:182:5: error: function 'readAt' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]116 182 | auto readAt(std::span<std::byte> out, std::size_t offset) const -> bool117 | ^118 | [[nodiscard]] 119../src/daemon/log-spill.hh:185:24: error: variable name 'n' is too short, expected at least 3 characters [readability-identifier-length,-warnings-as-errors]120 185 | auto const n = ::pread(fd_.get(), out.data(), out.size(), static_cast<off_t>(offset));121 | ^122../src/daemon/log-spill.hh:212:31: error: parameter name 'cv' is too short, expected at least 3 characters [readability-identifier-length,-warnings-as-errors]123 212 | std::condition_variable & cv,124 | ^125../src/daemon/log-spill.hh:215:18: error: forwarding reference parameter 'cancelled' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward,-warnings-as-errors]126 215 | Cancelled && cancelled,127 | ^128../src/daemon/log-spill.hh:216:13: error: forwarding reference parameter 'emit' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward,-warnings-as-errors]129 216 | Emit && emit) -> bool130 | ^131../src/daemon/log-spill.hh:232:16: error: 'wait_for' should be placed inside a while statement or used with a conditional parameter [bugprone-spuriously-wake-up-functions,cert-con36-c,cert-con54-cpp,-warnings-as-errors]132 232 | cv.wait_for(lock, poll);133 | ^134../tests/log-spill-test.cc:1:1: error: included header atomic is not used directly [misc-include-cleaner,-warnings-as-errors]135 1 | #include <atomic>136 | ^~~~~~~~~~~~~~~~~137 2 | #include <cassert>138../tests/log-spill-test.cc:23:45: error: no header providing "std::string_view" is directly included [misc-include-cleaner,-warnings-as-errors]139 8 | #include <thread>140 9 | #include <utility>141 10 | #include <vector>142 11 | 143 12 | #include "log-spill.hh"144 13 | 145 14 | using nixgrpc::LogSpill;146 15 | using nixgrpc::SpillKind;147 16 | using Records = std::vector<std::pair<SpillKind, std::string>>;148 17 | 149 18 | namespace {150 19 | 151 20 | auto readAll(const LogSpill & spill) -> Records152 21 | {153 22 | Records out;154 23 | spill.drain(0, [&](SpillKind kind, std::string_view text) -> void { out.emplace_back(kind, std::string(text)); });155 | ^156../tests/log-spill-test.cc:27:83: error: parameter name 'cv' is too short, expected at least 3 characters [readability-identifier-length,-warnings-as-errors]157 27 | auto follow(const LogSpill & spill, std::mutex & mutex, std::condition_variable & cv, const bool & finished) -> Records158 | ^159../tests/log-spill-test.cc:44:47: error: 300000 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers,-warnings-as-errors]160 44 | spill.append(SpillKind::line, std::string(300000, 'x'));161 | ^162../tests/log-spill-test.cc:47:15: error: possibly unsafe 'operator[]', consider bounds-safe alternatives [cppcoreguidelines-pro-bounds-avoid-unchecked-container-access,-warnings-as-errors]163 47 | assert(got[0] == std::make_pair(SpillKind::line, std::string("first")));164 | ^165/nix/store/6rgkfqr5mcjr39irv7wlbhfih2r5s2nl-glibc-2.42-84-dev/include/assert.h:100:27: note: expanded from macro 'assert'166 100 | (static_cast <bool> (expr) \167 | ^~~~168../tests/log-spill-test.cc:48:15: error: possibly unsafe 'operator[]', consider bounds-safe alternatives [cppcoreguidelines-pro-bounds-avoid-unchecked-container-access,-warnings-as-errors]169 48 | assert(got[1] == std::make_pair(SpillKind::phase, std::string("build")));170 | ^171/nix/store/6rgkfqr5mcjr39irv7wlbhfih2r5s2nl-glibc-2.42-84-dev/include/assert.h:100:27: note: expanded from macro 'assert'172 100 | (static_cast <bool> (expr) \173 | ^~~~174../tests/log-spill-test.cc:49:15: error: possibly unsafe 'operator[]', consider bounds-safe alternatives [cppcoreguidelines-pro-bounds-avoid-unchecked-container-access,-warnings-as-errors]175 49 | assert(got[2].second.empty());176 | ^177/nix/store/6rgkfqr5mcjr39irv7wlbhfih2r5s2nl-glibc-2.42-84-dev/include/assert.h:100:27: note: expanded from macro 'assert'178 100 | (static_cast <bool> (expr) \179 | ^~~~180../tests/log-spill-test.cc:50:15: error: possibly unsafe 'operator[]', consider bounds-safe alternatives [cppcoreguidelines-pro-bounds-avoid-unchecked-container-access,-warnings-as-errors]181 50 | assert(got[3].second.size() == 300000);182 | ^183/nix/store/6rgkfqr5mcjr39irv7wlbhfih2r5s2nl-glibc-2.42-84-dev/include/assert.h:100:27: note: expanded from macro 'assert'184 100 | (static_cast <bool> (expr) \185 | ^~~~186../tests/log-spill-test.cc:57:36: error: possibly unsafe 'operator[]', consider bounds-safe alternatives [cppcoreguidelines-pro-bounds-avoid-unchecked-container-access,-warnings-as-errors]187 57 | assert(rest.size() == 1 && rest[0].second == "later");188 | ^189/nix/store/6rgkfqr5mcjr39irv7wlbhfih2r5s2nl-glibc-2.42-84-dev/include/assert.h:100:27: note: expanded from macro 'assert'190 100 | (static_cast <bool> (expr) \191 | ^~~~192../tests/log-spill-test.cc:63:68: error: 5 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers,-warnings-as-errors]193 63 | spill.append(SpillKind::line, std::string(LogSpill::kMaxText + 5, 'x'));194 | ^195../tests/log-spill-test.cc:65:34: error: possibly unsafe 'operator[]', consider bounds-safe alternatives [cppcoreguidelines-pro-bounds-avoid-unchecked-container-access,-warnings-as-errors]196 65 | assert(got.size() == 1 && got[0].second.size() == LogSpill::kMaxText);197 | ^198/nix/store/6rgkfqr5mcjr39irv7wlbhfih2r5s2nl-glibc-2.42-84-dev/include/assert.h:100:27: note: expanded from macro 'assert'199 100 | (static_cast <bool> (expr) \200 | ^~~~201../tests/log-spill-test.cc:70:20: error: 64 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers,-warnings-as-errors]202 70 | LogSpill spill(64);203 | ^204../tests/log-spill-test.cc:71:25: error: 50 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers,-warnings-as-errors]205 71 | for (int i = 0; i < 50; i++) {206 | ^207../tests/log-spill-test.cc:85:36: error: possibly unsafe 'operator[]', consider bounds-safe alternatives [cppcoreguidelines-pro-bounds-avoid-unchecked-container-access,-warnings-as-errors]208 85 | assert(only.size() == 1 && only[0].second == LogSpill::kTruncated);209 | ^210/nix/store/6rgkfqr5mcjr39irv7wlbhfih2r5s2nl-glibc-2.42-84-dev/include/assert.h:100:27: note: expanded from macro 'assert'211 100 | (static_cast <bool> (expr) \212 | ^~~~213../tests/log-spill-test.cc:90:5: error: function is not thread safe [concurrency-mt-unsafe,-warnings-as-errors]214 90 | setenv("TMPDIR", "/nonexistent-dir", 1);215 | ^216../tests/log-spill-test.cc:90:5: error: no header providing "setenv" is directly included [misc-include-cleaner,-warnings-as-errors]217 7 | setenv("TMPDIR", "/nonexistent-dir", 1);218 | ^219../tests/log-spill-test.cc:95:5: error: function is not thread safe [concurrency-mt-unsafe,-warnings-as-errors]220 95 | unsetenv("TMPDIR");221 | ^222../tests/log-spill-test.cc:95:5: error: no header providing "unsetenv" is directly included [misc-include-cleaner,-warnings-as-errors]223../tests/log-spill-test.cc:103:29: error: variable name 'cv' is too short, expected at least 3 characters [readability-identifier-length,-warnings-as-errors]224 103 | std::condition_variable cv;225 | ^226../tests/log-spill-test.cc:119:30: error: 1000 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers,-warnings-as-errors]227 119 | while (spill.written() < 1000) {228 | ^229../tests/log-spill-test.cc:129:26: error: possibly unsafe 'operator[]', consider bounds-safe alternatives [cppcoreguidelines-pro-bounds-avoid-unchecked-container-access,-warnings-as-errors]230 129 | assert((*got)[static_cast<std::size_t>(i)].second == "line " + std::to_string(i));231 | ^232/nix/store/6rgkfqr5mcjr39irv7wlbhfih2r5s2nl-glibc-2.42-84-dev/include/assert.h:100:27: note: expanded from macro 'assert'233 100 | (static_cast <bool> (expr) \234 | ^~~~235../tests/log-spill-test.cc:138:29: error: variable name 'cv' is too short, expected at least 3 characters [readability-identifier-length,-warnings-as-errors]236 138 | std::condition_variable cv;237 | ^238>>> /nix/store/7wgbxsfygsdmgsai483p205pkcpy6ls8-clang-tools-22.1.8/bin/clang-tidy --use-color -quiet -p /build/source/build /build/source/src/client/channel.cc239[1/1] (1/2) Processing file /build/source/src/client/channel.cc.240[1/1] (2/2) Processing file /build/source/src/client/channel.cc.241>>> /nix/store/7wgbxsfygsdmgsai483p205pkcpy6ls8-clang-tools-22.1.8/bin/clang-tidy --use-color -quiet -p /build/source/build /build/source/src/daemon/coordinator.cc242../src/daemon/log-spill.hh:38:27: error: parameter name 'fd' is too short, expected at least 3 characters [readability-identifier-length,-warnings-as-errors]243 38 | explicit UniqueFd(int fd) noexcept : fd_(fd) {}244 | ^245../src/daemon/log-spill.hh:85:20: error: variable name 'at' is too short, expected at least 3 characters [readability-identifier-length,-warnings-as-errors]246 85 | auto const at = written_.load(std::memory_order_relaxed);247 | ^248../src/daemon/log-spill.hh:100:80: error: possibly unsafe 'operator[]', consider bounds-safe alternatives [cppcoreguidelines-pro-bounds-avoid-unchecked-container-access,-warnings-as-errors]249 100 | std::array<std::byte, kHeader> header{static_cast<std::byte>(kind), len[0], len[1], len[2], len[3]};250 | ^~~251../src/daemon/log-spill.hh:100:88: error: possibly unsafe 'operator[]', consider bounds-safe alternatives [cppcoreguidelines-pro-bounds-avoid-unchecked-container-access,-warnings-as-errors]252 100 | std::array<std::byte, kHeader> header{static_cast<std::byte>(kind), len[0], len[1], len[2], len[3]};253 | ^~~254../src/daemon/log-spill.hh:100:96: error: possibly unsafe 'operator[]', consider bounds-safe alternatives [cppcoreguidelines-pro-bounds-avoid-unchecked-container-access,-warnings-as-errors]255 100 | std::array<std::byte, kHeader> header{static_cast<std::byte>(kind), len[0], len[1], len[2], len[3]};256 | ^~~257../src/daemon/log-spill.hh:100:104: error: possibly unsafe 'operator[]', consider bounds-safe alternatives [cppcoreguidelines-pro-bounds-avoid-unchecked-container-access,-warnings-as-errors]258 100 | std::array<std::byte, kHeader> header{static_cast<std::byte>(kind), len[0], len[1], len[2], len[3]};259 | ^~~260../src/daemon/log-spill.hh:116:42: error: forwarding reference parameter 'fn' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward,-warnings-as-errors]261 116 | auto drain(std::size_t offset, Fn && fn) const -> std::size_t262 | ^263../src/daemon/log-spill.hh:116:42: error: parameter name 'fn' is too short, expected at least 3 characters [readability-identifier-length,-warnings-as-errors]264../src/daemon/log-spill.hh:128:67: error: possibly unsafe 'operator[]', consider bounds-safe alternatives [cppcoreguidelines-pro-bounds-avoid-unchecked-container-access,-warnings-as-errors]265 128 | auto const kind = std::to_integer<std::uint8_t>(header[0]);266 | ^~~267../src/daemon/log-spill.hh:149:25: error: variable name 'ec' is too short, expected at least 3 characters [readability-identifier-length,-warnings-as-errors]268 149 | std::error_code ec;269 | ^270../src/daemon/log-spill.hh:154:22: error: variable name 'fd' is too short, expected at least 3 characters [readability-identifier-length,-warnings-as-errors]271 154 | if (UniqueFd fd(::open(dir.c_str(), O_TMPFILE | O_RDWR | O_CLOEXEC, 0600)); fd) {272 | ^273../src/daemon/log-spill.hh:154:25: error: do not call c-style vararg functions [cppcoreguidelines-pro-type-vararg,-warnings-as-errors]274 154 | if (UniqueFd fd(::open(dir.c_str(), O_TMPFILE | O_RDWR | O_CLOEXEC, 0600)); fd) {275 | ^276../src/daemon/log-spill.hh:154:77: error: 0600 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers,-warnings-as-errors]277 154 | if (UniqueFd fd(::open(dir.c_str(), O_TMPFILE | O_RDWR | O_CLOEXEC, 0600)); fd) {278 | ^279../src/daemon/log-spill.hh:158:18: error: variable name 'fd' is too short, expected at least 3 characters [readability-identifier-length,-warnings-as-errors]280 158 | UniqueFd fd(::mkostemp(name.data(), O_CLOEXEC));281 | ^282../src/daemon/log-spill.hh:166:5: error: function 'writeAt' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]283 166 | auto writeAt(std::span<const std::byte> data, std::size_t offset) const -> bool284 | ^285 | [[nodiscard]] 286../src/daemon/log-spill.hh:169:24: error: variable name 'n' is too short, expected at least 3 characters [readability-identifier-length,-warnings-as-errors]287 169 | auto const n = ::pwrite(fd_.get(), data.data(), data.size(), static_cast<off_t>(offset));288 | ^289../src/daemon/log-spill.hh:182:5: error: function 'readAt' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]290 182 | auto readAt(std::span<std::byte> out, std::size_t offset) const -> bool291 | ^292 | [[nodiscard]] 293../src/daemon/log-spill.hh:185:24: error: variable name 'n' is too short, expected at least 3 characters [readability-identifier-length,-warnings-as-errors]294 185 | auto const n = ::pread(fd_.get(), out.data(), out.size(), static_cast<off_t>(offset));295 | ^296../src/daemon/log-spill.hh:212:31: error: parameter name 'cv' is too short, expected at least 3 characters [readability-identifier-length,-warnings-as-errors]297 212 | std::condition_variable & cv,298 | ^299../src/daemon/log-spill.hh:215:18: error: forwarding reference parameter 'cancelled' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward,-warnings-as-errors]300 215 | Cancelled && cancelled,301 | ^302../src/daemon/log-spill.hh:216:13: error: forwarding reference parameter 'emit' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward,-warnings-as-errors]303 216 | Emit && emit) -> bool304 | ^305../src/daemon/log-spill.hh:232:16: error: 'wait_for' should be placed inside a while statement or used with a conditional parameter [bugprone-spuriously-wake-up-functions,cert-con36-c,cert-con54-cpp,-warnings-as-errors]306 232 | cv.wait_for(lock, poll);307 | ^308>>> /nix/store/7wgbxsfygsdmgsai483p205pkcpy6ls8-clang-tools-22.1.8/bin/clang-tidy --use-color -quiet -p /build/source/build /build/source/src/daemon/main.cc309Errors encountered while running clang-tidy310../src/daemon/log-spill.hh:38:27: error: parameter name 'fd' is too short, expected at least 3 characters [readability-identifier-length,-warnings-as-errors]311 38 | explicit UniqueFd(int fd) noexcept : fd_(fd) {}312 | ^313../src/daemon/log-spill.hh:85:20: error: variable name 'at' is too short, expected at least 3 characters [readability-identifier-length,-warnings-as-errors]314 85 | auto const at = written_.load(std::memory_order_relaxed);315 | ^316../src/daemon/log-spill.hh:100:80: error: possibly unsafe 'operator[]', consider bounds-safe alternatives [cppcoreguidelines-pro-bounds-avoid-unchecked-container-access,-warnings-as-errors]317 100 | std::array<std::byte, kHeader> header{static_cast<std::byte>(kind), len[0], len[1], len[2], len[3]};318 | ^~~319../src/daemon/log-spill.hh:100:88: error: possibly unsafe 'operator[]', consider bounds-safe alternatives [cppcoreguidelines-pro-bounds-avoid-unchecked-container-access,-warnings-as-errors]320 100 | std::array<std::byte, kHeader> header{static_cast<std::byte>(kind), len[0], len[1], len[2], len[3]};321 | ^~~322../src/daemon/log-spill.hh:100:96: error: possibly unsafe 'operator[]', consider bounds-safe alternatives [cppcoreguidelines-pro-bounds-avoid-unchecked-container-access,-warnings-as-errors]323 100 | std::array<std::byte, kHeader> header{static_cast<std::byte>(kind), len[0], len[1], len[2], len[3]};324 | ^~~325../src/daemon/log-spill.hh:100:104: error: possibly unsafe 'operator[]', consider bounds-safe alternatives [cppcoreguidelines-pro-bounds-avoid-unchecked-container-access,-warnings-as-errors]326 100 | std::array<std::byte, kHeader> header{static_cast<std::byte>(kind), len[0], len[1], len[2], len[3]};327 | ^~~328../src/daemon/log-spill.hh:116:42: error: forwarding reference parameter 'fn' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward,-warnings-as-errors]329 116 | auto drain(std::size_t offset, Fn && fn) const -> std::size_t330 | ^331../src/daemon/log-spill.hh:116:42: error: parameter name 'fn' is too short, expected at least 3 characters [readability-identifier-length,-warnings-as-errors]332../src/daemon/log-spill.hh:128:67: error: possibly unsafe 'operator[]', consider bounds-safe alternatives [cppcoreguidelines-pro-bounds-avoid-unchecked-container-access,-warnings-as-errors]333 128 | auto const kind = std::to_integer<std::uint8_t>(header[0]);334 | ^~~335../src/daemon/log-spill.hh:149:25: error: variable name 'ec' is too short, expected at least 3 characters [readability-identifier-length,-warnings-as-errors]336 149 | std::error_code ec;337 | ^338../src/daemon/log-spill.hh:154:22: error: variable name 'fd' is too short, expected at least 3 characters [readability-identifier-length,-warnings-as-errors]339 154 | if (UniqueFd fd(::open(dir.c_str(), O_TMPFILE | O_RDWR | O_CLOEXEC, 0600)); fd) {340 | ^341../src/daemon/log-spill.hh:154:25: error: do not call c-style vararg functions [cppcoreguidelines-pro-type-vararg,-warnings-as-errors]342 154 | if (UniqueFd fd(::open(dir.c_str(), O_TMPFILE | O_RDWR | O_CLOEXEC, 0600)); fd) {343 | ^344../src/daemon/log-spill.hh:154:77: error: 0600 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers,-warnings-as-errors]345 154 | if (UniqueFd fd(::open(dir.c_str(), O_TMPFILE | O_RDWR | O_CLOEXEC, 0600)); fd) {346 | ^347../src/daemon/log-spill.hh:158:18: error: variable name 'fd' is too short, expected at least 3 characters [readability-identifier-length,-warnings-as-errors]348 158 | UniqueFd fd(::mkostemp(name.data(), O_CLOEXEC));349 | ^350../src/daemon/log-spill.hh:166:5: error: function 'writeAt' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]351 166 | auto writeAt(std::span<const std::byte> data, std::size_t offset) const -> bool352 | ^353 | [[nodiscard]] 354../src/daemon/log-spill.hh:169:24: error: variable name 'n' is too short, expected at least 3 characters [readability-identifier-length,-warnings-as-errors]355 169 | auto const n = ::pwrite(fd_.get(), data.data(), data.size(), static_cast<off_t>(offset));356 | ^357../src/daemon/log-spill.hh:182:5: error: function 'readAt' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]358 182 | auto readAt(std::span<std::byte> out, std::size_t offset) const -> bool359 | ^360 | [[nodiscard]] 361../src/daemon/log-spill.hh:185:24: error: variable name 'n' is too short, expected at least 3 characters [readability-identifier-length,-warnings-as-errors]362 185 | auto const n = ::pread(fd_.get(), out.data(), out.size(), static_cast<off_t>(offset));363 | ^364../src/daemon/log-spill.hh:212:31: error: parameter name 'cv' is too short, expected at least 3 characters [readability-identifier-length,-warnings-as-errors]365 212 | std::condition_variable & cv,366 | ^367../src/daemon/log-spill.hh:215:18: error: forwarding reference parameter 'cancelled' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward,-warnings-as-errors]368 215 | Cancelled && cancelled,369 | ^370../src/daemon/log-spill.hh:216:13: error: forwarding reference parameter 'emit' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward,-warnings-as-errors]371 216 | Emit && emit) -> bool372 | ^373../src/daemon/log-spill.hh:232:16: error: 'wait_for' should be placed inside a while statement or used with a conditional parameter [bugprone-spuriously-wake-up-functions,cert-con36-c,cert-con54-cpp,-warnings-as-errors]374 232 | cv.wait_for(lock, poll);375 | ^376../src/daemon/main.cc:96:41: error: no header providing "nixgrpc::SpillKind" is directly included [misc-include-cleaner,-warnings-as-errors]377 71 | static_assert(static_cast<int>(nixgrpc::SpillKind::line) == static_cast<int>(nixgrpc::BuildEvent::Kind::line));378 | ^379../src/daemon/main.cc:507:41: error: no header providing "nixgrpc::followSpill" is directly included [misc-include-cleaner,-warnings-as-errors]380 507 | auto const completed = nixgrpc::followSpill(381 | ^382FAILED: [code=1] meson-internal__clang-tidy 383/nix/store/sc7hggvmvma7m8bbgmp8gsa1q1x37aq8-meson-1.10.2/bin/meson --internal clangtidy /build/source /build/source/build --color always384ninja: build stopped: subcommand failed.