nix-grpc-store-clang-tidy-0.1.0
checks.aarch64-darwin.clang-tidy
· build #69
· raw
unpackPhase
1unpacking source archive /nix/store/nbwclyvpgrkmw42l3kg495b4mip5y5sj-source2source root is sourceconfigurePhase
3mesonConfigurePhase flags: --prefix=/nix/store/a0jsyacima3hmqzrnsrqpih1x3v7x7yd-nix-grpc-store-clang-tidy-0.1.0 --libdir=/nix/store/a0jsyacima3hmqzrnsrqpih1x3v7x7yd-nix-grpc-store-clang-tidy-0.1.0/lib --libexecdir=/nix/store/a0jsyacima3hmqzrnsrqpih1x3v7x7yd-nix-grpc-store-clang-tidy-0.1.0/libexec --bindir=/nix/store/a0jsyacima3hmqzrnsrqpih1x3v7x7yd-nix-grpc-store-clang-tidy-0.1.0/bin --sbindir=/nix/store/a0jsyacima3hmqzrnsrqpih1x3v7x7yd-nix-grpc-store-clang-tidy-0.1.0/sbin --includedir=/nix/store/a0jsyacima3hmqzrnsrqpih1x3v7x7yd-nix-grpc-store-clang-tidy-0.1.0/include --mandir=/nix/store/a0jsyacima3hmqzrnsrqpih1x3v7x7yd-nix-grpc-store-clang-tidy-0.1.0/share/man --infodir=/nix/store/a0jsyacima3hmqzrnsrqpih1x3v7x7yd-nix-grpc-store-clang-tidy-0.1.0/share/info --localedir=/nix/store/a0jsyacima3hmqzrnsrqpih1x3v7x7yd-nix-grpc-store-clang-tidy-0.1.0/share/locale -Dauto_features=enabled -Dwrap_mode=nodownload --buildtype=plain4The Meson build system5Version: 1.10.26Source dir: /nix/var/nix/builds/nix-50194-160511831/source7Build dir: /nix/var/nix/builds/nix-50194-160511831/source/build8Build type: native build9WARNING: Project does not target a minimum version but uses feature introduced in '1.1': meson.options file. Use meson_options.txt instead10Project name: nix-grpc-store11Project version: 0.1.012C++ compiler for the host machine: clang++ (clang 21.1.8 "clang version 21.1.8")13C++ linker for the host machine: clang++ ld64 956.614Host machine cpu family: aarch6415Host machine cpu: aarch6416Found pkg-config: YES (/nix/store/lqahvywm9fgdhi7lwz4y56dkamsg7z0s-pkg-config-wrapper-0.29.2/bin/pkg-config) 0.29.217Run-time dependency grpc++ found: YES 1.83.018Run-time dependency protobuf found: YES 35.1.019Run-time dependency libzstd found: YES 1.5.720Run-time dependency threads found: YES21Run-time dependency libcrypto found: YES 3.6.322Run-time dependency prometheus-cpp-core found: YES 1.3.023Run-time dependency prometheus-cpp-pull found: YES 1.3.024Run-time dependency nix-store found: YES 2.36.0pre20260831_b983ba8125Run-time dependency nix-util found: YES 2.36.0pre20260831_b983ba8126Program protoc found: YES (/nix/store/v7ijrik242ylbl098071amfs9wzks07i-protobuf-35.1/bin/protoc)27Program grpc_cpp_plugin found: YES (/nix/store/1yhx18kvaf265sfyf6vbzggdvya4q3i5-grpc-1.83.0/bin/grpc_cpp_plugin)28Run-time dependency dl found: YES29Build targets in project: 430WARNING: Project specifies no minimum version but uses features which were added in versions:31 * 1.1: {'meson.options file'}3233nix-grpc-store 0.1.03435 User defined options36 auto_features: enabled37 bindir : /nix/store/a0jsyacima3hmqzrnsrqpih1x3v7x7yd-nix-grpc-store-clang-tidy-0.1.0/bin38 buildtype : plain39 includedir : /nix/store/a0jsyacima3hmqzrnsrqpih1x3v7x7yd-nix-grpc-store-clang-tidy-0.1.0/include40 infodir : /nix/store/a0jsyacima3hmqzrnsrqpih1x3v7x7yd-nix-grpc-store-clang-tidy-0.1.0/share/info41 libdir : /nix/store/a0jsyacima3hmqzrnsrqpih1x3v7x7yd-nix-grpc-store-clang-tidy-0.1.0/lib42 libexecdir : /nix/store/a0jsyacima3hmqzrnsrqpih1x3v7x7yd-nix-grpc-store-clang-tidy-0.1.0/libexec43 localedir : /nix/store/a0jsyacima3hmqzrnsrqpih1x3v7x7yd-nix-grpc-store-clang-tidy-0.1.0/share/locale44 mandir : /nix/store/a0jsyacima3hmqzrnsrqpih1x3v7x7yd-nix-grpc-store-clang-tidy-0.1.0/share/man45 prefix : /nix/store/a0jsyacima3hmqzrnsrqpih1x3v7x7yd-nix-grpc-store-clang-tidy-0.1.046 sbindir : /nix/store/a0jsyacima3hmqzrnsrqpih1x3v7x7yd-nix-grpc-store-clang-tidy-0.1.0/sbin47 wrap_mode : nodownload4849Found ninja-1.13.2 at /nix/store/gan2c2gpw4w1yi2r5asx6a087fa2a759-ninja-1.13.2/bin/ninja50mesonConfigurePhase: enabled\ parallel\ buildingbuildPhase
51[1/1] Generating nix_remote_proto with a custom command52[0/1] /nix/store/by8lz2aj6nw13mm1mv08vr1gqlmz0ih5-meson-1.10.2/bin/meson --internal clangtidy /nix/var/nix/builds/nix-50194-160511831/source /nix/var/nix/builds/nix-50194-160511831/source/build --color always53>>> /nix/store/fb8ffdcrnbxq6h7khli0k8pf4vk4ds66-clang-tools-22.1.8/bin/clang-tidy --use-color -quiet -p /nix/var/nix/builds/nix-50194-160511831/source/build /nix/var/nix/builds/nix-50194-160511831/source/src/plugin-loader.cc54Error while processing /nix/var/nix/builds/nix-50194-160511831/source/src/plugin-loader.cc.55../version:1:1: error: expected unqualified-id [clang-diagnostic-error]56 1 | 0.1.057 | ^58>>> /nix/store/fb8ffdcrnbxq6h7khli0k8pf4vk4ds66-clang-tools-22.1.8/bin/clang-tidy --use-color -quiet -p /nix/var/nix/builds/nix-50194-160511831/source/build /nix/var/nix/builds/nix-50194-160511831/source/src/nix-grpc-daemon.cc59Error while processing /nix/var/nix/builds/nix-50194-160511831/source/src/nix-grpc-daemon.cc.60error: too many errors emitted, stopping now [clang-diagnostic-error]61../src/acl.hh:51:7: error: constructor does not initialize these fields: rules [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]62 51 | class Acl63 | ^64 52 | {65 53 | struct Rule66 54 | {67 55 | std::string pattern;68 56 | Role role;69 57 | };70 58 | 71 59 | std::vector<Rule> rules;72 | 73 | {}74../src/acl.hh:70:10: error: method 'addRule' can be made static [readability-convert-member-functions-to-static,-warnings-as-errors]75 70 | void addRule(std::string_view spec)76 | ^77 | static 78../src/acl.hh:95:24: error: method 'roleFor' can be made static [readability-convert-member-functions-to-static,-warnings-as-errors]79 95 | [[nodiscard]] auto roleFor(const std::optional<std::string> & commonName) const -> std::optional<Role>80 | ^ ~~~~~81 | static 82../src/logfmt.hh:61:23: error: the value returned by this function should not be disregarded; neglecting it may lead to errors [cert-err33-c,-warnings-as-errors]83 61 | static_cast<void>(std::strftime(timestamp.data(), timestamp.size(), "%Y-%m-%dT%H:%M:%SZ", &utc));84 | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~85../src/logfmt.hh:61:23: note: cast the expression to void to silence this warning86../src/metrics.hh:37:5: error: constructor does not initialize these fields: exposer [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]87 17 | explicit Metrics(const std::string & listen)88 | ^89../src/metrics.hh:50:59: error: 2 adjacent parameters of 'countTunnelBytes' of similar type ('uint64_t') are easily swapped by mistake [bugprone-easily-swappable-parameters,-warnings-as-errors]90 50 | void countTunnelBytes(const std::string & commonName, uint64_t bytesIn, uint64_t bytesOut)91 | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~92../src/metrics.hh:50:68: note: the first parameter in the range is 'bytesIn'93 50 | void countTunnelBytes(const std::string & commonName, uint64_t bytesIn, uint64_t bytesOut)94 | ^~~~~~~95../src/metrics.hh:50:86: note: the last parameter in the range is 'bytesOut'96 50 | void countTunnelBytes(const std::string & commonName, uint64_t bytesIn, uint64_t bytesOut)97 | ^~~~~~~~98../src/nix-grpc-daemon.cc:17:1: error: included header filesystem is not used directly [misc-include-cleaner,-warnings-as-errors]99 17 | #include <filesystem>100 | ^~~~~~~~~~~~~~~~~~~~~101 18 | #include <functional>102../src/nix-grpc-daemon.cc:27:1: error: included header vector is not used directly [misc-include-cleaner,-warnings-as-errors]103 27 | #include <vector>104 | ^~~~~~~~~~~~~~~~~105 28 | 106../src/nix-grpc-daemon.cc:46:1: error: included header store-open.hh is not used directly [misc-include-cleaner,-warnings-as-errors]107 46 | #include <nix/store/store-open.hh>108 | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~109 47 | #include <nix/store/worker-protocol.hh>110../src/nix-grpc-daemon.cc:80:24: error: member 'metrics' of type 'nixgrpc::Metrics &' is a reference [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]111 80 | nixgrpc::Metrics & metrics;112 | ^113../src/nix-grpc-daemon.cc:137:10: error: method 'authorize' can be made static [readability-convert-member-functions-to-static,-warnings-as-errors]114 137 | auto authorize(const std::optional<std::string> & cert, std::string_view method, nixgrpc::Role minRole)115 | ^116 | static 117../src/nix-grpc-daemon.cc:164:9: error: 2 adjacent parameters of 'NixRemoteService' of similar type ('std::string') are easily swapped by mistake [bugprone-easily-swappable-parameters,-warnings-as-errors]118 164 | std::string socketPath,119 | ^~~~~~~~~~~~~~~~~~~~~~~120 165 | std::string storeUri,121 | ~~~~~~~~~~~~~~~~~~~~122../src/nix-grpc-daemon.cc:164:21: note: the first parameter in the range is 'socketPath'123 164 | std::string socketPath,124 | ^~~~~~~~~~125../src/nix-grpc-daemon.cc:165:21: note: the last parameter in the range is 'storeUri'126 165 | std::string storeUri,127 | ^~~~~~~~128../src/nix-grpc-daemon.cc:247:31: error: variable 'paths' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]129 247 | nix::StorePathSet paths;130 | ^ 131 | = 0132../src/nix-grpc-daemon.cc:531:48: error: the parameter 'line' of type 'std::string' (aka 'basic_string<char>') is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]133 531 | auto sendLogLine = [&](std::string line) -> void {134 | ^135 | const &136../src/nix-grpc-daemon.cc:540:13: error: variable 'drvSource' of type 'nix::StringSource' can be declared 'const' [misc-const-correctness,-warnings-as-errors]137 540 | nix::StringSource drvSource(request->drv());138 | ^139 | const 140../src/nix-grpc-daemon.cc:620:48: error: the parameter 'line' of type 'std::string' (aka 'basic_string<char>') is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]141 620 | auto sendLogLine = [&](std::string line) -> void {142 | ^143 | const &144../src/nix-grpc-daemon.cc:644:17: error: variable 'sink' of type 'nix::StringSink' can be declared 'const' [misc-const-correctness,-warnings-as-errors]145 644 | nix::StringSink sink;146 | ^147 | const 148../src/nix-grpc-daemon.cc:651:31: error: variable 'outputPaths' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]149 651 | nix::StorePathSet outputPaths;150 | ^ 151 | = 0152../src/nix-grpc-daemon.cc:834:6: error: an exception may be thrown in function 'main' which should not throw exceptions [bugprone-exception-escape,-warnings-as-errors]153 834 | auto main(int argc, char ** argv) -> int154 | ^155../src/nix-grpc-daemon.cc:862:9: note: frame #0: unhandled exception of type 'nix::Error' may be thrown in function 'main' here156 862 | throw nix::Error("failed to start gRPC server on '%s'", options.listen);157 | ^158../src/pump.hh:65:27: error: 2 adjacent parameters of 'readCoalesced' of similar type ('int') are easily swapped by mistake [bugprone-easily-swappable-parameters,-warnings-as-errors]159 65 | inline auto readCoalesced(int sourceFd, std::span<char> buf) -> ssize_t160 | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~161../src/pump.hh:65:31: note: the first parameter in the range is 'sourceFd'162 65 | inline auto readCoalesced(int sourceFd, std::span<char> buf) -> ssize_t163 | ^~~~~~~~164../src/pump.hh:65:57: note: the last parameter in the range is 'buf'165 65 | inline auto readCoalesced(int sourceFd, std::span<char> buf) -> ssize_t166 | ^~~167../src/pump.hh:159:23: error: variable 'count' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]168 159 | ssize_t const count = readCoalesced(sourceFd, input);169 | ^ 170 | = 0171../src/pump.hh:276:44: error: the parameter 'initial' of type 'std::string' (aka 'basic_string<char>') is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]172 276 | static auto makeInitialMsg(std::string initial) -> Msg173 | ^174 | const &175../version:1:1: error: expected unqualified-id [clang-diagnostic-error]176 1 | 0.1.0177 | ^178>>> /nix/store/fb8ffdcrnbxq6h7khli0k8pf4vk4ds66-clang-tools-22.1.8/bin/clang-tidy --use-color -quiet -p /nix/var/nix/builds/nix-50194-160511831/source/build /nix/var/nix/builds/nix-50194-160511831/source/src/grpc-store.cc179Errors encountered while running clang-tidy180Error while processing /nix/var/nix/builds/nix-50194-160511831/source/src/grpc-store.cc.181error: too many errors emitted, stopping now [clang-diagnostic-error]182../src/grpc-store.cc:22:1: error: included header map is not used directly [misc-include-cleaner,-warnings-as-errors]183 22 | #include <map>184 | ^~~~~~~~~~~~~~185 23 | #include <memory>186../src/grpc-store.cc:30:1: error: included header environment-variables.hh is not used directly [misc-include-cleaner,-warnings-as-errors]187 30 | #include <nix/util/environment-variables.hh>188 | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~189 31 | #include <nix/util/error.hh>190../src/grpc-store.cc:37:1: error: included header types.hh is not used directly [misc-include-cleaner,-warnings-as-errors]191 37 | #include <nix/util/types.hh>192 | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~193 38 | #include <nix/util/util.hh>194../src/grpc-store.cc:41:1: error: included header pem.h is not used directly [misc-include-cleaner,-warnings-as-errors]195 41 | #include <openssl/pem.h>196 | ^~~~~~~~~~~~~~~~~~~~~~~~197 42 | #include <openssl/types.h>198../src/grpc-store.cc:48:1: error: included header unistd.h is not used directly [misc-include-cleaner,-warnings-as-errors]199 48 | #include <unistd.h>200 | ^~~~~~~~~~~~~~~~~~~201 49 | #include <variant>202../src/grpc-store.cc:49:1: error: included header variant is not used directly [misc-include-cleaner,-warnings-as-errors]203 49 | #include <variant>204 | ^~~~~~~~~~~~~~~~~~205 50 | #include <vector>206../src/grpc-store.cc:50:1: error: included header vector is not used directly [misc-include-cleaner,-warnings-as-errors]207 50 | #include <vector>208 | ^~~~~~~~~~~~~~~~~209 51 | 210../src/grpc-store.cc:69:1: error: included header nix_remote.grpc.pb.h is not used directly [misc-include-cleaner,-warnings-as-errors]211 69 | #include "nix_remote.grpc.pb.h"212 | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~213 70 | #include "nix_remote.pb.h"214../src/grpc-store.cc:218:42: error: the parameter 'authority' of type 'ParsedURL::Authority' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]215 218 | GrpcStoreConfig(ParsedURL::Authority authority, const Params ¶ms)216 | ^217 | const &218../src/grpc-store.cc:232:5: error: function 'getReference' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]219 232 | auto getReference() const -> StoreReference override {220 | ^221 | [[nodiscard]] 222../src/grpc-store.cc:243:5: error: function 'openStore' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]223 243 | auto openStore() const -> ref<Store> override;224 | ^225 | [[nodiscard]] 226../src/grpc-store.cc:263:10: error: method 'makeChannel' can be made static [readability-convert-member-functions-to-static,-warnings-as-errors]227 263 | auto makeChannel(bool ownConnection) -> std::shared_ptr<grpc::Channel>228 | ^229 | static 230../src/grpc-store.cc:280:5: error: constructor does not initialize these fields: stub, prefetchedInfos, infoBatch [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]231 259 | GrpcStore(const ref<const Config> &config)232 | ^233../src/grpc-store.cc:356:7: error: variable 'ctx' of type 'grpc::ClientContext' can be declared 'const' [misc-const-correctness,-warnings-as-errors]234 356 | grpc::ClientContext ctx;235 | ^236 | const 237../src/grpc-store.cc:362:7: error: variable 'reply' of type 'remote::QueryValidPathsReply' can be declared 'const' [misc-const-correctness,-warnings-as-errors]238 362 | remote::QueryValidPathsReply reply;239 | ^240 | const 241../src/grpc-store.cc:365:20: error: variable 'res' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]242 365 | StorePathSet res;243 | ^ 244 | = 0245../src/grpc-store.cc:376:7: error: variable 'ctx' of type 'grpc::ClientContext' can be declared 'const' [misc-const-correctness,-warnings-as-errors]246 376 | grpc::ClientContext ctx;247 | ^248 | const 249../src/grpc-store.cc:377:7: error: variable 'request' of type 'remote::QueryMissingRequest' can be declared 'const' [misc-const-correctness,-warnings-as-errors]250 377 | remote::QueryMissingRequest request;251 | ^252 | const 253../src/grpc-store.cc:381:7: error: variable 'reply' of type 'remote::QueryMissingReply' can be declared 'const' [misc-const-correctness,-warnings-as-errors]254 381 | remote::QueryMissingReply reply;255 | ^256 | const 257../src/grpc-store.cc:416:9: error: variable 'ctx' of type 'grpc::ClientContext' can be declared 'const' [misc-const-correctness,-warnings-as-errors]258 416 | grpc::ClientContext ctx;259 | ^260 | const 261../src/grpc-store.cc:418:9: error: variable 'reply' of type 'remote::StoreInfoReply' can be declared 'const' [misc-const-correctness,-warnings-as-errors]262 418 | remote::StoreInfoReply reply;263 | ^264 | const 265../src/grpc-store.cc:431:20: error: variable 'paths' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]266 431 | StorePathSet paths;267 | ^ 268 | = 0269../src/grpc-store.cc:550:9: error: variable 'sink' of type 'StringSink' can be declared 'const' [misc-const-correctness,-warnings-as-errors]270 550 | StringSink sink;271 | ^272 | const 273../src/grpc-store.cc:555:7: error: variable 'ctx' of type 'grpc::ClientContext' can be declared 'const' [misc-const-correctness,-warnings-as-errors]274 555 | grpc::ClientContext ctx;275 | ^276 | const 277../src/grpc-store.cc:565:11: error: variable 'source' of type 'StringSource' can be declared 'const' [misc-const-correctness,-warnings-as-errors]278 565 | StringSource source(msg.done().result());279 | ^280 | const 281../src/grpc-store.cc:598:7: error: variable 'ctx' of type 'grpc::ClientContext' can be declared 'const' [misc-const-correctness,-warnings-as-errors]282 598 | grpc::ClientContext ctx;283 | ^284 | const 285../src/grpc-store.cc:608:11: error: variable 'source' of type 'StringSource' can be declared 'const' [misc-const-correctness,-warnings-as-errors]286 608 | StringSource source(msg.done().results());287 | ^288 | const 289../src/grpc-store.cc:637:22: error: variable 'drvPaths' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]290 637 | StorePathSet drvPaths;291 | ^ 292 | = 0293../src/grpc-store.cc:664:7: error: variable 'source' of type 'StringSource' can be declared 'const' [misc-const-correctness,-warnings-as-errors]294 664 | StringSource source(entry.info());295 | ^296 | const 297../src/grpc-store.cc:682:7: error: variable 'ctx' of type 'grpc::ClientContext' can be declared 'const' [misc-const-correctness,-warnings-as-errors]298 682 | grpc::ClientContext ctx;299 | ^300 | const 301../src/grpc-store.cc:683:7: error: variable 'request' of type 'remote::QueryPathInfosRequest' can be declared 'const' [misc-const-correctness,-warnings-as-errors]302 683 | remote::QueryPathInfosRequest request;303 | ^304 | const 305../src/grpc-store.cc:687:7: error: variable 'reply' of type 'remote::QueryPathInfosReply' can be declared 'const' [misc-const-correctness,-warnings-as-errors]306 687 | remote::QueryPathInfosReply reply;307 | ^308 | const 309../src/grpc-store.cc:748:30: error: variable 'paths' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]310 748 | StorePathSet paths;311 | ^ 312 | = 0313../src/grpc-store.cc:757:15: error: empty catch statements hide issues; to handle exceptions appropriately, consider re-throwing, handling, or avoiding catch altogether [bugprone-empty-catch,-warnings-as-errors]314 757 | } catch (...) {315 | ^316../src/grpc-store.cc:794:12: error: constructor does not initialize these fields: stream [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]317 794 | struct Connection : RemoteStore::Connection318 | ^319 795 | {320 796 | private:321 797 | friend struct GrpcStore;322 798 | 323 799 | // RemoteStore::Connection speaks through FdSink/FdSource, so bridge the324 800 | // gRPC stream to a pair of pipes with pump threads. This keeps the325 801 | // blocking, ordered semantics the worker protocol relies on without326 802 | // reimplementing Source/Sink on top of gRPC.327 803 | grpc::ClientContext ctx;328 804 | std::unique_ptr<GrpcStream> stream;329 | 330 | {}331../src/grpc-store.cc:865:24: error: rvalue reference parameter 'pathsToCopy_' is never moved from inside the function body [cppcoreguidelines-rvalue-reference-param-not-moved,-warnings-as-errors]332 865 | PathsSource && pathsToCopy_, Activity & act, RepairFlag repair, CheckSigsFlag checkSigs) override333 | ^334../src/grpc-store.cc:868:9: error: variable 'bytesExpected' of type 'uint64_t' (aka 'unsigned long long') can be declared 'const' [misc-const-correctness,-warnings-as-errors]335 868 | uint64_t bytesExpected = 0;336 | ^337 | const 338../src/grpc-store.cc:874:9: error: variable 'ctx' of type 'grpc::ClientContext' can be declared 'const' [misc-const-correctness,-warnings-as-errors]339 874 | grpc::ClientContext ctx;340 | ^341 | const 342../src/grpc-store.cc:875:9: error: variable 'reply' of type 'remote::AddMultipleReply' can be declared 'const' [misc-const-correctness,-warnings-as-errors]343 875 | remote::AddMultipleReply reply;344 | ^345 | const 346../src/nar-fetcher.hh:44:5: error: constructor does not initialize these fields: sessions, buffers, pending, narSizes [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]347 44 | NarFetcher(348 | ^349../src/nar-fetcher.hh:59:22: error: 2 adjacent parameters of 'recordOrder' of similar type ('int') are easily swapped by mistake [bugprone-easily-swappable-parameters,-warnings-as-errors]350 59 | void recordOrder(std::vector<nix::StorePath> order, std::map<nix::StorePath, uint64_t> sizes)351 | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~352../src/nar-fetcher.hh:59:50: note: the first parameter in the range is 'order'353 59 | void recordOrder(std::vector<nix::StorePath> order, std::map<nix::StorePath, uint64_t> sizes)354 | ^~~~~355../src/nar-fetcher.hh:59:92: note: the last parameter in the range is 'sizes'356 59 | void recordOrder(std::vector<nix::StorePath> order, std::map<nix::StorePath, uint64_t> sizes)357 | ^~~~~358../src/nar-fetcher.hh:96:5: error: use '= default' to define a trivial destructor [modernize-use-equals-default,-warnings-as-errors]359 96 | ~NarFetcher()360 | ^361../src/nar-fetcher.hh:121:13: error: 'fd' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer,-warnings-as-errors]362 117 | SpoolBuffer()363 | 364 | : fd(std::move(tmpFd))365 118 | {366 119 | auto [tmpFd, tmpPath] = nix::createTempFile("nix-grpc-nar");367 120 | ::unlink(tmpPath.c_str());368 121 | fd = std::move(tmpFd);369 | ^~~~~~~~~~~~~~~~~~~~~~370../src/nar-fetcher.hh:206:14: error: method 'run' can be made static [readability-convert-member-functions-to-static,-warnings-as-errors]371 206 | void run()372 | ^373 | static 374../src/nar-fetcher.hh:210:17: error: variable 'frame' of type 'nix::remote::NarFrame' can be declared 'const' [misc-const-correctness,-warnings-as-errors]375 210 | nix::remote::NarFrame frame;376 | ^377 | const 378../src/nar-fetcher.hh:235:15: error: empty catch statements hide issues; to handle exceptions appropriately, consider re-throwing, handling, or avoiding catch altogether [bugprone-empty-catch,-warnings-as-errors]379 235 | } catch (...) {380 | ^381../src/nar-fetcher.hh:253:24: error: method 'narSizeOf' can be made static [readability-convert-member-functions-to-static,-warnings-as-errors]382 253 | [[nodiscard]] auto narSizeOf(const nix::StorePath & path) const -> uint64_t383 | ^ ~~~~~384 | static 385../src/pump.hh:65:27: error: 2 adjacent parameters of 'readCoalesced' of similar type ('int') are easily swapped by mistake [bugprone-easily-swappable-parameters,-warnings-as-errors]386 65 | inline auto readCoalesced(int sourceFd, std::span<char> buf) -> ssize_t387 | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~388../src/pump.hh:65:31: note: the first parameter in the range is 'sourceFd'389 65 | inline auto readCoalesced(int sourceFd, std::span<char> buf) -> ssize_t390 | ^~~~~~~~391../src/pump.hh:65:57: note: the last parameter in the range is 'buf'392 65 | inline auto readCoalesced(int sourceFd, std::span<char> buf) -> ssize_t393 | ^~~394../src/pump.hh:159:23: error: variable 'count' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]395 159 | ssize_t const count = readCoalesced(sourceFd, input);396 | ^ 397 | = 0398../src/pump.hh:276:44: error: the parameter 'initial' of type 'std::string' (aka 'basic_string<char>') is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]399 276 | static auto makeInitialMsg(std::string initial) -> Msg400 | ^401 | const &402../version:1:1: error: expected unqualified-id [clang-diagnostic-error]403 1 | 0.1.0404 | ^405/nix/store/mcbznvdb0xcncmv55gkg8gvyjjasn46k-abseil-cpp-20260107.1-dev/include/absl/meta/type_traits.h:205:24: error: no template named 'result_of' in namespace 'std' [clang-diagnostic-error]406 205 | using result_of = std::result_of<F>;407 | ~~~~~^408FAILED: [code=1] meson-internal__clang-tidy 409/nix/store/by8lz2aj6nw13mm1mv08vr1gqlmz0ih5-meson-1.10.2/bin/meson --internal clangtidy /nix/var/nix/builds/nix-50194-160511831/source /nix/var/nix/builds/nix-50194-160511831/source/build --color always410ninja: build stopped: subcommand failed.